ext/mysqli: Mark return type as zend_return (#15345)

ext/mysqli: Improve variable name and type

Preferably include from build dir (#13516)

* Include from build dir first

This fixes out of tree builds by ensuring that configure artifacts are included
from the build dir.

Preferably include from build dir (#13516)

* Include from build dir first

This fixes out of tree builds by ensuring that configure artifacts are included
from the build dir.

Before, out of tree builds would preferably include files from the src dir, as
the include path was defined as follows (ignoring includes from ext/ and sapi/) :

-I$(top_builddir)/main
-I$(top_srcdir)
-I$(top_builddir)/TSRM
-I$(top_builddir)/Zend
-I$(top_srcdir)/main
-I$(top_srcdir)/Zend
-I$(top_srcdir)/TSRM
-I$(top_builddir)/

As a result, an out of tree build would include configure artifacts such as
`main/php_config.h` from the src dir.

After this change, the include path is defined as follows:

-I$(top_builddir)/main
-I$(top_builddir)
-I$(top_srcdir)/main
-I$(top_srcdir)
-I$(top_builddir)/TSRM
-I$(top_builddir)/Zend
-I$(top_srcdir)/Zend
-I$(top_srcdir)/TSRM

* Fix extension include path for out of tree builds

* Include config.h with the brackets form

`#include "config.h"` searches in the directory containing the including-file
before any other include path. This can include the wrong config.h when building
out of tree and a config.h exists in the source tree.

Using `#include <config.h>` uses exclusively the include path, and gives
priority to the build dir.

show more ...

Clean-up unused headers (#14365)

* ext/mbstring.c: clean-up headers and include intrinsics

Clear mysql error in fetch_into

Closes GH-14256

Fix GCC warning when using getThis() in a conditional (#13923)

Since GCC 12.x, using getThis() in a conditional yields a warning:

<source>:12:22: warning: the comparison will al

Fix GCC warning when using getThis() in a conditional (#13923)

Since GCC 12.x, using getThis() in a conditional yields a warning:

<source>:12:22: warning: the comparison will always evaluate as 'true' for
the address of 'This' will never be NULL [-Waddress]
12 | return getThis() ? 2 : 3;
| ^

show more ...

ext/mysqli/pgsql: mysqli_fetch_object/pgsql_fetch_object raises ValueError on constructor args error.

Closes GH-10832.

Use zend_call_known_function() in ext-mysqli instead of building FCI/FCC

mysqli_query throws warning despite using silenced error mode (#9842)

Remove most usages of zend_fcall_info_args()

This reallocates the PHP array when one can just use the named_params fields to pass the positional arguments instead.

Only usage of zen

Remove most usages of zend_fcall_info_args()

This reallocates the PHP array when one can just use the named_params fields to pass the positional arguments instead.

Only usage of zend_fcall_info_args(_ex) remains in PDO.

show more ...

Update INI validator and displayers depending on INI type

Closes GH-9451

Use php_info_print_table_header for actual column headers only (#9485)

Using php_info_print_table_header() for "Foo: bar" looks odd and out of place,
because the whole line is colored. I

Use php_info_print_table_header for actual column headers only (#9485)

Using php_info_print_table_header() for "Foo: bar" looks odd and out of place,
because the whole line is colored. It is also questionable from a HTML
semantics point of view, because it does not described the columns that follow.

The use of this across extensions is inconsistent. It was part of the skeleton,
but ext/date or ext/json already use a regular row.

show more ...

Declare ext/mysqli constants in stubs (#8811)

Update gen_stub to support #if around classes

Mark parameter in ext/mysqli as sensitive

Add support for sensitive parameters in stubs

Remove mysqli_driver::$reconnect property

The INI mysqli.reconnect directive has been removed.

Remove MYSQLI_USE_MYSQLND constant and all the code with it

Merge branch 'PHP-8.1'

* PHP-8.1:
Fix GH-8068: mysqli_fetch_object creates inaccessible properties

Merge branch 'PHP-8.0' into PHP-8.1

* PHP-8.0:
Fix GH-8068: mysqli_fetch_object creates inaccessible properties

Fix GH-8068: mysqli_fetch_object creates inaccessible properties

When fetching into objects, we need to create object style hash tables,
i.e. where numeric column names are stored as str

Fix GH-8068: mysqli_fetch_object creates inaccessible properties

When fetching into objects, we need to create object style hash tables,
i.e. where numeric column names are stored as string keys instead of
integer keys. Instead of the slightly more efficient alternative to
create the desired hash table in the first place, we go for the more
readable implementation and convert the array style hash table using
`zend_symtable_to_proptable()`.

Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>

Closes GH-8189.

show more ...

mysqli_result::__construct should throw exceptions (#7855)

Merge branch 'PHP-8.1'

* PHP-8.1:
Fix #81658: MYSQL_OPT_LOAD_DATA_LOCAL_DIR not available in MariaDB

Fix #81658: MYSQL_OPT_LOAD_DATA_LOCAL_DIR not available in MariaDB

This also introduces the boolean userland constant `MYSQLI_IS_MARIADB`.