Fix GCC warning when using getThis() in a conditional (#13923)

Since GCC 12.x, using getThis() in a conditional yields a warning:

<source>:12:22: warning: the comparison will al

Fix GCC warning when using getThis() in a conditional (#13923)

Since GCC 12.x, using getThis() in a conditional yields a warning:

<source>:12:22: warning: the comparison will always evaluate as 'true' for
the address of 'This' will never be NULL [-Waddress]
12 | return getThis() ? 2 : 3;
| ^

show more ...

ext/mysqli/pgsql: mysqli_fetch_object/pgsql_fetch_object raises ValueError on constructor args error.

Closes GH-10832.

Use zend_call_known_function() in ext-mysqli instead of building FCI/FCC

mysqli_query throws warning despite using silenced error mode (#9842)

Remove most usages of zend_fcall_info_args()

This reallocates the PHP array when one can just use the named_params fields to pass the positional arguments instead.

Only usage of zen

Remove most usages of zend_fcall_info_args()

This reallocates the PHP array when one can just use the named_params fields to pass the positional arguments instead.

Only usage of zend_fcall_info_args(_ex) remains in PDO.

show more ...

Update INI validator and displayers depending on INI type

Closes GH-9451

Use php_info_print_table_header for actual column headers only (#9485)

Using php_info_print_table_header() for "Foo: bar" looks odd and out of place,
because the whole line is colored. I

Use php_info_print_table_header for actual column headers only (#9485)

Using php_info_print_table_header() for "Foo: bar" looks odd and out of place,
because the whole line is colored. It is also questionable from a HTML
semantics point of view, because it does not described the columns that follow.

The use of this across extensions is inconsistent. It was part of the skeleton,
but ext/date or ext/json already use a regular row.

show more ...

Declare ext/mysqli constants in stubs (#8811)

Update gen_stub to support #if around classes

Mark parameter in ext/mysqli as sensitive

Add support for sensitive parameters in stubs

Remove mysqli_driver::$reconnect property

The INI mysqli.reconnect directive has been removed.

Remove MYSQLI_USE_MYSQLND constant and all the code with it

Merge branch 'PHP-8.1'

* PHP-8.1:
Fix GH-8068: mysqli_fetch_object creates inaccessible properties

Merge branch 'PHP-8.0' into PHP-8.1

* PHP-8.0:
Fix GH-8068: mysqli_fetch_object creates inaccessible properties

Fix GH-8068: mysqli_fetch_object creates inaccessible properties

When fetching into objects, we need to create object style hash tables,
i.e. where numeric column names are stored as str

Fix GH-8068: mysqli_fetch_object creates inaccessible properties

When fetching into objects, we need to create object style hash tables,
i.e. where numeric column names are stored as string keys instead of
integer keys. Instead of the slightly more efficient alternative to
create the desired hash table in the first place, we go for the more
readable implementation and convert the array style hash table using
`zend_symtable_to_proptable()`.

Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>

Closes GH-8189.

show more ...

mysqli_result::__construct should throw exceptions (#7855)

Merge branch 'PHP-8.1'

* PHP-8.1:
Fix #81658: MYSQL_OPT_LOAD_DATA_LOCAL_DIR not available in MariaDB

Fix #81658: MYSQL_OPT_LOAD_DATA_LOCAL_DIR not available in MariaDB

This also introduces the boolean userland constant `MYSQLI_IS_MARIADB`.

Use more compact representation for packed arrays.

- for packed arrays we store just an array of zvals without keys.
- the elements of packed array are accessible throuf as ht->arPacked[

Use more compact representation for packed arrays.

- for packed arrays we store just an array of zvals without keys.
- the elements of packed array are accessible throuf as ht->arPacked[i]
instead of ht->arData[i]
- in addition to general ZEND_HASH_FOREACH_* macros, we introduced similar
familied for packed (ZEND_HASH_PACKED_FORECH_*) and real hashes
(ZEND_HASH_MAP_FOREACH_*)
- introduced an additional family of macros to access elements of array
(packed or real hashes) ZEND_ARRAY_ELEMET_SIZE, ZEND_ARRAY_ELEMET_EX,
ZEND_ARRAY_ELEMET, ZEND_ARRAY_NEXT_ELEMENT, ZEND_ARRAY_PREV_ELEMENT
- zend_hash_minmax() prototype was changed to compare only values

Because of smaller data set, this patch may show performance improvement
on some apps and benchmarks that use packed arrays. (~1% on PHP-Parser)

TODO:
- sapi/phpdbg needs special support for packed arrays (WATCH_ON_BUCKET).
- zend_hash_sort_ex() may require converting packed arrays to hash.

show more ...

Revert "Fix bug GH-1 (mysqli_sql_exception->sqlstate is inaccessible)"

This reverts commit 64fca5c5f0d18a3fec59a040935a6da5071072af.

Fix bug GH-1 (mysqli_sql_exception->sqlstate is inaccessible)

Merge branch 'PHP-8.1'

* PHP-8.1:
Fixed bug #81494

Merge branch 'PHP-8.0' into PHP-8.1

* PHP-8.0:
Fixed bug #81494