Use fabsf() and floorf() unconditionally in bundled libgd (#13624)

These are available since C99 with math.h also on Windows, without
requiring checking. Upstream libgd uses floorf() unc

Use fabsf() and floorf() unconditionally in bundled libgd (#13624)

These are available since C99 with math.h also on Windows, without
requiring checking. Upstream libgd uses floorf() unconditionally and
doesn't use fabsf().

show more ...

Add avif support to ext/gd

This backports avif support from upstream libgd into bundled libgd
and exposes the functionality through new imagecreatefromavif()
and imageavif() function

Add avif support to ext/gd

This backports avif support from upstream libgd into bundled libgd
and exposes the functionality through new imagecreatefromavif()
and imageavif() functions.

Closes GH-7026.

Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Fix #81032: GD install is affected by external libgd installation

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Fix #81032: GD install is affected by external libgd installation

Fix #81032: GD install is affected by external libgd installation

This PR replaces the bundled libgd includes from #include <foo.h> with
#include "foo.h" for gd-related headers to avoid

Fix #81032: GD install is affected by external libgd installation

This PR replaces the bundled libgd includes from #include <foo.h> with
#include "foo.h" for gd-related headers to avoid including headers that
may be available in system directories instead of the expected local
headers.

Closes GH-6975.

show more ...

Introduce pseudo-keyword ZEND_FALLTHROUGH

And use it instead of comments

Merge branch 'PHP-7.4'

* PHP-7.4:
Fix #79676: imagescale adds black border with IMG_BICUBIC

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fix #79676: imagescale adds black border with IMG_BICUBIC

Fix #79676: imagescale adds black border with IMG_BICUBIC

We have to loop over all image pixels to avoid the black border. This
is also done in external libgd in `_gdScaleOneAxis` and `

Fix #79676: imagescale adds black border with IMG_BICUBIC

We have to loop over all image pixels to avoid the black border. This
is also done in external libgd in `_gdScaleOneAxis` and `_gdScalePass`.

show more ...

Fix [-Wtype-limits] in bundled GD lib by using signed integers

As seen in the gdImageRotateBicubicFixed() function the same setup
occurs but it uses signed integers, therefore we use als

Fix [-Wtype-limits] in bundled GD lib by using signed integers

As seen in the gdImageRotateBicubicFixed() function the same setup
occurs but it uses signed integers, therefore we use also use
signed integers in gdImageRotateBilinear()

Moreover, these two functions have been removed upstream in
https://github.com/libgd/libgd/commit/bd6d2e101f6f1df106d1cd2e2dc8058a5538109b
therefore we should also mimic upstream and remove them...

Thanks to @cmb69 for pointing it out.

show more ...

Add imagegetinterpolation()

While `imagesetinterpolation()` is available as of PHP 5.5.0,
there is no according getter function, so users would have to track the
current interpolatio

Add imagegetinterpolation()

While `imagesetinterpolation()` is available as of PHP 5.5.0,
there is no according getter function, so users would have to track the
current interpolation method manually.

To remedy this, we introduce `imagegetinterpolation()` as thin wrapper
for `gdImageGetInterpolationMethod()` (which has been introduced with
libgd 2.1.1), and use `im->interpolation_id` as fallback for older
libgd. Since our bundled libgd does not yet have this function, we add
it.

We also simplify the recently introduced bug79068.phpt, where it is
sufficient to check that the interpolation method has not been changed.

show more ...

Fix hypothetical segfault in gdTransformAffineCopy()

This has been reported to upstream[1], but since ext/gd never calls
`gdTransformAffineCopy()` for a palette image, it is not a bug fo

Fix hypothetical segfault in gdTransformAffineCopy()

This has been reported to upstream[1], but since ext/gd never calls
`gdTransformAffineCopy()` for a palette image, it is not a bug for PHP.
Therefore we apply the fix to master only.

[1] <https://github.com/libgd/libgd/issues/586>

show more ...

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fix #79068: gdTransformAffineCopy() changes interpolation method

Fix #79068: gdTransformAffineCopy() changes interpolation method

We port
<https://github.com/libgd/libgd/commit/9088591eae437358ee5b929adf82865e37e3001e>.

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fix #79067: gdTransformAffineCopy() may use unitialized values

Fix #79067: gdTransformAffineCopy() may use unitialized values

We port
<https://github.com/libgd/libgd/commit/7a06c1669c563917bc48c464521e3de962ddb4e8>.

Use e.g. instead of less common f.e. [ci skip]

Suppress shift UB in gd_itofx()

There doesn't seem to be a corresponding upstream fix for this.

Remove unused _setEdgePixel() and getPixelOverflowColorTC() functions

Fix fabs warning in gd_interpolation.c

Matches upstream code.

Fix misleading variable type

We port libgd/libgd@0414bb2da0b27d90b6125bd34a3e2cfb89fd3f42.

Remove unused variables and functions

We remove the unused variables altogether, and port
libgd/libgd@f50c24e467f1f44f0ede90bc7d2d8eaadbe11094 to silence the
compiler warnings.

Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
Fix #73281: imagescale(…, IMG_BILINEAR_FIXED) can cause black border

Fix #73281: imagescale(…, IMG_BILINEAR_FIXED) can cause black border

We port the upstream fixes for libgd/libgd#329 and libgd/libgd#224.

Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
Fix #77272: imagescale() may return image resource on failure