History log of /php-src/ext/dom/tests/modern/xml/Node_removeChild_from_comment.phpt (Results 1 – 1 of 1)
Revision Date Author Comments
# c66221b7 29-Jun-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix arginfo violation in removeChild() (#14717)

It was possible to return false without throwing an exception.
This is even wrong in "old DOM" because we expect either a NOT_FOUND_ERR

Fix arginfo violation in removeChild() (#14717)

It was possible to return false without throwing an exception.
This is even wrong in "old DOM" because we expect either a NOT_FOUND_ERR
or NO_MODIFICATION_ALLOWED_ERR according to the documentation.
A side effect of this patch is that it prioritises NOT_FOUND_ERR over
NO_MODIFICATION_ALLOWED_ERR but I think that's fine.

show more ...