#
65fbf474 |
| 30-Oct-2024 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Fix static analysis warning The condition is already checked at the start of the function, mark this code properly as unreachable.
|
#
947e319b |
| 25-Oct-2024 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Fix GH-16594: Assertion failure in DOM -> before The invalid parent condition can actually happen because PHP's DOM is allows to get children of e.g. attributes; something normally not
Fix GH-16594: Assertion failure in DOM -> before The invalid parent condition can actually happen because PHP's DOM is allows to get children of e.g. attributes; something normally not possible. Closes GH-16597.
show more ...
|
#
97546746 |
| 25-Sep-2024 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Merge branch 'PHP-8.3' into PHP-8.4 * PHP-8.3: Fix GH-16039: Segmentation fault (access null pointer) in ext/dom/parentnode/tree.c
|
#
9435f4d5 |
| 18-Jul-2024 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Throw instead of silently failing when creating a too long text node Lower branches suffer from this as well but we cannot change the behaviour there. We also add NULL checks to chec
Throw instead of silently failing when creating a too long text node Lower branches suffer from this as well but we cannot change the behaviour there. We also add NULL checks to check for allocation failure. Closes GH-15014.
show more ...
|
#
d5faf44e |
| 21-Jul-2024 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Remove bogus tree setting code from parentnode/tree.c (#15044) I don't know why this code was here in the first place, it is present since the initial implementation. It doesn't make sen
Remove bogus tree setting code from parentnode/tree.c (#15044) I don't know why this code was here in the first place, it is present since the initial implementation. It doesn't make sense because: 1. It would require updating the refcounts if the document wasn't actually already set. 2. We enforce that the document is the same as the target document by this point, so setting the tree is pointless.
show more ...
|
#
29466223 |
| 20-Jul-2024 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Move stricterror fetch to dom_child_removal_preconditions() body |
#
74116a4a |
| 20-Jul-2024 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Remove impossible condition The parent's child must exist because otherwise this node could not have a parent node. |
#
80a4783d |
| 18-Jul-2024 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Deduplicate NULL checks in ext/dom (#15015) This introduces a new helper php_dom_create_nullable_object() that does the NULL check and puts NULL in return_value. Otherwise it runs ph
Deduplicate NULL checks in ext/dom (#15015) This introduces a new helper php_dom_create_nullable_object() that does the NULL check and puts NULL in return_value. Otherwise it runs php_dom_create_object(). This deduplicates a bit of code.
show more ...
|
#
88da9149 |
| 27-Apr-2024 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Implement CSS selectors |