Use common helper macro for getting the node in property handlers

Remove redundant namespace define

Use BAD_CAST consistently

Use true instead of 1 with php_dom_throw_error

Change stricterror type to bool

Simplify DOM_RET_OBJ macro

[RFC] Add a way to opt-in ext/dom spec compliance (#13031)

RFC: https://wiki.php.net/rfc/opt_in_dom_spec_compliance

Fix unlikely memory leak in case of namespace removal with extremely deep trees

Give anonymous dom structs a name (#13135)

Fix crash when toggleAttribute() is used without a document

Fix GH-12616: DOM: Removing XMLNS namespace node results in invalid default: prefix

The namespace data is freed and set to NULL, but there remain references
to the namespace declaration

Fix GH-12616: DOM: Removing XMLNS namespace node results in invalid default: prefix

The namespace data is freed and set to NULL, but there remain references
to the namespace declaration nodes. This (rightfully) confuses libxml2
because its invariants are broken. We also have to remove all remaining
references from the subtree. This fixes the data corruption bug.

Closes GH-12681.

show more ...

Fix cloning attribute with namespace disappearing namespace

Closes GH-12547.

Fix #47531: No way of removing redundant xmlns: declarations

Now it's possible via removeAttribute("xmlns:prefix").
It was not possible to reuse a libxml2 function to reconcile because i

Fix #47531: No way of removing redundant xmlns: declarations

Now it's possible via removeAttribute("xmlns:prefix").
It was not possible to reuse a libxml2 function to reconcile because it
does not align with DOM behaviour.

Closes GH-12542.

show more ...

Replace always-false attribute type check with assertion

The type will always be XML_ATTRIBUTE_NODE by construction via
php_dom_create_object, no need to check the type. Use an assertion

Replace always-false attribute type check with assertion

The type will always be XML_ATTRIBUTE_NODE by construction via
php_dom_create_object, no need to check the type. Use an assertion
instead. This simplifies code and reasoning about error conditions.

show more ...

Use zend_result as return for properties in ext/dom (#12113)

Fix various namespace prefix conflict resolution bugs and namespace shift bugs

There are two linked issues:

- Conflicts couldn't be resolved by changing the prefix name.
- Lacki

Fix various namespace prefix conflict resolution bugs and namespace shift bugs

There are two linked issues:

- Conflicts couldn't be resolved by changing the prefix name.
- Lacking a prefix would shift the namespace as the default namespace,
causing elements to suddenly become part of the namespace instead of
the attributes.

The output could still be improved by removing redundant namespace
declarations, but that's another issue. At least the output is
correct now.

Closes GH-11777.

show more ...

Fix #80927: Removing documentElement after creating attribute node: possible use-after-free

Closes GH-11892.

Fix manually calling __construct() on DOM classes

Closes GH-11894.

Fix empty argument cases for DOMParentNode methods

Closes GH-11768.

Fix incorrect attribute existence check in DOMElement::setAttributeNodeNS()

Closes GH-11776.

Remove useless readonly checks

These checks will always be false because we're dealing with elements
here. DOMElement always are of type XML_ELEMENT_NODE, so they don't need
to be ch

Remove useless readonly checks

These checks will always be false because we're dealing with elements
here. DOMElement always are of type XML_ELEMENT_NODE, so they don't need
to be checked.

show more ...

Use xmlSetNsProp when possible to prevent parsing the name

The normal xmlSetProp() function parses the name to find the namespace.
But we don't care about the namespace in this case.

Implement DOMElement::toggleAttribute()

ref: https://dom.spec.whatwg.org/#dom-element-toggleattribute

Closes GH-11696.

Split off some methods so they can be reused in different places

Implement DOMElement::insertAdjacent{Element,Text} (#11700)

* Implement DOMElement::insertAdjacent{Element,Text}

ref: https://dom.spec.whatwg.org/#dom-element-insertadjacentelement

Implement DOMElement::insertAdjacent{Element,Text} (#11700)

* Implement DOMElement::insertAdjacent{Element,Text}

ref: https://dom.spec.whatwg.org/#dom-element-insertadjacentelement
ref: https://dom.spec.whatwg.org/#dom-element-insertadjacenttext

Closes GH-11700.

show more ...