test: switch to new-style ASSERT_EQ macros (#4159)

Switch from old-style ASSERT macro to new-style ASSERT_EQ,... macros.

Using new-style macros makes it easier to debug test failure

test: switch to new-style ASSERT_EQ macros (#4159)

Switch from old-style ASSERT macro to new-style ASSERT_EQ,... macros.

Using new-style macros makes it easier to debug test failures

Fixes: https://github.com/libuv/libuv/issues/2974

show more ...

barrier: wait for prior out before next in (#3905)

This code would previously get confused between rounds of the barrier
being called and a thread might incorrectly get stuck (deadlock)

barrier: wait for prior out before next in (#3905)

This code would previously get confused between rounds of the barrier
being called and a thread might incorrectly get stuck (deadlock) if the
next round started before that thread had exited the current round.

Avoid that by not starting the next round in++ before out-- has reached
zero indicating that all threads have left the prior round.

And fix it that on Windows by replacing the implementation with the one
from unix. There are some awkward platform-specific redirection here
with an extra malloc that is not needed on Win32, but that will be fixed
in libuv v2.

Fixes: https://github.com/libuv/libuv/issue/3872

show more ...

test: add uv_barrier_wait serial thread test

Ensure that uv_barrier_wait returns positive only after all threads have
exited the barrier. If this value is returned too early and the barr

test: add uv_barrier_wait serial thread test

Ensure that uv_barrier_wait returns positive only after all threads have
exited the barrier. If this value is returned too early and the barrier
is destroyed prematurely, then this test may see a crash.

PR-URL: https://github.com/libuv/libuv/pull/2019
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

show more ...

Revert "test: make barrier test more rigorous"

This reverts commit 6c6c9221679c6cc66ac30fbad5ce086658113ea3.

It introduced a race condition which made tests fail on Linux and SunOS.

Revert "test: make barrier test more rigorous"

This reverts commit 6c6c9221679c6cc66ac30fbad5ce086658113ea3.

It introduced a race condition which made tests fail on Linux and SunOS.

Closes #1340

show more ...

test: make barrier test more rigorous

A correct barriers implementation blocks in uv_barrier_destroy() until
the last thread returns from uv_barrier_wait() so make the test more
rigo

test: make barrier test more rigorous

A correct barriers implementation blocks in uv_barrier_destroy() until
the last thread returns from uv_barrier_wait() so make the test more
rigorous by destroying the barrier straight away instead of first
joining the worker thread.

Signed-off-by: Fedor Indutny <fedor@indutny.com>

show more ...

unix, windows: make uv_barrier_wait() return bool

Make uv_barrier_wait() return a boolean value indicating whether this
thread was the "serializer".

From `man pthread_barrier_wa

unix, windows: make uv_barrier_wait() return bool

Make uv_barrier_wait() return a boolean value indicating whether this
thread was the "serializer".

From `man pthread_barrier_wait`:

Upon successful completion, the pthread_barrier_wait() function
shall return PTHREAD_BARRIER_SERIAL_THREAD for a single (arbitrary)
thread synchronized at the barrier and zero for each of the other
threads.

Exposing that information from libuv is useful because it can make
cleanup significantly easier:

if (uv_barrier_wait(&barrier) > 0)
uv_barrier_destroy(&barrier);

Signed-off-by: Fedor Indutny <fedor@indutny.com>

show more ...

unix, windows: add thread barrier support