#
d48747b2 |
| 22-Sep-2024 |
Viktor Szakats |
GHA/windows: mark 3023, 3024 flaky for mingw-w64 7.3.0 job They became flaky recently as reported by Testclutch and firsthand observations. It's curious because it only seems to happen i
GHA/windows: mark 3023, 3024 flaky for mingw-w64 7.3.0 job They became flaky recently as reported by Testclutch and firsthand observations. It's curious because it only seems to happen in 7.3.0, but not in the very similar (except non-Unicode) 9.5.0 job. We've found no explanation or reason for them so far. ``` test 3023...[HTTPS GET to localhost, first subject alt name matches, CN does not match (Schannel variant)] 3023: protocol FAILED! There was no content at all in the file log/14/server.input. Server glitch? Total curl failure? Returned: 7 ``` Ref: https://github.com/curl/curl/actions/runs/10871191391/job/30164710777?pr=14918#step:13:4849 ``` test 3024...[HTTPS GET to localhost, last subject alt name matches, CN does not match (Schannel variant)] 3024: protocol FAILED! There was no content at all in the file log/8/server.input. Server glitch? Total curl failure? Returned: 7 ``` Ref: https://github.com/curl/curl/actions/runs/10871191391/job/30164710777?pr=14918#step:13:4713 ``` FAIL 3023: 'HTTPS GET to localhost, first subject alt name matches, CN does not match (Schannel variant)' HTTPS, HTTP GET, PEM certificate FAIL 3024: 'HTTPS GET to localhost, last subject alt name matches, CN does not match (Schannel variant)' HTTPS, HTTP GET, PEM certificate ``` https://github.com/curl/curl/actions/runs/10982991876/job/30491895264?pr=14930#step:14:4914 https://github.com/curl/curl/actions/runs/10871191391/job/30164710777?pr=14918 https://github.com/curl/curl/actions/runs/10841065505/job/30084573629?pr=14859#step:13:5484 https://github.com/curl/curl/actions/runs/10858001821/job/30135376138?pr=14906#step:13:4841 Reported-by: Testclutch Fixes https://github.com/curl/curl/pull/14905#issuecomment-2350772804 Ref: https://github.com/curl/curl/discussions/14854#discussioncomment-10652044 Closes #15006
show more ...
|
#
22652a5a |
| 18-Aug-2024 |
Viktor Szakats |
curl: add options for safe/no CA bundle search (Windows) Add `CURL_CA_SEARCH_SAFE` build-time option to enable CA bundle search in the `curl` tool directory. The lookup method was alread
curl: add options for safe/no CA bundle search (Windows) Add `CURL_CA_SEARCH_SAFE` build-time option to enable CA bundle search in the `curl` tool directory. The lookup method was already used to find `.curlrc` and `_curlrc` (on Windows). On Windows it overrides the unsafe default `SearchPath()` method. Enable with: - cmake: `-DCURL_CA_SEARCH_SAFE=ON` - autotools: `--enable-ca-search-safe` - raw: `CPPFLAGS=-DCURL_CA_SEARCH_SAFE` On Windows, before this patch the whole `PATH` was searched for a CA bundle. `PATH` may contain unwanted or world-writable locations, including the current directory. Searching them all is convenient to pick up any CA bundle, but not secure. The Muldersoft curl distro implements such CA search via a custom patch for Windows: https://github.com/lordmulder/cURL-build-win32/blob/cd652d4792c177c98b08b4309d3cac2b8dbbf9b0/patch/curl_tool_doswin.diff#L50 MSYS2/mingw-w64 distro has also been rolling a patch solving this: https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-curl/0001-Make-cURL-relocatable.patch https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-curl/pathtools.c Also add option to fully disable Windows CA search: - cmake: `-DCURL_DISABLE_CA_SEARCH=ON` - autotools: `--disable-ca-search` - raw: `CPPFLAGS=-DCURL_DISABLE_CA_SEARCH`. Both options are considered EXPERIMENTAL, with possible incompatible changes or even (partial) removal in the future, depending on feedback. An alternative, secure option is to embed the CA bundle into the binary. Safe search can be extended to other platforms if necessary or useful, by using `_NSGetExecutablePath()` (macOS), `/proc/self/exe` (Linux/Cygwin), or `argv[0]`. Closes #14582
show more ...
|
#
11241704 |
| 22-Sep-2024 |
Viktor Szakats |
GHA/windows: formatting Follow-up to 1b8449674adb57ee0f60e761d654c69b20ee8fcf #14992
|
#
1b844967 |
| 21-Sep-2024 |
Viktor Szakats |
GHA: use more ninja, build examples in the last step, and more - linux: bump up test parallelism for valgrind tests to `-j4` (from `-j2`). (EXPERIMENTAL) - linux: drop `apt-get upd
GHA: use more ninja, build examples in the last step, and more - linux: bump up test parallelism for valgrind tests to `-j4` (from `-j2`). (EXPERIMENTAL) - linux: drop `apt-get update` for the default architecture on the GHA native runner. It makes prereq install steps complete faster. The runner image gets weekly updates, and that should be enough to guarantee fresh packages in most cases: https://github.com/actions/runner-images/commits/main/images/ubuntu/Ubuntu2204-Readme.md - aws-lc: use ninja with cmake. - aws-lc: build examples with cmake. - aws-lc: drop `apt update`. - aws-lc, wolfssl, linux32, http3-linux: move building examples to the last step. Follow-up to 45202cbba4bb3d12b4469063864b57d2f8765d9c #14906 - windows: formatting. Closes #14992
show more ...
|
#
4b378ea4 |
| 21-Sep-2024 |
Viktor Szakats |
GHA: revert some build test steps added by #14772 They are still slow in these jobs/combinations. - non-native/FreeBSD/arm64 autotools +36s - non-native/FreeBSD/arm64 cmake +1m
GHA: revert some build test steps added by #14772 They are still slow in these jobs/combinations. - non-native/FreeBSD/arm64 autotools +36s - non-native/FreeBSD/arm64 cmake +1m - windows/linux-cross-mingw-w64 autotools +33s These ones remain: - linux/aws-lc cmake +6s - windows/linux-cross-mingw-w64 cmake +12s Follow-up to 71cf0d1fca9e1f53524e1545ef0c08d174458d80 #14772
show more ...
|
#
71cf0d1f |
| 02-Sep-2024 |
Viktor Szakats |
tests: speed up builds with single-binary test bundles Add support for single-block binaries that contain all libtests and unit tests respectively. Enable with: - autotools:
tests: speed up builds with single-binary test bundles Add support for single-block binaries that contain all libtests and unit tests respectively. Enable with: - autotools: `--enable-test-bundles` - cmake: `-DCURL_TEST_BUNDLES=ON` (They are compatible with `--enable-unity` and `-DCMAKE_UNITY_BUILD=ON` options, for further speed-up.) Makes libtests and unit tests build _fast_, needing little disk space even in static mode. Similar to CMake unity mode, but with a custom script, also supporting autotools builds. The price is having to deal with symbols/macros colliding between `lib*.c` and `unit*.c` sources. Maybe with naming conventions or other solutions this can be improved gradually and reduce the need for manual intervention by `mk-bundle.mk`. I've included a script that does the bulk of detecting name collisions. Also: - CI: enable test bundles. - CI: build tests in more jobs. - lib2305: fix FILE handle leak. - unit1661: fix memleak found by torture test by releasing the `bufref` structure in `unit_stop()` that was allocated in `unit_setup()`. ``` test 1661...[bufref unit tests] Leak detected: memory still allocated: 13 bytes allocated by /home/runner/work/curl/curl/tests/unit/unit1661.c:70 1661: torture FAILED: function number 1 in test. ``` Ref: https://github.com/curl/curl/actions/runs/10967279334/job/30456745290?pr=14772#step:8:41 Similar test suite builds with autotools default and cmake+bundle+unity: - GHA/Linux: 33s vs 7s https://github.com/curl/curl/actions/runs/10705668823/job/29681617374 - GHA/macOS 34s vs 2s https://github.com/curl/curl/actions/runs/10705668813/job/29681632885 - GHA/FreeBSD: 15m25 vs 6m21 (full workflow time, ~qemu) https://github.com/curl/curl/actions/runs/10705668811/job/29681607915 - GHA/Cygwin: 9m52 vs 32s https://github.com/curl/curl/actions/runs/10705668809/job/29681609965 - GHA/MSYS2: 3m52 vs 14s https://github.com/curl/curl/actions/runs/10705668808/job/29681624295 - GHA/mingw-w64: 5m45 vs 30s https://github.com/curl/curl/actions/runs/10705668808/job/29681628787 Autotools test suite builds compared between master -> `--enable-test-bundles`: - GHA/Linux: 33s -> 9s (run tests: 22m23 -> 20m44) https://github.com/curl/curl/actions/runs/10710030193/job/29695932185 https://github.com/curl/curl/actions/runs/10967831456/job/30458220344 - GHA/macOS: 25s -> 4s (run tests: 2m58 -> 2m24) https://github.com/curl/curl/actions/runs/10710030195/job/29695938444 https://github.com/curl/curl/actions/runs/10967831452/job/30458225762 - GHA/non-native (FreeBSD): 4m8 -> 3m12 (full workflow time, ~qemu) https://github.com/curl/curl/actions/runs/10710030198/job/29695928401 https://github.com/curl/curl/actions/runs/10967831458/job/30458212692 - GHA/Cygwin: 9m25 -> 1m9 (run tests: 9m19 -> 3m28) https://github.com/curl/curl/actions/runs/10710030212/job/29695928213 https://github.com/curl/curl/actions/runs/10967831453/job/30458213268 - GHA/MSYS2: 3m54 -> 32s (run tests: 6m3 -> 3m59) https://github.com/curl/curl/actions/runs/10710030190/job/29704850591 https://github.com/curl/curl/actions/runs/10967831449/job/30459280005 - GHA/mingw-w64: 5m42 -> 1m5 (run tests: 7m41 -> 5m36) https://github.com/curl/curl/actions/runs/10710030190/job/29704852058 https://github.com/curl/curl/actions/runs/10967831449/job/30459280862 - Azure MSYS2 mingw64 openssl: 38m55 -> 11m58 https://dev.azure.com/daniel0244/curl/_build/results?buildId=25546&view=logs&j=b58b8c59-0f61-52e9-0f9e-fad562a1e77f&t=0f9230a7-3b10-53ca-9938-700ece377c5e https://dev.azure.com/daniel0244/curl/_build/results?buildId=25547&view=logs&jobId=39473db1-3945-55d5-deb5-c218fad88dce&j=b58b8c59-0f61-52e9-0f9e-fad562a1e77f&t=0f9230a7-3b10-53ca-9938-700ece377c5e - Azure Ubuntu default: 2m15 -> 55s (all build) https://dev.azure.com/daniel0244/curl/_build/results?buildId=25546&view=logs&j=9d58b9ac-e1e6-53b6-f83a-1f9f1d912522&t=a6b38d83-e7cf-5a9b-c762-a178412717b7 https://dev.azure.com/daniel0244/curl/_build/results?buildId=25547&view=logs&jobId=39473db1-3945-55d5-deb5-c218fad88dce&j=9d58b9ac-e1e6-53b6-f83a-1f9f1d912522&t=a6b38d83-e7cf-5a9b-c762-a178412717b7 Cmake test suite builds compared between master -> `-DCURL_TEST_BUNDLES=ON` + unity: - GHA/Linux: 29s -> 7s (run tests: 4m50 -> 4m57, 20m43 -> 20m45) https://github.com/curl/curl/actions/runs/10710030193/job/29695941814 https://github.com/curl/curl/actions/runs/10705668823/job/29681622201 - GHA/Linux old: 44s -> 13s (bundle+no unity) (run tests: 5m5 -> 5m6) https://github.com/curl/curl/actions/runs/10718264094/job/29719794727 https://github.com/curl/curl/actions/runs/10718653175/job/29721009613 - GHA/macOS: 32s -> 2s (run tests: 2m43 -> 2m40) https://github.com/curl/curl/actions/runs/10710030195/job/29695931956 https://github.com/curl/curl/actions/runs/10705668813/job/29681638937 - GHA/non-native (*BSD): inconclusive (full workflow time, ~qemu) https://github.com/curl/curl/actions/runs/10710030198 https://github.com/curl/curl/actions/runs/10705668811 - GHA/Cygwin: 3m9 -> 32s https://github.com/curl/curl/actions/runs/10710030212/job/29695929075 https://github.com/curl/curl/actions/runs/10705668809/job/29681609965 - GHA/MSYS2: 2m24 -> 14s https://github.com/curl/curl/actions/runs/10710030190/job/29704850996 https://github.com/curl/curl/actions/runs/10705668808/job/29681624295 - GHA/mingw-w64: 3m56 -> 30s (run tests: 4m2 -> 3m52) https://github.com/curl/curl/actions/runs/10710030190/job/29704852219 https://github.com/curl/curl/actions/runs/10705668808/job/29681631393 - GHA/mingw-w64-old: 7m19 -> 1m44 (run tests: 3m30 -> 2m53) https://github.com/curl/curl/actions/runs/10710030190/job/29704849763 https://github.com/curl/curl/actions/runs/10705668808/job/29681622329 - GHA/MSVC: 3m22 -> 13s (run tests: 9m43 -> 4m22) https://github.com/curl/curl/actions/runs/10710030190/job/29704850411 https://github.com/curl/curl/actions/runs/10705668808/job/29681623313 - AppVeyor CI MSVC 2008: 4m3 -> 45s (full build) - AppVeyor CI MSVC 2010: 2m56 -> 1m8 (full build) - AppVeyor CI MSVC 2022: 10m19 -> 2m23 (full build) https://ci.appveyor.com/project/curlorg/curl/builds/50538455 https://ci.appveyor.com/project/curlorg/curl/builds/50536558 - AppVeyor CI total build time: 10m30 (master) -> 6m48 (unity) -> 4m5 (bundle) -> 3m24 (bundle+unity) -> 5m7 (bundle+unity+all jobs building tests) Closes #14772
show more ...
|
#
60c3d044 |
| 06-Sep-2024 |
Viktor Szakats |
autotools: add support for 'unity' builds, enable in CI Implement the "unity" builds as known from CMake, but for autotools. It's limited to `lib` and `src` (CMake also supports it in `t
autotools: add support for 'unity' builds, enable in CI Implement the "unity" builds as known from CMake, but for autotools. It's limited to `lib` and `src` (CMake also supports it in `tests`). Enable with: `--enable-unity` (disabled by default) Unity builds speed up builds significantly. Cygwin and Windows builds in particular, but the effect is noticeable on most systems. It also allows discovering unity issues with autotools, benefitting also CMake when building the same combination. In CI it makes turnaround times quicker. This closes build performance with CMake. autotools still lags behind because it builds shared and static libcurl in two, separate passes. CMake does it in one. Manpage compilation isn't batched, it is in CMake. After unity and test bundle support the slowest parts of the build are the configuration phase (which is effectively a tedious, non-parallel, compilation and/or linking of 300+ tiny programs. The next bottleneck is compiling individual examples and finally test servers (only slow with autotools). The autotools implementation is slightly less efficient than CMake, because 3 sources are permanently excluded while in CMake this isn't necessary and solved more efficiently while building libtests. There is also no 'unity' support for tests, making them a less efficient also. Enable it in CI for most `configure` jobs. Except in GHA/dist (though it works fine there too), to use the default config there. Also skip for the Linux AWC-LC job where it made builds time a few seconds longer (reason undiscovered.) Autotools test suite builds compared between master -> `--enable-unity`: - GHA/Linux: 32s -> 12s https://github.com/curl/curl/actions/runs/10705668823/job/29681617374 https://github.com/curl/curl/actions/runs/10742978889/job/29796766297 - GHA/macOS: 37s -> 10s https://github.com/curl/curl/actions/runs/10705668813/job/29681632885 https://github.com/curl/curl/actions/runs/10742978699/job/29796768875 - GHA/FreeBSD: 15m25 -> 10m58 (full workflow time, ~qemu) https://github.com/curl/curl/actions/runs/10705668811/job/29681607915 https://github.com/curl/curl/actions/runs/10742978937/job/29796766115 - GHA/Cygwin: 3m32 -> 1m21 https://github.com/curl/curl/actions/runs/10705668809/job/29681609965 https://github.com/curl/curl/actions/runs/10742978645/job/29796756933 - GHA/MSYS2: 2m42 -> 50s https://github.com/curl/curl/actions/runs/10705668808/job/29681621166 https://github.com/curl/curl/actions/runs/10742978662/job/29799739289 - GHA/mingw-w64: 5m32 -> 1m23 https://github.com/curl/curl/actions/runs/10705668808/job/29681628787 https://github.com/curl/curl/actions/runs/10742978662/job/29799741568 Closes #14815
show more ...
|
#
45202cbb |
| 14-Sep-2024 |
Viktor Szakats |
cmake: separate target for examples, optimize CI, fix fallouts - Move `docs/examples` builds under a separate target. - Make `BUILD_EXAMPLES` default to `ON`. It means to generate t
cmake: separate target for examples, optimize CI, fix fallouts - Move `docs/examples` builds under a separate target. - Make `BUILD_EXAMPLES` default to `ON`. It means to generate the rules for `docs/examples` by default, but not build them. To build them, an explicit `make curl-examples` (or ninja, etc) command is necessary. This syncs behaviour with autotools, and also how both cmake and autotools are building tests. - GHA: update cmake jobs to use the new way of building examples. - GHA: move examples build step at the end of the job, after building and running tests. This allows to have build and test run results faster, and leave the seldom-changing examples build to the end. Building examples is the slowest build step with no practical way to make them fast. - appveyor: enable building examples in two old-MSVC jobs. - examples: fix examples to build cleanly with old MSVC versions. - GHA/non-native: move example build log under a GHA foldable section. - GHA/windows: move building examples into separate step for Linux cross jobs. Follow-up to dfdd978f7c60224dffe2aac25b436dc0a5cd0186 #13491 Closes #14906
show more ...
|
#
bc6f719d |
| 19-Sep-2024 |
Tal Regev |
GHA/windows: add MSVC vcpkg MSH3 job Refs: #14927 #14932 #14971 Closes #14922
|
#
210cf7cd |
| 17-Sep-2024 |
Viktor Szakats |
GHA/windows: revert enabling SSPI option Because it reduces test coverage significantly: ``` TESTINFO: "curl has SSPI support" 109 times (64, 65, 67, 68, 69, 70, 72, 81, 88 and 100 m
GHA/windows: revert enabling SSPI option Because it reduces test coverage significantly: ``` TESTINFO: "curl has SSPI support" 109 times (64, 65, 67, 68, 69, 70, 72, 81, 88 and 100 more) ``` Follow-up to e53523fef07894991c69d907a7c7794c7ada4ff4 #14859 Closes #14947
show more ...
|
#
41290d43 |
| 16-Sep-2024 |
Viktor Szakats |
GHA/windows: fix bad typo in MSVC GnuTLS stunnel condition Regression from e53523fef07894991c69d907a7c7794c7ada4ff4 #14859
|
#
8a7efdb8 |
| 16-Sep-2024 |
Viktor Szakats |
GHA: misc updates: impacket, timeouts, mingw-w64 32-bit - NetBSD: enable impacket. Debatable if this hefty package is worth it for the single SMB test (1451) run curl uses it for.
GHA: misc updates: impacket, timeouts, mingw-w64 32-bit - NetBSD: enable impacket. Debatable if this hefty package is worth it for the single SMB test (1451) run curl uses it for. (on the upside, it seems to install instantly on NetBSD) It's also a versioned package name that requires active maintenance. The unversioned name doesn't work, though that's what the package search returns: https://pkgsrc.se/net/py-impacket - FreeBSD: stop installing impacket deps explicitly. They are automatically installed via the impacket package. - Linux: put time limit on test runs. Started hanging yesterday: linux: https://github.com/curl/curl/actions/runs/10875011573/job/30172946986#step:41:3731 awslc: https://github.com/curl/curl/actions/runs/10879782864/job/30185188509 wolfssl: https://github.com/curl/curl/actions/runs/10879782864/job/30185188509 - distcheck: reduce time limit to 15m (was 30m) Linux tests started to hang, so reduce the timeout from 30 minutes to 15. These jobs normally take 3 to 6 minutes to finish. https://github.com/curl/curl/actions/runs/10879479914 - Windows: add 32-bit MSYS2/mingw-w64 job. Follow-up to e53523fef07894991c69d907a7c7794c7ada4ff4 #14859 Closes #14929
show more ...
|
#
e53523fe |
| 11-Sep-2024 |
Viktor Szakats |
CI: move Azure jobs to GHA, fix fallouts, sshserver, runtests tweaks CI: - GHA/windows: enable OpenSSH server, SysInternals `handle`, `impacket`. Skip `impacket` on MSYS2 due
CI: move Azure jobs to GHA, fix fallouts, sshserver, runtests tweaks CI: - GHA/windows: enable OpenSSH server, SysInternals `handle`, `impacket`. Skip `impacket` on MSYS2 due to install failure. Skip OpenSSH server for old/standalone mingw-w64 (building curl without SSH there.) - GHA/windows: make test tool installs a separate step. - GHA/cygwin: enable OpenSSH server. Skip `impacket`: it's compiling for 7 minutes then breaks. Skip `stunnel` due to sluggish test run performance. (This update is unrelated to Azure jobs.) - GHA/linux: migrate Linux jobs from Azure CI. - GHA/linux: migrate scanbuild job from Azure CI. - GHA/linux: enable libssh2 in a job. Also enable valgrind. - CI/windows: enable SSPI in two jobs. - CI/windows: disable zlib in one more job. - CI/windows: improve `if` condition checking GnuTLS. - CI/windows: ignore SFTP/SCP tests as necessary. - universally ignore SCP tests, they fail everywhere. - ignore test 612. - ignore test 613 616 618 with MSYS2 mingw-w64. - ignore test 614 with libssh. - ignore all SFTP with MSYS2 native. - ignore all SFTP with vcpkg with `libssh2[core,zlib]`. - ignore a couple of SFTP tests with MSYS2 mingw-w64. (This matches settings on Azure CI.) - GHA/windows: ignore failing 1451 'Basic SMB request' test for old mingw-w64 7.3.0 (but not for 9.5.0!): ``` 2024-09-11 21:45:59,738 ERROR smbComNegotiate: b'NT LM 0.12\x00' is not in list [...] curl: (7) Could not connect to server [...] FAIL 1451: 'Basic SMB request' SMB ``` Ref: https://github.com/curl/curl/actions/runs/10816280746/job/30007130770#step:13:3546 - CI/Azure: delete, now moved to GHA. sshserver: - sshserver: fix permissions for SSH host key on Windows, allowing sshd to launch. - sshserver: fix initializing config paths with Cygwin/MSYS2 sshd. - sshserver: fix initializing config paths in parallel builds. - sshserver: delete redundant `DenyUsers`. This also opens the way to allow multiple usernames. - sshserver: fix `AllowUsers` for GHA/windows, by allowing the domainless username again. Follow-up to 3ee7c676ec8ef32e3a9cb4d0fb2929a8335d58db #5721 - sshserver: fix `Deprecated option` warnings in `sshd_config`: ``` D:/a/curl/curl/bld/tests/log/2/server/curl_sshd_config line 7: Deprecated option AuthorizedKeysFile2 D:/a/curl/curl/bld/tests/log/2/server/curl_sshd_config line 25: Deprecated option KeyRegenerationInterval D:/a/curl/curl/bld/tests/log/2/server/curl_sshd_config line 35: Deprecated option RhostsRSAAuthentication D:/a/curl/curl/bld/tests/log/2/server/curl_sshd_config line 36: Deprecated option RSAAuthentication D:/a/curl/curl/bld/tests/log/2/server/curl_sshd_config line 37: Deprecated option ServerKeyBits D:/a/curl/curl/bld/tests/log/2/server/curl_sshd_config line 41: Deprecated option UseLogin ``` - sshserver: fix `Deprecated option` warnings in `ssh_config` with Cygwin/MSYS2. - sshserver: fix dumping config files due to the filenames missing their full paths. - sshserver: add workaround to make `logmsg` messages visible. Before this patch they only went to a file and never shown. runtests: - runtests: log details when these Windows commands are called: `handle`, `taskkill`, `tasklist`. - runtests: add documentation links to Windows tools: `handle`, `taskkill`, `tasklist`, `icacls`. - runtests: add `-t` (kill whole tree) option to `taskkill` in `servers.pm`, syncing it with the other `taskkill` call. Follow-up to bc72a78a11764558639131d51fa8e7c81ee1e113 #14488 - runtests: show warning if Sysinternals `handle` tool is missing. - runtests: drop Windows XP Home compatibility `tskill` call. The call was made on all Windows versions. It's possibly overkill to do this, because XP Home is probably rarely used for running curl tests these days. In case it's needed, it'd be better to put it under an explicit option. - runtests: show Perl version and path. Fix/silence fallouts: - unit2603: fix building with disabled HTTP support. - unit2604: silence `-Woverlength-strings` warnings in C89 mode. - test437, test1614: fix to pass with no-IPv6 builds. Closes #14859
show more ...
|
#
5f93cad0 |
| 15-Sep-2024 |
Viktor Szakats |
GHA: replace make with ninja in Cygwin, MSYS2 and mingw-w64 cmake jobs Speed-ups: - cygwin build: 47s -> 29s - cygwin build tests: 3m12 -> 2m32 - MSYS2 native build: 29s -> 16s
GHA: replace make with ninja in Cygwin, MSYS2 and mingw-w64 cmake jobs Speed-ups: - cygwin build: 47s -> 29s - cygwin build tests: 3m12 -> 2m32 - MSYS2 native build: 29s -> 16s - MSYS2 native build tests: 2m24 -> 1m52 - MSYS2/mingw-w64: already had ninja installed and used implicitly. - linux-mingw-w64-cross: 31s -> 25s before: cygwin: https://github.com/curl/curl/actions/runs/10866939355/job/30155134299 windows: https://github.com/curl/curl/actions/runs/10866939361 after: cygwin: https://github.com/curl/curl/actions/runs/10867861215/job/30157121784 windows: https://github.com/curl/curl/actions/runs/10867861208?pr=14914 Closes #14914
show more ...
|
#
65168b8e |
| 11-Sep-2024 |
Tal Regev |
GHA/windows: use libuv for event-based tests on openssl job Use libuv for event-based tests on openssl job. Closes #14868
|
#
09b21e47 |
| 29-Aug-2024 |
Tal Regev |
GHA/windows: re-add GnuTLS after upstream fix Re-add GnuTLS. The fix was in this PR: https://github.com/microsoft/vcpkg/pull/40739 Follow-up to a5682d9cb9da3212775bb227488a343d3
GHA/windows: re-add GnuTLS after upstream fix Re-add GnuTLS. The fix was in this PR: https://github.com/microsoft/vcpkg/pull/40739 Follow-up to a5682d9cb9da3212775bb227488a343d32552fd6 #14710 Closes #14864
show more ...
|
#
813995bb |
| 10-Sep-2024 |
Viktor Szakats |
GHA/windows: raise test run timeouts Give more time for recently enabled TLS tests to complete. Follow-up to bc72a78a11764558639131d51fa8e7c81ee1e113 #14488 Ref: #14849 Clos
GHA/windows: raise test run timeouts Give more time for recently enabled TLS tests to complete. Follow-up to bc72a78a11764558639131d51fa8e7c81ee1e113 #14488 Ref: #14849 Closes #14851
show more ...
|
#
ad32fb42 |
| 31-Aug-2024 |
Viktor Szakats |
autotools: settle with option name: `--enable-windows-unicode` Bring the option name style in sync with cmake and with other configure options aiming to enable something unrelated to an
autotools: settle with option name: `--enable-windows-unicode` Bring the option name style in sync with cmake and with other configure options aiming to enable something unrelated to an optional package. (I initially named this new option `--with-windows-unicode` within this release cycle.) Follow-up to 9e4a2187e763dd80a1296b07fd3e073f46c4dc8f #14478 Closes #14746
show more ...
|
#
a5682d9c |
| 28-Aug-2024 |
Viktor Szakats |
GHA/windows: vcpkg GnuTLS started breaking CI, temp drop it Starting today vcpkg wants to rebuild GnuTLS but fails: ``` error: building shiftmedia-libgnutls:x64-windows failed with:
GHA/windows: vcpkg GnuTLS started breaking CI, temp drop it Starting today vcpkg wants to rebuild GnuTLS but fails: ``` error: building shiftmedia-libgnutls:x64-windows failed with: BUILD_FAILED ``` Ref: https://github.com/curl/curl/actions/runs/10594890318/job/29359499149#step:5:144 Temporary solution: - drop it from the MultiSSL job. - replace with mbedTLS job. This job still tests libssh and I could not find a better place for it right away. GnuTLS to be restored once it builds again. Possibly when this hash reaches the GHA `windows-latest` runner: https://github.com/microsoft/vcpkg/commit/f5ec6f30ff70f04f841436a0f36600bdbabfcfbf Also: - switch to Debug for the mbedTLS job. Should also work now with GnuTLS, once it's back: Ref: https://github.com/microsoft/vcpkg/pull/40473 Closes #14710
show more ...
|
#
d620ec67 |
| 27-Aug-2024 |
Viktor Szakats |
CI: add test timeouts, more cmake build tests, fix VS2010 C warning - GHA/macos: set timeout for test runs. Double the value for autotools to fit torture tests. - GHA/cygwin: reduc
CI: add test timeouts, more cmake build tests, fix VS2010 C warning - GHA/macos: set timeout for test runs. Double the value for autotools to fit torture tests. - GHA/cygwin: reduce test run timeout for autotools. - GHA/cygwin: enable building tests with cmake. - GHA/windows: enable building tests with MSYS cmake. - GHA/windows: enable building tests with MSVC UWP. - appveyor: enable building tests with VS2008 x86 and VS2010 x64. - tests: add workaround compiler warnings when building with VS2010: ``` tests\server\util.c(482): warning C4306: 'type cast' : conversion from 'int' to 'void (__cdecl *)(int)' of greater size tests\server\util.c(486): warning C4306: 'type cast' : conversion from 'int' to 'void (__cdecl *)(int)' of greater size tests\server\util.c(490): warning C4306: 'type cast' : conversion from 'int' to 'void (__cdecl *)(int)' of greater size tests\server\util.c(720): warning C4306: 'type cast' : conversion from 'int' to 'void (__cdecl *)(int)' of greater size tests\server\util.c(726): warning C4306: 'type cast' : conversion from 'int' to 'void (__cdecl *)(int)' of greater size tests\server\util.c(732): warning C4306: 'type cast' : conversion from 'int' to 'void (__cdecl *)(int)' of greater size tests\server\util.c(781): warning C4306: 'type cast' : conversion from 'int' to 'void (__cdecl *)(int)' of greater size tests\server\util.c(785): warning C4306: 'type cast' : conversion from 'int' to 'void (__cdecl *)(int)' of greater size tests\server\util.c(789): warning C4306: 'type cast' : conversion from 'int' to 'void (__cdecl *)(int)' of greater size ``` Ref: https://ci.appveyor.com/project/curlorg/curl/builds/50485633/job/4ujlwxod3cexmn2q#L1535 With this, tests are built in all GHA cygwin/windows jobs. Timeouts avoid long runs with runaway issues, example: https://github.com/curl/curl/actions/runs/10575522173 Closes #14700
show more ...
|
#
2625360b |
| 25-Aug-2024 |
Viktor Szakats |
configure: fix WinIDN builds targeting old Windows 1. GHA/windows: enable WinIDN in Linux cross-builds. (to reveal the issue in CI.) 2. fix compiler warning when building wit
configure: fix WinIDN builds targeting old Windows 1. GHA/windows: enable WinIDN in Linux cross-builds. (to reveal the issue in CI.) 2. fix compiler warning when building with mingw-w64 supporting WinIDN, while targeting pre-Vista Windows, with a `WINVER` set to target Vista or newer. (Such was Ubuntu's mingw-w64 with the classic-mingw-specific trick in point 3 of this PR.) ``` ../../lib/idn.c:154:23: error: redundant redeclaration of ‘IdnToAscii’ [-Werror=redundant-decls] 154 | WINBASEAPI int WINAPI IdnToAscii(DWORD dwFlags, | ^~~~~~~~~~ In file included from /usr/share/mingw-w64/include/windows.h:73, from /usr/share/mingw-w64/include/winsock2.h:23, from ../../lib/setup-win32.h:91, from ../../lib/curl_setup.h:308, from ../../lib/idn.c:29: /usr/share/mingw-w64/include/winnls.h:1075:30: note: previous declaration of ‘IdnToAscii’ was here 1075 | WINNORMALIZEAPI int WINAPI IdnToAscii (DWORD dwFlags, LPCWSTR lpUnicodeCharStr, int cchUnicodeChar, LPWSTR lpASCIICharStr, int cchASCIIChar); | ^~~~~~~~~~ [...same for IdnToUnicode...] ``` Ref: https://github.com/curl/curl/actions/runs/10542832783/job/29210098553#step:7:89 3. drop `WINVER` override for classic-mingw. curl no longer supports building with classic-mingw. Reverts 37f1c21cb9c809ec870803fc40e1ed2afd9534ac #7581 4. sync `if IdnToUnicode can be linked` detection snippet with the live code in `lib/idn.c`. It fixes detection for the scenario in point 2. 5. delete unused `WINIDN_DIR` variable. Bug: https://github.com/curl/curl/pull/12606#issuecomment-1885381038 Previous abandoned attempt: #12684 Reviewed-by: Jay Satiro Closes #14680
show more ...
|
#
bc72a78a |
| 11-Aug-2024 |
Aki <75532970+AkiSakurai@users.noreply.github.com> |
GHA/windows: enable HTTPS tests with stunnel - install stunnel Closes #14488
|
#
8aadb830 |
| 23-Aug-2024 |
Viktor Szakats |
GHA/windows: add Linux -> mingw-w64 cross-build (cmake, autotools) Also: - add a line to CMake log output showing the host and target OS and CPU when doing cross-builds. - redu
GHA/windows: add Linux -> mingw-w64 cross-build (cmake, autotools) Also: - add a line to CMake log output showing the host and target OS and CPU when doing cross-builds. - reduce excessive timeout for `curl -V` steps. Closes #14661
show more ...
|
#
f73f6bf9 |
| 22-Aug-2024 |
Viktor Szakats |
GHA: add yamlcheck Uses `yamllint`. Also: - fix warning for existing YAML files: ``` [truthy] truthy value should be one of [false, true] ``` Closes #
GHA: add yamlcheck Uses `yamllint`. Also: - fix warning for existing YAML files: ``` [truthy] truthy value should be one of [false, true] ``` Closes #14650
show more ...
|
#
9fff0742 |
| 21-Aug-2024 |
Viktor Szakats |
GHA/windows: fix indentation in the MSVC section
|