Revert "Fix bug #69280: SoapClient classmap doesn't support fully qualified class name (#14398)"

This reverts commit 476706165a227ea6b1d73299b9b6486a6ca073a9.

Although the fix is co

Revert "Fix bug #69280: SoapClient classmap doesn't support fully qualified class name (#14398)"

This reverts commit 476706165a227ea6b1d73299b9b6486a6ca073a9.

Although the fix is correct, people are relying on the bug and their
code stopped working, see GH-15252.

show more ...

Fix SoapFault property destruction

Two issues:
1) We should not modify the object when we pass invalid values
2) We should reset the properties to their default value otherwise we

Fix SoapFault property destruction

Two issues:
1) We should not modify the object when we pass invalid values
2) We should reset the properties to their default value otherwise we
get a UAF.

Regressed in df219ccf9d6be8302eef3ab6e26fd00fbd2fef71

Closes GH-15248.

show more ...

ext/soap: Fix memory leaks when calling SoapFault::__construct() twice

Fix bug #69280: SoapClient classmap doesn't support fully qualified class name (#14398)

There's a hash table that maps type names to class name, but names with
a leading backslash are no

Fix bug #69280: SoapClient classmap doesn't support fully qualified class name (#14398)

There's a hash table that maps type names to class name, but names with
a leading backslash are not supported. The engine has logic to strip
away the leading backslash that we should replicate here.

It works by checking if we need to make an actual copy in case an
unexpected (e.g. invalid data or leading backslash) situations are
detected. Upon making a copy we normalize the data in the table.

Furthermore, previously the code assumed that the key was always valid
and that the structure was a non-packed hash table. This isn't
necessarily the case. The new code fixes this as well.

Closes GH-14398.

show more ...

Fix memory leaks with string function name lookups

There's a few leaks where the string is copied for lowercasing but not released.
Where possible, use the _lc functionality of zend_hash

Fix memory leaks with string function name lookups

There's a few leaks where the string is copied for lowercasing but not released.
Where possible, use the _lc functionality of zend_hash to do the lookup
to avoid the leaks that currently exist with the manual lowercasing.

Closes GH-14390.

show more ...

Fix reading zlib ini settings in ext-soap

zend_ini_long() actually expects the length without the NUL byte, but
we're passing the length *with* the NUL byte. This mess can actually be

Fix reading zlib ini settings in ext-soap

zend_ini_long() actually expects the length without the NUL byte, but
we're passing the length *with* the NUL byte. This mess can actually be
avoided altogether by using INI_INT, so use that instead.

Closes GH-14382.

show more ...

Fix memory leak if calling SoapServer::setClass() twice

Closes GH-14381.

Fix memory leak if calling SoapServer::setObject() twice

Closes GH-14380.

Fix missing error restore code in ext-soap (#14379)

The begin and end macros should be paired, but some of the end macro
calls were missing.

More usage of known zend_str instead of C string (#11381)

Use new ZSTR_INIT_LITERAL macro (#10879)

Fix GH-8329 Print true/false instead of bool in error and debug messages (#8385)

Fix GH-9720: Null pointer dereference while serializing the response

When traversing the result array, we need to cater to `param_name`
possibly being `NULL`. Prior to PHP 7.0.0, this w

Fix GH-9720: Null pointer dereference while serializing the response

When traversing the result array, we need to cater to `param_name`
possibly being `NULL`. Prior to PHP 7.0.0, this was implicitly done
because `param_name` was of type `char*`.

Closes GH-9739.

show more ...

Revert "Port all internally used classes to use default_object_handlers"

This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a.

The commit was a bit too late to be included i

Revert "Port all internally used classes to use default_object_handlers"

This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a.

The commit was a bit too late to be included in PHP 8.2 RC1. Given it's a massive ABI break, we decide to postpone the change to PHP 8.3.

show more ...

Port all internally used classes to use default_object_handlers

Signed-off-by: Bob Weinand <bobwei9@hotmail.com>

Declare ext/soap constants in stubs (#9124)

Fix GH-8578: Error on wrong parameter on SoapHeader constructor

Closes GH-8579.

Use custom object instead of resource for soap server service

The "service" resource is a purely internal structure used by
SoapServer, which userland code cannot interact with. Instead

Use custom object instead of resource for soap server service

The "service" resource is a purely internal structure used by
SoapServer, which userland code cannot interact with. Instead of
storing it as a resource in an object propperty, use a custom
object structure instead.

show more ...

Use more compact representation for packed arrays.

- for packed arrays we store just an array of zvals without keys.
- the elements of packed array are accessible throuf as ht->arPacked[

Use more compact representation for packed arrays.

- for packed arrays we store just an array of zvals without keys.
- the elements of packed array are accessible throuf as ht->arPacked[i]
instead of ht->arData[i]
- in addition to general ZEND_HASH_FOREACH_* macros, we introduced similar
familied for packed (ZEND_HASH_PACKED_FORECH_*) and real hashes
(ZEND_HASH_MAP_FOREACH_*)
- introduced an additional family of macros to access elements of array
(packed or real hashes) ZEND_ARRAY_ELEMET_SIZE, ZEND_ARRAY_ELEMET_EX,
ZEND_ARRAY_ELEMET, ZEND_ARRAY_NEXT_ELEMENT, ZEND_ARRAY_PREV_ELEMENT
- zend_hash_minmax() prototype was changed to compare only values

Because of smaller data set, this patch may show performance improvement
on some apps and benchmarks that use packed arrays. (~1% on PHP-Parser)

TODO:
- sapi/phpdbg needs special support for packed arrays (WATCH_ON_BUCKET).
- zend_hash_sort_ex() may require converting packed arrays to hash.

show more ...

Use ASCII lower case for misc case folding

Use ASCII case conversion instead of locale-dependent case conversion in
the following places:

* grapheme_stripos() and grapheme_strri

Use ASCII lower case for misc case folding

Use ASCII case conversion instead of locale-dependent case conversion in
the following places:

* grapheme_stripos() and grapheme_strripos() in the "fast" path
* ldap_get_entries()
* oci_pconnect() for case folding of parameters when constructing a key
into the connection or session pool
* SoapClient: case folding of function names
* get_meta_tags(): case conversion of property names
* http stream wrapper: header names
* phpinfo(): anchor names
* php_verror(): docref URLs
* rfc1867.c: Content-Type boundary parameter name
* streams.c: stream protocol names

Using locale-dependent case folding for these cases is either
unnecessary or actively incorrect. These functions could have
misbehaved when used with certain locales (e.g. Turkish).

Closes GH-7511.

show more ...

Slightly clean up cookies handling

Make the property always an array with an empty array default.
Properly separate the array on modification to compensate.

Move derefs into accessor macros

These derefs are mostly there to be defensive, but clutter the
code somewhat. Move them directly into the access macros.

Declare remaining SoapClient properties

Remove dead code

This was checking for the headerfault property, but not actually
doing anything with it.

Use separate property to request digit auth

Currently, _digest is used both to request that digest auth be
used (_digest == null) and to later store the _digest parameters.

This

Use separate property to request digit auth

Currently, _digest is used both to request that digest auth be
used (_digest == null) and to later store the _digest parameters.

This relies on the ability to distinguish between _digest being
null and it being not set, which is not present with declared
properties. (Well, technically it is, we could just leave it
uninitialized, but that would be non-idiomatic.)

Resolve this by splitting into separate _use_digest and _digest
properties.

show more ...