Fix GH-16360 mb_substr overflow on start and length arguments.

occurs when they are negated to start working from the end instead
when set with ZEND_LONG_MIN.

Use "must not" instead of "cannot" wording

ext/mbstring: Use standard wording for ValueError

Clean-up unused headers (#14365)

* ext/mbstring.c: clean-up headers and include intrinsics

ext/standard: Refactor exec.c public APIs to use zend_string pointers (#14353)

* Pull zend_string* from INI directive

* Ensure that mail.force_extra_parameters INI directive does no

ext/standard: Refactor exec.c public APIs to use zend_string pointers (#14353)

* Pull zend_string* from INI directive

* Ensure that mail.force_extra_parameters INI directive does not have any nul bytes

* ext/standard: Make php_escape_shell_cmd() take a zend_string* instead of char*

This saves on an expensive strlen() computation

* Convert E_ERROR to ValueError in php_escape_shell_cmd()

* ext/standard: Make php_escape_shell_arg() take a zend_string* instead of char*

This saves on an expensive strlen() computation

* Convert E_ERROR to ValueError in php_escape_shell_arg()

show more ...

ext/mbstring: Check encoding passed to mb_http_output() has no null bytes

ext/mbstring: Always pass length to php_mb_get_encoding_or_pass()

We have access to this information, so propagate it instead of calling strlen().
This also removes the newly introduced

ext/mbstring: Always pass length to php_mb_get_encoding_or_pass()

We have access to this information, so propagate it instead of calling strlen().
This also removes the newly introduced _ex() variant.

show more ...

ext/mbstring: Pass string length to _php_mb_ini_mbstring_http_output_set()

Fix GH-13815: mb_trim() inaccurate $characters default value (#13820)

Because the default characters are defined in the stub file, and the
stub file is UTF-8 (typically), the characters

Fix GH-13815: mb_trim() inaccurate $characters default value (#13820)

Because the default characters are defined in the stub file, and the
stub file is UTF-8 (typically), the characters are encoded in the string
as UTF-8. When using a different character encoding, there is a mismatch
between what mb_trim expects and the UTF-8 encoded string it gets.

One way of solving this is by making the characters argument nullable,
which would mean that it always uses the internal code path that has the
unicode codepoints that are defaulted actually stored as codepoint
numbers instead of in a string.

Co-authored-by: @ranvis

show more ...

[RFC] Add mb_ucfirst and mb_lcfirst functions (#13161)

Fix build warning in ext/mbstring

Use a single version of mempcpy(3) (#12257)

While __php_mempcpy is only used by ext/standard/crypt_sha*, the
mempcpy "pattern" is used everywhere.

This commit removes __php_memp

Use a single version of mempcpy(3) (#12257)

While __php_mempcpy is only used by ext/standard/crypt_sha*, the
mempcpy "pattern" is used everywhere.

This commit removes __php_mempcpy, adds zend_mempcpy and transforms
open-coded parts into function calls.

show more ...

Add specialized implementation of mb_strcut for GB18030

For GB18030, it is not generally possible to identify character
boundaries without scanning through the entire string. Therefore,

Add specialized implementation of mb_strcut for GB18030

For GB18030, it is not generally possible to identify character
boundaries without scanning through the entire string. Therefore,
implement mb_strcut using a similar strategy as the mblen_table based
implementation in mbstring.c. The difference is that for GB18030, we
need to look at two leading bytes to determine the byte length of a
multi-byte character.

The new implementation is 4-5x faster for short strings, and more than
10x faster for long strings. (Part of the reason why this new code has
such a great performance advantage is because it is replacing code
based on the older text conversion filters provided by libmbfl, which
were quite slow.)

The behavior is the same as before for valid GB18030 strings; for
some invalid strings, mb_strcut will choose different 'cut' points
as compared to before. (Clang's libFuzzer was used to compare the
old and new implementations, searching for test cases where they had
different behavior; no such cases were found.)

show more ...

ext/mbstring: Refactor mb_get_info()

ext/mbstring: Refactor mb_trim_width() to take size_t arguments

ext/mbstring: Always throw ValueErrors for invalid mb_http_input() type

ext/mbstring: Check conversion map only has integers

ext/mbstring: pass true conversion map size around

Return early from mb_get_substr if 'len' parameter is zero

This internal function is used to implement mb_strstr, mb_stristr,
mb_strrchr, mb_strrichr, mb_substr, mb_strimwidth, mb_trim,

Return early from mb_get_substr if 'len' parameter is zero

This internal function is used to implement mb_strstr, mb_stristr,
mb_strrchr, mb_strrichr, mb_substr, mb_strimwidth, mb_trim, and
mb_str_pad. All of these functions will be faster if we return
early when requested for a zero-length "substring".

show more ...

Return early from mb_strcut if 'len' parameter is zero

Use ZSTR_IS_VALID_UTF8 macro where possible (#12869)

ext/mbstring: use unsigned char for variable with max value of 255

ext/mbstring: Move variable declaration to inner scope

ext/mbstring: Use bool where more appropriate instead of int

ext/mbstring: Use unsigned int where more appropriate instead of int