ext/imap: Refactor common conditional property assignment

By introducing new functions and doing some preprocessor black magic

ext/imap: Refactor imap_fetch_overview()

Reduce level of indentations by using early guards to return/continue

ext/imap: Add const qualifier for header_injection()

Also reformat long if condition to make it clearer

ext/imap: Do not condition on number of arguments but on pointer being set or not

ext/imap: Cleanup custom implementation of rfc822_write_address()

This is used only when c-client does not have this feature, maybe this is something we should asume nowadays?

ext/imap: Use propery API instead of php_imap_hash_add_object()

It was only ever used to update an object property table and never an associative array.

ext/imap: Remove php_imap_list_add_object() function

The symtable was always an array so use appropriate HashTable API

ext/imap: Refactor + Update to modern property write API (#11415)

Use common functions for creating and setting up similar objects

The increase in verbosity compared to the ``add_pr

ext/imap: Refactor + Update to modern property write API (#11415)

Use common functions for creating and setting up similar objects

The increase in verbosity compared to the ``add_property_*()`` version is somewhat unfortunate, but the behaviour of ``add_property_str()`` releasing the zend_string is suboptimal, confusing, and has me concerned.

show more ...

Use new ZSTR_INIT_LITERAL macro (#10879)

Switch to Ubuntu 22.04 for GitHub actions jobs

Closes GH-10814

Fix GH-8329 Print true/false instead of bool in error and debug messages (#8385)

Add a new imap_is_open() function to check that a connection object is still valid

Drop superfluous check for imap_stream

`GET_IMAP_STREAM` already checks whether `.imap_stream` is `NULL`, and
bails out in that case.

Closes GH-10053.

Fix GH-9309: Segfault when connection is used after imap_close()

We actually need to check whether `php_imap_object.imap_stream` is
`NULL` to detect that the connection has already been

Fix GH-9309: Segfault when connection is used after imap_close()

We actually need to check whether `php_imap_object.imap_stream` is
`NULL` to detect that the connection has already been closed.

Closes GH-9313.

show more ...

Mark parameter in ext/imap as sensitive

Declare ext/imap constants in stubs (#8715)

Use more compact representation for packed arrays.

- for packed arrays we store just an array of zvals without keys.
- the elements of packed array are accessible throuf as ht->arPacked[

Use more compact representation for packed arrays.

- for packed arrays we store just an array of zvals without keys.
- the elements of packed array are accessible throuf as ht->arPacked[i]
instead of ht->arData[i]
- in addition to general ZEND_HASH_FOREACH_* macros, we introduced similar
familied for packed (ZEND_HASH_PACKED_FORECH_*) and real hashes
(ZEND_HASH_MAP_FOREACH_*)
- introduced an additional family of macros to access elements of array
(packed or real hashes) ZEND_ARRAY_ELEMET_SIZE, ZEND_ARRAY_ELEMET_EX,
ZEND_ARRAY_ELEMET, ZEND_ARRAY_NEXT_ELEMENT, ZEND_ARRAY_PREV_ELEMENT
- zend_hash_minmax() prototype was changed to compare only values

Because of smaller data set, this patch may show performance improvement
on some apps and benchmarks that use packed arrays. (~1% on PHP-Parser)

TODO:
- sapi/phpdbg needs special support for packed arrays (WATCH_ON_BUCKET).
- zend_hash_sort_ex() may require converting packed arrays to hash.

show more ...

Fix maybe-uninitialized warning

Some GCC versions don't like zend_try in loop. Avoid the issue
by pulling it out of the loop, we don't particularly care about
skipping further warnin

Fix maybe-uninitialized warning

Some GCC versions don't like zend_try in loop. Avoid the issue
by pulling it out of the loop, we don't particularly care about
skipping further warnings if a bailout occurs, just that it
does not interrupt shutdown.

Closes GH-7380.

show more ...

Prevent bailout during imap shutdown error reporting

This is a non-intrusive, minimal fix for bug #81316, which prevents
a bailout during imap RSHUTDOWN and prevents the basic shutdown

Prevent bailout during imap shutdown error reporting

This is a non-intrusive, minimal fix for bug #81316, which prevents
a bailout during imap RSHUTDOWN and prevents the basic shutdown
handler from being skipped.

I wasn't able to make the issue reproduce in a small test.

show more ...

Fix typos (#7327)

Not serializable flag permeation

Deprecate imap NIL constant

Part of https://wiki.php.net/rfc/deprecations_php_8_1.

Convert some recently introduced zend_bool to bool

As well as `scripts/dev/check_parameters.php` utility.

Cfr. 3e01f5afb1b52fe26a956190296de0192eedeec1

Use free_obj in IMAP\Connection

Looks like this incorrect pattern was copied from the FTP
implementation.

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...