AVIF support for getimagesize() and imagecreatefromstring()

Thanks to Joe Drago for help with the AVIF detection code.

Co-authored-by: Nikita Popov <nikita.ppv@googlemail.com>
C

AVIF support for getimagesize() and imagecreatefromstring()

Thanks to Joe Drago for help with the AVIF detection code.

Co-authored-by: Nikita Popov <nikita.ppv@googlemail.com>
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>

Closes GH-7091.

show more ...

Deprecate passing null to non-nullable arg of internal function

This deprecates passing null to non-nullable scale arguments of
internal functions, with the eventual goal of making the b

Deprecate passing null to non-nullable arg of internal function

This deprecates passing null to non-nullable scale arguments of
internal functions, with the eventual goal of making the behavior
consistent with userland functions, where null is never accepted
for non-nullable arguments.

This change is expected to cause quite a lot of fallout. In most
cases, calling code should be adjusted to avoid passing null. In
some cases, PHP should be adjusted to make some function arguments
nullable. I have already fixed a number of functions before landing
this, but feel free to file a bug if you encounter a function that
doesn't accept null, but probably should. (The rule of thumb for
this to be applicable is that the function must have special behavior
for 0 or "", which is distinct from the natural behavior of the
parameter.)

RFC: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg

Closes GH-6475.

show more ...

Use EXPECT instead of EXPECTF when possible

echo "Done\n";
?>
?>
Fatal error: Uncaught ArgumentCountError: explode() expects at least 2 parameters, 0 given in [no active file]:0
$triggerNotice+

Use EXPECT instead of EXPECTF when possible

echo "Done\n";
?>
?>
Fatal error: Uncaught ArgumentCountError: explode() expects at least 2 parameters, 0 given in [no active file]:0
$triggerNotice++;
?>
throw new Exception();
?>
?>
?>
?>
-- Testing date_parse() function with unexpected characters in $date argument --
?>
?>
-- Testing mktime() function with Zero arguments --
?>
?>
?>
echo "Done\n";
?>
echo "Done\n";
?>
echo "Done\n";
?>
?>
?>
?>
Arg value is: this is a string
?>
echo "Done";
?>
-- Testing posix_getgrgid() function with a negative group id --
echo "Done";
?>
-- Testing posix_getpgid() with negative pid --
echo "Done";
?>
-- Testing posix_getpwuid() function negative uid --
?>
echo "Done";
?>
-- Testing posix_kill() function with invalid signal --
echo "Done";
?>
-- Testing posix_strerror() function with invalid error number --
?>
-- Testing ReflectionMethod::getClosure() function with invalid object --
?>
?>
?>
-- Iteration 1 --
?>
?>
?>
echo "Done\n";
?>
echo"Done";
?>
echo "Done\n";
?>
echo "Done";
?>
-- Testing array_diff_assoc() function with zero arguments --
echo "Done";
?>
-- Testing array_diff() function with zero arguments --
-- Testing array_diff_key() function with less than expected no. of arguments --
?>
echo "Done"
?>
echo "Done";
?>
-- Iteration 1 --
echo "Done";
?>
-- Testing array_map() function with one less than expected no. of arguments --
echo "Done\n";
?>
--- Iteration 0 ---
echo"\nDone";
?>
?>
*** Variation with first two Arguments ***
echo "Done\n";
?>
echo "Done\n";
?>
echo "Done";
?>
echo "Done\n";
?>
echo "Done";
?>
echo "Done"
?>
?>
-- Testing usort() with built-in 'cmp_function': strcasecmp() --
echo "Done\n";
?>
echo "Done\n";
?>
echo "Done\n";
?>
--Iteration 1--
-- iteration 1 --
echo "Done\n";
echo "Done\n";
?>
*** Testing is_executable() on invalid files ***
echo "Done\n";
?>
echo "Done\n";
?>
*** Testing is_readable() on miscellaneous filenames ***
?>
echo "Done\n";
?>
*** Testing is_writable() with invalid filenames ***
?>
?>
echo "Done\n";
?>
?>
echo "Done\n";
?>
echo "Done\n";
?>
?>
?>
?>
?>
?>
?>
?>
-- Testing php_uname() function with invalid mode --
echo "Done\n";
?>
-- Iteration 1 --
echo "Done\n";
?>
-- Iteration 1 --
echo "Done\n";
?>

?>
*** Output for integer values ***
?>
lcg_value tests...
echo "Done\n";
?>
echo "Done\n";
?>
?>
echo "Done";
?>
-- Testing stream_set_timeout() function with a closed socket --
?>
-- Testing chr() function with no arguments --
echo "Done\n";
?>
echo "Done\n";
?>
echo "Done\n"
?>
?>
*** Using heredoc string ***
echo "Done\n";
?>
?>
Basic test WITH undefined var for result arg
?>
Test string with array values and results array
?>
-- Testing printf() function with Zero arguments --
echo "Done\n";
?>
echo "Done\n";
?>
echo "Done";
?>
-- Iteration 1 --
-- Testing sscanf() function with more than expected no. of arguments --
echo "Done\n";
?>
echo "*** Done ***";
?>
echo "*** Done ***";
?>
?>
-- Testing strval() function with object which has not toString() method --
?>
-- Variations for two arguments --
echo "\nDone";
?>
?>
?>
-- Testing strptime() function on failure --
echo "Done\n";
?>

show more ...

Adjust tests for zpp TypeError change

Trim trailing whitespace in *.phpt

Trim trailing whitespace in *.phpt

Trim trailing whitespace in *.phpt

Trim trailing whitespace in tests

Remove superfluous SKIPIF sections of always available functions

Use bool instead of boolean while throwing a type error

PHP requires boolean typehints to be written "bool" and disallows
"boolean" as an alias. This changes the error messages to match

Use bool instead of boolean while throwing a type error

PHP requires boolean typehints to be written "bool" and disallows
"boolean" as an alias. This changes the error messages to match
the actual type name and avoids confusing messages like "must be
of type boolean, boolean given".

This a followup to ce1d69a1f6dcf15d43029301059c25e5bc09a577, which
implements the same change for integer->int.

show more ...

Use int instead of integer in type errors

PHP requires integer typehints to be written "int" and does not
allow "integer" as an alias. This changes type error messages to
match the a

Use int instead of integer in type errors

PHP requires integer typehints to be written "int" and does not
allow "integer" as an alias. This changes type error messages to
match the actual type name and avoids confusing messages like
"must be of the type integer, integer given".

show more ...

Fix WS

As discussed in
<https://github.com/php/php-src/commit/14d4ee93#commitcomment-19344508>.

Implement #65038: IMAGETYPE_WEBP constant missing

We add WebP support for getimagesize(), getimagesizefromstring)(),
image_type_to_extension() and image_type_to_mime_type(). For now we

Implement #65038: IMAGETYPE_WEBP constant missing

We add WebP support for getimagesize(), getimagesizefromstring)(),
image_type_to_extension() and image_type_to_mime_type(). For now we
care only about the simple lossy WebP format (VP8) and ignore the
lossless (VP8L) and extended (VP8X) formats. We use image/webp as MIME
type as it appears to be pretty common, even though it is not yet
registered with IANA.

Relevant specifications:
* <https://developers.google.com/speed/webp/docs/riff_container>
* <https://tools.ietf.org/html/rfc6386>

show more ...

Use "float" and "integer" in typehint and zpp errors

improve test file
don't forget to test invalid parameters etc.

MFH: image_type_to_mime_type()