curl: Prevent a CurlMultiHandle from holding onto a CurlHandle if `add_handle` fails (#16302)

* curl: Prevent a CurlMultiHandle from holding onto a CurlHandle if `add_handle` fails

curl: Prevent a CurlMultiHandle from holding onto a CurlHandle if `add_handle` fails (#16302)

* curl: Prevent a CurlMultiHandle from holding onto a CurlHandle if `add_handle` fails

As a user I expect `curl_multi_add_handle` to not have any effect if it returns
an error and I specifically do not expect that it would be necessary to call
`curl_multi_remove_handle`.

* NEWS

show more ...

Fixed GH-15547: curl_multi_wait expects a signed int for timeout.

confusion might come from the previous argument type.
PHP expects ms so we check it fits integer boundaries before the c

Fixed GH-15547: curl_multi_wait expects a signed int for timeout.

confusion might come from the previous argument type.
PHP expects ms so we check it fits integer boundaries before the cast.
raising a warning at least for stable branches.

close GH-15548

show more ...

Fix missing error check in curl_multi_init()

Closes GH-13157.

Merge branch 'PHP-8.1' into PHP-8.2

* PHP-8.1:
Fix return value of _php_server_push_callback in case of failure

Fix return value of _php_server_push_callback in case of failure

It should return CURL_PUSH_DENY by default instead of CURL_PUSH_OK in
the branch I added, just like the check above.

Fix return value of _php_server_push_callback in case of failure

It should return CURL_PUSH_DENY by default instead of CURL_PUSH_OK in
the branch I added, just like the check above.
I forgot to change this after doing tests.

show more ...

Merge branch 'PHP-8.1' into PHP-8.2

* PHP-8.1:
Fix crash when an invalid callback function is passed to CURLMOPT_PUSHFUNCTION

Fix crash when an invalid callback function is passed to CURLMOPT_PUSHFUNCTION

Previously this caused a SIGABRT.

Closes GH-11639.

Revert "Port all internally used classes to use default_object_handlers"

This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a.

The commit was a bit too late to be included i

Revert "Port all internally used classes to use default_object_handlers"

This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a.

The commit was a bit too late to be included in PHP 8.2 RC1. Given it's a massive ABI break, we decide to postpone the change to PHP 8.3.

show more ...

Port all internally used classes to use default_object_handlers

Signed-off-by: Bob Weinand <bobwei9@hotmail.com>

Expose new constants from libcurl 7.62 to 7.80

Return true for success instead of failure in PHP cURL setopt helpers

This also fixes what was an incorrect return value for an intermediate
failure in _php_curl_multi_setopt() when sett

Return true for success instead of failure in PHP cURL setopt helpers

This also fixes what was an incorrect return value for an intermediate
failure in _php_curl_multi_setopt() when setting CURLMOPT_PUSHFUNCTION

show more ...

Use more specific types instead of int in cURL extension

Not serializable flag permeation

Fixed some spaces used instead of tabs

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Mark resource-like objects as non-comparable

Mark resource-like objects as non-comparable

As these hold on to some internal resource, there can't be two
"equal" objects with different identity. Make sure the lack of
public prop

Mark resource-like objects as non-comparable

As these hold on to some internal resource, there can't be two
"equal" objects with different identity. Make sure the lack of
public properties doesn't result in these being treated as always
equal.

show more ...

Generate class entries for a few extensions

Relates to GH-6644

Remove method member from php_curl_callback

For these callbacks a non-null callback already indicates that
a user callback should be used. We don't need an additional
member to tell

Remove method member from php_curl_callback

For these callbacks a non-null callback already indicates that
a user callback should be used. We don't need an additional
member to tell us the same thing.

show more ...

Don't allocate php_curl_handlers separately

Always allocated together with php_curl... no point in that.

Don't allocate php_curlm_handlers separately

This is always allocated together with the php_curlm structure,
there's no point in making it a separate allocation.

Use single typedef for curl callbacks

There's no value in making these separate types.

Fixed bug #80121

The issue affected both CurlHandle and CurlMultiHandle. I'll have
to double check this for other resource->object conversions as well.

Private/public split curl header

To allow exporting the php_curl.h header containing curl class
entries, split off a separate curl_private.h header with all the
implementation detail

Private/public split curl header

To allow exporting the php_curl.h header containing curl class
entries, split off a separate curl_private.h header with all the
implementation details.

We may move or expose additional APIs in php_curl.h on an as-needed
basis.

show more ...

Remove some unnecessary HAVE_EXTNAME guards

A recurring pattern in old extension: Putting the whole source
code behind HAVE_EXTNAME. This is pointless, as the code is only
compiled i

Remove some unnecessary HAVE_EXTNAME guards

A recurring pattern in old extension: Putting the whole source
code behind HAVE_EXTNAME. This is pointless, as the code is only
compiled if the extension is enabled.

This removes a couple of them, but not all.

show more ...