Apply SimpleXML iterator fixes only on master

Many methods in SimpleXML reset the iterator when called. This has the
consequence that mixing these operations with loops can cause infinit

Apply SimpleXML iterator fixes only on master

Many methods in SimpleXML reset the iterator when called. This has the
consequence that mixing these operations with loops can cause infinite
loops, or the loss of iteration data.
Some people may however rely on the resetting behaviour. To prevent
unintended breaks in stable branches, let's only apply the fix to master.

This reverts GH-12193, GH-12229, GG-12247 for stable branches while
keeping them on master, adding a note in UPGRADING as well.

show more ...

Fix GH-12167 and GH-12169: Unable to get comment or processing instruction contents in SimpleXML

Closes GH-12289.

Fix bug #55098: SimpleXML iteration produces infinite loop

Closes GH-12247.

Fix GH-12208: SimpleXML infinite loop when a cast is used inside a foreach

Closes GH-12229.

Fix GH-12223: Entity reference produces infinite loop in var_dump/print_r

Closes GH-12223.

Fix GH-12192: SimpleXML infinite loop when getName() is called within foreach

This happens because getName() resets the iterator to the start because
it overwrites the iterator data.

Fix GH-12192: SimpleXML infinite loop when getName() is called within foreach

This happens because getName() resets the iterator to the start because
it overwrites the iterator data.
We add a version of get_first_node that does not overwrite the iterator
data.

Closes GH-12193.

show more ...

Fix GH-12170: Can't use xpath with comments in SimpleXML

Closes GH-12177.

Fix #52751: XPath processing-instruction() function is not supported.

Closes GH-12165.

Sanitize libxml2 globals before parsing

Fixes GHSA-3qrf-m4j2-pcrr.

To parse a document with libxml2, you first need to create a parsing context.
The parsing context contains par

Sanitize libxml2 globals before parsing

Fixes GHSA-3qrf-m4j2-pcrr.

To parse a document with libxml2, you first need to create a parsing context.
The parsing context contains parsing options (e.g. XML_NOENT to substitute
entities) that the application (in this case PHP) can set.
Unfortunately, libxml2 also supports providing default set options.
For example, if you call xmlSubstituteEntitiesDefault(1) then the XML_NOENT
option will be added to the parsing options every time you create a parsing
context **even if the application never requested XML_NOENT**.

Third party extensions can override these globals, in particular the
substitute entity global. This causes entity substitution to be
unexpectedly active.

Fix it by setting the parsing options to a sane known value.
For API calls that depend on global state we introduce
PHP_LIBXML_SANITIZE_GLOBALS() and PHP_LIBXML_RESTORE_GLOBALS().
For other APIs that work directly with a context we introduce
php_libxml_sanitize_parse_ctxt_options().

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
NEWS
Fix bug #81325 Segfault in zif_simplexml_import_dom

Fix bug #81325 Segfault in zif_simplexml_import_dom

Add RETURN/RETVAL_COPY_DEREF() macros

These were missing from the set...

I think quite a few of these usages don't actually need the DEREF,
but I've just kept things as is for n

Add RETURN/RETVAL_COPY_DEREF() macros

These were missing from the set...

I think quite a few of these usages don't actually need the DEREF,
but I've just kept things as is for now.

show more ...

Not serializable flag permeation

Fixed some spaces used instead of tabs

Remove SimpleXMLElement dtor_obj handler

I don't see any reason why this cleanup needs to happen inside
dtor_obj.

If there is a reason, it's lacking in test coverage...

Declare tentative return types for ext/simplexml

Closes GH-7003

Drop SXE_METHOD() macro

Don't break my grep.

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Revert "Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement"

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Revert "Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement"

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Revert "Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement"

Revert "Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement"

Sorry, this solution seems to have BC breaks, will need to look
for better one.

This reverts commit 9

Revert "Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement"

Sorry, this solution seems to have BC breaks, will need to look
for better one.

This reverts commit 9f7e8b777cb3e8aac53e677f3152af18413ab672.

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement