Fix use-of-uninitialized value in phar_object.c

resource would stay uninitialized if the first call to zend_parse_parameters
fails, but the value is still passed to phar_add_file(). It's

Fix use-of-uninitialized value in phar_object.c

resource would stay uninitialized if the first call to zend_parse_parameters
fails, but the value is still passed to phar_add_file(). It's not used there if
cont_str is provided and so didn't cause any issues.

Closes GH-11202

show more ...

Fix wrong flags check for compression method in phar_object.c

I found this issue using static analysis tools, it reported that the condition was always false.
We can see that flags is as

Fix wrong flags check for compression method in phar_object.c

I found this issue using static analysis tools, it reported that the condition was always false.
We can see that flags is assigned in the switch statement above, but a mistake was made in the comparison.

Closes GH-10328

Signed-off-by: George Peter Banyard <girgias@php.net>

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Update NEWS
Fix #81211: Symlinks are followed when creating PHAR archive

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Update NEWS
Fix #81211: Symlinks are followed when creating PHAR archive

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Update NEWS
Fix #81211: Symlinks are followed when creating PHAR archive

Fix #81211: Symlinks are followed when creating PHAR archive

It is insufficient to check whether the `base` is contained in `fname`;
we also need to ensure that `fname` is properly separ

Fix #81211: Symlinks are followed when creating PHAR archive

It is insufficient to check whether the `base` is contained in `fname`;
we also need to ensure that `fname` is properly separated. And of
course, `fname` has to start with `base`.

show more ...

implement openssl_256 and openssl_512 for phar singatures

Don't return bool from Phar::offsetUnset()

This violates the ArrayAccess interface. Use offsetExists() to
check if an entry exists.

Fixed some spaces used instead of tabs

Declare tentative return types for ext/phar (#7052)

Merge branch 'PHP-8.0'

* Add a few missing RETURN_THROWS();
* Fix a few ext/phar return types

Add a few missing RETURN_THROWS();

Only PharFileInfo::compress() really needs it though.

Store base path as zend_string in Phar::buildFrom*

This also removes the need to check for length overflow, as the
length is now size_t.

Accept regex as zend_string in Phar::buildFromDirectory()

No need to copy it...

Use zend_string_equals_* API in a couple of more place

Closes GH-6979

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Introduce pseudo-keyword ZEND_FALLTHROUGH

And use it instead of comments

Change Zend Stream API to use zend_string* instead of char*.

This allows to eliminate re-calculation of string lenght and hash value.
See the detailed list of changes in UPGRADING.INTERN

Change Zend Stream API to use zend_string* instead of char*.

This allows to eliminate re-calculation of string lenght and hash value.
See the detailed list of changes in UPGRADING.INTERNALS.

show more ...

Improve SPL directory and stat() cache using zend_srting* instead of char*

Generate class entries from stubs for phar, posix, pspell, readline, reflection, session, shmop

Closes GH-6692

Merge branch 'PHP-8.0'

* PHP-8.0:
Make Phar $fileNotFoundScript nullable

Make Phar $fileNotFoundScript nullable

While "" is already treated the same way as absence, null is the
logically correct default here. Making this one argument non-nullable
is parti

Make Phar $fileNotFoundScript nullable

While "" is already treated the same way as absence, null is the
logically correct default here. Making this one argument non-nullable
is particularly pecular when considering that the preceding $alias
and $index arguments are both nullable.

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Fix #69279: Compressed ZIP Phar extractTo() creates garbage files

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Fix #69279: Compressed ZIP Phar extractTo() creates garbage files

Fix #69279: Compressed ZIP Phar extractTo() creates garbage files

When extracting compressed files from an uncompressed Phar, we must not
use the direct file pointer, but rather get an u

Fix #69279: Compressed ZIP Phar extractTo() creates garbage files

When extracting compressed files from an uncompressed Phar, we must not
use the direct file pointer, but rather get an uncompressed file
pointer.

We also add a test to show that deflated and stored entries are
properly extracted.

This also fixes #79912, which appears to be a duplicate of #69279.

Co-authored-by: Anna Filina <afilina@gmail.com>

Closes GH-6599.

show more ...