Fix compiler warnings in ext/intl

I don't really get why these didn't show up before.

Declare tentative return types for ext/intl (#6986)

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Warning to ValueError promotion in Intl extension Part 1

Affects:
- IntlCalendar
- IntlGregorianCalendar
- IntlBreakIterator

Closes GH-5669

Introduce InternalIterator

Userland classes that implement Traversable must do so either
through Iterator or IteratorAggregate. The same requirement does
not exist for internal class

Introduce InternalIterator

Userland classes that implement Traversable must do so either
through Iterator or IteratorAggregate. The same requirement does
not exist for internal classes: They can implement the internal
get_iterator mechanism, without exposing either the Iterator or
IteratorAggregate APIs. This makes them usable in get_iterator(),
but incompatible with any Iterator based APIs.

A lot of internal classes do this, because exposing the userland
APIs is simply a lot of work. This patch alleviates this issue by
providing a generic InternalIterator class, which acts as an
adapater between get_iterator and Iterator, and can be easily
used by many internal classes. At the same time, we extend the
requirement that Traversable implies Iterator or IteratorAggregate
to internal classes as well.

Closes GH-5216.

show more ...

Refactor IntlBreakIterator::next() handling

Generate method entries for ext/intl

Closes GH-5370

Get rid of method mapping of BreakIterator classes

Remove unnecessary checks in breakpoint iterator

The result of Z_INTL_BREAKITERATOR_P() cannot be NULL. This type
of macro in general can never be NULL.

Use RETURN_THROWS() during ZPP in most of the extensions

Except for some bigger ones: reflection, sodium, spl

Cleanup return values for Intl when parameter parsing is unsuccessful

Closes GH-4871.

Remove mention of PHP major version in Copyright headers

Closes GH-4732.

Intl: Don't separately report "bad arguments" errors

zpp will be throwing for these now, don't report them in addition to
that.

Use ZEND_THIS macro to hide implementation details in extensions code.

Eliminate useless $this related check

Remove unused variables

Make $locale parameter to BreakIterator ctors optional

It's documented as such and already accepts null.

Simplify namespace access

The icu namespace is an alias which resolves to the real namespace.

Utilize the recommended way to handle the icu namespace

Use ZSTR_ API to access zend_string elements (this is just renaming without semantick changes).

Fix Intl constructor leaks

Drop the Z_OBJ(return_value) = NULL hack and return status code
from ctor function instead.

Patch improvement:

Removed the corresponding core code.
Fixed ext/com_dotnet and ext/date.
Refactored ext/intl changes.
Improved ext/fileinfo and ext/pdo changes.
Fixed tests.

Converted intl extension to use IntlException in constructors.

zend_get_parameters_ex is deprecated

first shot remove TSRMLS_* things