History log of /PHP-8.1/ext/dom/parentnode.c (Results 1 – 22 of 22)
Revision (<<< Hide revision tags) (Show revision tags >>>) Date Author Comments
# d19e4da1 07-Aug-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix segfault when DOMParentNode::prepend() is called when the child disappears

Closes GH-11906.


# df6e8bd4 05-Aug-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix viable next sibling search for replaceWith

Closes GH-11888.


# dddd309d 05-Aug-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix GH-11830: ParentNode methods should perform their checks upfront

Closes GH-11887.


# 5c26258e 13-Jul-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Handle fragments consisting out of multiple children without a single root correctly

Closes GH-11698.


# 15ff8303 07-Jul-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix GH-11625: DOMElement::replaceWith() doesn't replace node with DOMDocumentFragment but just deletes node or causes wrapping <></> depending on libxml2 version

Depending on the libxml2 ver

Fix GH-11625: DOMElement::replaceWith() doesn't replace node with DOMDocumentFragment but just deletes node or causes wrapping <></> depending on libxml2 version

Depending on the libxml2 version, the behaviour is either to not
render the fragment correctly, or to wrap it inside <></>. Fix it by
unpacking fragments manually. This has the side effect that we need to
move the unlinking check in the replacement function to earlier because
the empty child list is now possible in non-error cases.
Also fixes a mistake in the linked list management.

Closes GH-11627.

show more ...


# 23f70025 03-Jun-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix bug #81642: DOMChildNode::replaceWith() bug when replacing a node with itself

Closes GH-11363.


# b1d8e240 03-Jun-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix bug #67440: append_node of a DOMDocumentFragment does not reconcile namespaces

The test was amended from the original issue report. For the test:
Co-authored-by: php@deep-freeze.ca

Fix bug #67440: append_node of a DOMDocumentFragment does not reconcile namespaces

The test was amended from the original issue report. For the test:
Co-authored-by: php@deep-freeze.ca

The problem is that the regular dom_reconcile_ns() only works on a
single node. We actually have to reconciliate the whole tree in case a
fragment was added. This also required to move some code around such
that this special case could be handled separately.

Closes GH-11362.

show more ...


# b374ec39 29-May-2023 nielsdos <7771979+nielsdos@users.noreply.github.com>

Fix DOMElement::append() and DOMElement::prepend() hierarchy checks

We could end up in an invalid hierarchy, resulting in infinite loops and
eventual crashes if we don't check for the DO

Fix DOMElement::append() and DOMElement::prepend() hierarchy checks

We could end up in an invalid hierarchy, resulting in infinite loops and
eventual crashes if we don't check for the DOM hierarchy validity.

Closes GH-11344.

show more ...


# cba335d6 22-May-2023 nielsdos <7771979+nielsdos@users.noreply.github.com>

Fix GH-11288 and GH-11289 and GH-11290 and GH-9142: DOMExceptions and segfaults with replaceWith

This replaces the implementation of before and after with one following
the spec very str

Fix GH-11288 and GH-11289 and GH-11290 and GH-9142: DOMExceptions and segfaults with replaceWith

This replaces the implementation of before and after with one following
the spec very strictly, instead of trying to figure out the state we're
in by looking at the pointers. Also relaxes the condition on text node
copying to prevent working on a stale node pointer.

Closes GH-11299.

show more ...


# 0579beb8 30-Mar-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix incorrect error handling in dom_zvals_to_fragment()

Discovered this pre-existing problem while testing GH-10682.
Note: this problem existed *before* that PR.

* Not all paths

Fix incorrect error handling in dom_zvals_to_fragment()

Discovered this pre-existing problem while testing GH-10682.
Note: this problem existed *before* that PR.

* Not all paths throw a hierarchy request error
* xmlFreeNode must be used instead of xmlFree for the fragment to also
free its children.
* Free up nodes that couldn't be added when xmlAddChild fails.

I unified the error handling code that's exactly the same with a goto to
prevent at least some of such problems in the future.

Closes GH-10981.

show more ...


# 2d6decc1 23-Feb-2023 NathanFreeman <1056159381@qq.com>

Fix bug #80602: Segfault when using DOMChildNode::before()

This furthermore fixes the logic error explained in
https://github.com/php/php-src/pull/8729#issuecomment-1161737132

C

Fix bug #80602: Segfault when using DOMChildNode::before()

This furthermore fixes the logic error explained in
https://github.com/php/php-src/pull/8729#issuecomment-1161737132

Closes GH-10682.

show more ...


Revision tags: php-8.1.7RC1, php-8.1.4RC1, php-8.1.3, php-8.1.2RC1, php-8.1.0, php-7.3.33, php-7.3.32, php-7.3.31, php-7.3.30, php-7.3.29
# 01b3fc03 06-May-2021 KsaR

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...


Revision tags: php-7.3.28
# e0aab741 16-Mar-2021 Máté Kocsis

Promote DOM invalid state errors during property access

Closes GH-6780


Revision tags: php-7.3.27
# 665e1f32 01-Feb-2021 Benjamin Eberlei

Fix bug #80600 DOMChildNode::remove does not work on DOMCharacterData.

Closes GH-6660


Revision tags: php-7.3.26, php-7.3.26RC1, php-7.3.25, php-7.3.25RC1, php-7.3.24, php-7.3.24RC1, php-7.3.23, php-7.3.23RC1, php-7.3.22, php-7.3.22RC1
# 9f6820f7 15-Aug-2020 Benjamin Eberlei

Fix #79968: Manipulation on unattached DOMChildNode should throw DOMException


Revision tags: php-7.3.21, php-7.3.21RC1, php-7.3.20, php-7.3.20RC1, php-7.3.19, php-7.4.7RC1, php-7.3.19RC1
# 62b1d2cb 12-May-2020 George Peter Banyard

Fix [-Wundef] warning in DOM extension


Revision tags: php-7.3.18RC1, php-7.2.30, php-7.3.17
# dfd0acf0 11-Apr-2020 Máté Kocsis

Generate method entries for ext/dom

Closes GH-5374


Revision tags: php-7.3.17RC1
# 305b17e8 29-Mar-2020 Máté Kocsis

Do not include the same stub multiple times

Closes GH-5322


# 01b266aa 18-Mar-2020 Máté Kocsis

Improve error messages of various extensions

Closes GH-5278


Revision tags: php-7.3.18, php-7.3.16
# 0d913f9a 05-Mar-2020 Benjamin Eberlei

Fix another memory leak in dom_zvals_to_fragment.


Revision tags: php-7.3.16RC1
# a7a2e985 03-Mar-2020 Nikita Popov

Fix memory leak in dom_zvals_to_fragment


# 5acd86df 28-Feb-2020 Benjamin Eberlei

[RFC] Implement new DOM Living Standard APIs in ext/dom