Fix GH-9155: dba_open("non-existing", "c-", "flatfile") segfaults

We must not assume that the lock file has been opened.

Closes GH-9156.

Replace the use of ZVAL_BOOL() with ZVAL_TRUE() or ZVAL_FALSE() where the value is fixed (#8815)

Fix [-Wundef] warnings in DBA extension

Use zend_string for DBA first/next key handlers

Use zend_string for DBA delete handler

Use zend_string for DBA exist handler

Use zend_string for DBA update handler

Use zend_string for DBA fetch handler

Drop dba_lock.name element

This is unused

Refactor dba_(p)open() to be more sensible (#7610)

Actually use ZPP
Throw ValueErrors for invalid values
Use dedicated struc members for file permission and map size instead of a zva

Refactor dba_(p)open() to be more sensible (#7610)

Actually use ZPP
Throw ValueErrors for invalid values
Use dedicated struc members for file permission and map size instead of a zval stack

show more ...

DBA should not convert elements in-place if the key param is an array

Also check that the value can actually be converted to string

Fix DBA on MacOS (#7611)

The name zend_string* must be copied instead of returned directly in case the group part of the array is empty.

Refactor DBA

Use proper ZPP union types
Use standard function signature semantics for dba_fetch()
Re-ordering of checks

Drop confusing ac local variable for ZEND_NUM_ARGS()

Inline DBA_GET2 macro

It was used only twice

Inline DBA_ID_PARS macro

It is used only 3 times and provides variable declarations which one shouldn't need to grep to see what is declared

Inline DBA_GET2_3 macro

It is only used once

Inline DBA_ID_GET2(_3) Macro

Fixed some spaces used instead of tabs

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Introduce pseudo-keyword ZEND_FALLTHROUGH

And use it instead of comments

Fix #80817: dba_popen() may cause segfault during RSHUTDOWN

We need to close persistent streams with the proper flag.

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool is retained as an alias.

show more ...

Make convert_to_*_ex simple aliases of convert_to_*

Historically, the _ex variants separated the zval first, if a
conversion was necessary. This distinction no longer makes sense
sin

Make convert_to_*_ex simple aliases of convert_to_*

Historically, the _ex variants separated the zval first, if a
conversion was necessary. This distinction no longer makes sense
since PHP 7.

The only difference that was still left is that _ex checked whether
the type is the same first, but the usage of these macros did not
actually distinguish on whether such an inlined check is valuable
or not in a given context.

Also drop the unused convert_to_explicit_type macros.

show more ...

Review the usage of apostrophes in error messages

Closes GH-5590