Fix the crypt sha apis build (with recent clang versions).

Removing the said subtraction by casting instead.
While at it fixing werror level on phpdbg too.

Closes #8897.

Consolidate the usage of "either" and "one of" in error messages

Closes GH-6173

Remove support for EXT_NOP

This is an annoying edge case that regularly gets broken. As we're
not aware of significant users of this API, and there are other
ways to hook this, remov

Remove support for EXT_NOP

This is an annoying edge case that regularly gets broken. As we're
not aware of significant users of this API, and there are other
ways to hook this, remove support for EXT_NOP.

show more ...

Simplify error type filter

Closes GH-6049.

Disable report_zend_debug by default

We might just want to drop this completely, but at least don't
enable it by default. It already gets disabled by a number of
SAPIs, but we should

Disable report_zend_debug by default

We might just want to drop this completely, but at least don't
enable it by default. It already gets disabled by a number of
SAPIs, but we should make that the default state.

show more ...

Disable JIT for PHPDBG

Remove proto comments from C files

Closes GH-5758

Fix Haiku build

getrusage supports only two fields. The network api sits in the network lib.

Closes GH-5732.

Constify char * arguments of APIs

Closes GH-5676.

Fix MSVC level 1 (severe) warnings

We fix (hopefully) all instances of:

* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4005>

Fix MSVC level 1 (severe) warnings

We fix (hopefully) all instances of:

* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4005>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4024>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4028>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4047>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4087>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4090>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4273>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4312>

`zend_llist_add_element()` and `zend_llist_prepend_element()` now
explicitly expect a *const* pointer.

We use the macro `ZEND_VOIDP()` instead of a `(void*)` cast to suppress
C4090; this should prevent accidential removal of the cast by
clarifying the intention, and makes it easier to remove the casts if
the issue[1] will be resolved sometime.

[1] <https://developercommunity.visualstudio.com/content/problem/390711/c-compiler-incorrect-propagation-of-const-qualifie.html>

show more ...

Fix several mostly Windows related phpdbg bugs

* Properly initialize PHPDBG_G(watch_tmp)

Otherwise that may cause segfaults in ZTS builds.

* Deactivate potentially remain

Fix several mostly Windows related phpdbg bugs

* Properly initialize PHPDBG_G(watch_tmp)

Otherwise that may cause segfaults in ZTS builds.

* Deactivate potentially remaining watchpoints after REPL

Otherwise the memory could still be protected, resulting in segfaults
during shutdown.

* NULL zend_handlers_table after freeing

As of commit 4130fe4[1], the `zend_handlers_table` is explicitly
freed in the `zend_vm_dtor()`. Since phpdbg (and maybe some other
SAPIs) may restart the engine afterwards, we have to make sure that
the table is also NULLed.

* Only set context option if there is a context

In other words, we must not follow the null pointer.

* Cater to file handles without attached console

File handles do not necessarily have an attached console (for
instance, pipes do not), in which case `GetConsoleScreenBufferInfo()`
fails. In this case we set a default value (`40`) for lines like on
other systems.

[1] <http://git.php.net/?p=php-src.git;a=commit;h=4130fe437a5db7ead1444d3748bd0fbad9829cb2>

show more ...

Fix INI setting member name

Since the member is not used in `OnUpdateEol()` that's not really an
issue, but still it's confusing to apparently have two INI settings
targeting the sam

Fix INI setting member name

Since the member is not used in `OnUpdateEol()` that's not really an
issue, but still it's confusing to apparently have two INI settings
targeting the same member.

show more ...

Add stubs for some SAPIs

For apache2handler, fpm, litespeed, phpdbg, specifically.
Partially implements GH-5295

Code tweaks: Remove unneeded semicolons

Improve a last couple of argument error messages

Closes GH-5404

Fix #78880: Another bunch of spelling errors

Use RETURN_THROWS() during ZPP in main, sapi, win32, and Zend

Convert phpdbg arginfo to php stubs

Closes GH-4867.

Small phpdbg cleanups

Add a zpp_none() call, convert E_ERROR to ValueError.

Remove mention of PHP major version in Copyright headers

Closes GH-4732.

Fix symtable_cache_limit assignment in phpdbg

The meaning of the limit changed in 7.4, it now points one past the
end. Adjust code accordingly.

Report errors from stream read and write operations

The php_stream_read() and php_stream_write() functions now return
an ssize_t value, with negative results indicating failure. Function

Report errors from stream read and write operations

The php_stream_read() and php_stream_write() functions now return
an ssize_t value, with negative results indicating failure. Functions
like fread() and fwrite() will return false in that case.

As a special case, EWOULDBLOCK and EAGAIN on non-blocking streams
should not be regarded as error conditions, and be reported as
successful zero-length reads/writes instead. The handling of EINTR
remains unclear and is internally inconsistent (e.g. some code-paths
will automatically retry on EINTR, while some won't).

I'm landing this now to make sure the stream wrapper ops API changes
make it into 7.4 -- however, if the user-facing changes turn out to
be problematic we have the option of clamping negative returns to
zero in php_stream_read() and php_stream_write() to restore the
old behavior in a relatively non-intrusive manner.

show more ...

Initialize last_line in phpdbg globals

Avoid reliance on arena details on phpdbg oplog

Instead of guessing what the address of the first arena allocation
is going to be, embed the sentinel in the oplog_list structure
dire

Avoid reliance on arena details on phpdbg oplog

Instead of guessing what the address of the first arena allocation
is going to be, embed the sentinel in the oplog_list structure
directly.

show more ...

implement tsrm_is_shutdown API