mysqli_get_client_info() cannot return null

This method is already deprecated

Fix the return type of mysqli_connect()

Fix the return type of mysqli::connect()

Fix return type of mysqli::init()

Make mysqli_ssl_set() arguments nullable

This function internally converts zero length arguments to NULL
argument -- but we should also accept them in the first place.

Null argu

Make mysqli_ssl_set() arguments nullable

This function internally converts zero length arguments to NULL
argument -- but we should also accept them in the first place.

Null arguments being accepted was actually documented, before
bug #78399 adjusted the docs to match current behavior.

show more ...

Make fetch_* OO same as func

Clsoses GH-6580.

Fix/improve mysqli stubs

* mysqli_commit $flags default value is 0, not -1.
* A number of functions cannot actually return null.
* mysqli_poll parameter names were incorrect, as this

Fix/improve mysqli stubs

* mysqli_commit $flags default value is 0, not -1.
* A number of functions cannot actually return null.
* mysqli_poll parameter names were incorrect, as this function
has a different signature from select.
* fetch functions apart from fetch_all can return false on failure.

show more ...

Fix default value handling of mysqli_fetch_object()

Make [] acceptable both for classes without constructors and
classes with a constructor that takes no arguments.

Closes GH-63

Fix default value handling of mysqli_fetch_object()

Make [] acceptable both for classes without constructors and
classes with a constructor that takes no arguments.

Closes GH-6336.

show more ...

Verify parameter names of function aliases

Closes GH-6335

Use $statement in mysqli

As we went with $statement rather than $stmts in other places,
let's also use it in mysqli. The discrepancy with mysqli_stmt
is a bit unfortunate, but we can

Use $statement in mysqli

As we went with $statement rather than $stmts in other places,
let's also use it in mysqli. The discrepancy with mysqli_stmt
is a bit unfortunate, but we can't be consistent with *both*.

Closes GH-6330.

show more ...

Make mysqli_warning constructor private

The constructor was already effectively inaccessible (protected
on a final class). This just makes it more obvious and removes
the implementat

Make mysqli_warning constructor private

The constructor was already effectively inaccessible (protected
on a final class). This just makes it more obvious and removes
the implementation in favor of directly throwing.

Per the removed test, this was an unfinished feature, and I don't
think it makes a lot of sense to finish it -- the
mysqli_stmt::get_warnings() interface makes more sense than
direct construction.

Closes GH-6208.

show more ...

Rename mysqli parameters to be more logical

Closes GH-6172.

More precise type in mysqli_result constructor

This ctor requires a mysqli object. Possibly there was some
confusion with the mysqli_warning constructor here.

Add missing mysqlnd checks to stubs

Promote warnings to Error in MySQLi extension

Closes GH-5803

Remove dummy aliases for mysqli constructors

These are only available as methods. Directly declare them as
such instead of aliasing to functions that don't actually exist.

Add another round of missing parameter types to stubs

Closes GH-5950

Add a few missing parameter types in stubs

Related to GH-5627

Fix arg/func info

* mysqli_get_server_info() cannot return null. The underlying API
is infallible.
* mysqli_select_db() func info is redundant.
* mb_detect_order() can only

Fix arg/func info

* mysqli_get_server_info() cannot return null. The underlying API
is infallible.
* mysqli_select_db() func info is redundant.
* mb_detect_order() can only return array|true, not array|false.

Also make the func_info.phpt test that is supposed to catch these
kinds of issues actually work.

show more ...

Introduce InternalIterator

Userland classes that implement Traversable must do so either
through Iterator or IteratorAggregate. The same requirement does
not exist for internal class

Introduce InternalIterator

Userland classes that implement Traversable must do so either
through Iterator or IteratorAggregate. The same requirement does
not exist for internal classes: They can implement the internal
get_iterator mechanism, without exposing either the Iterator or
IteratorAggregate APIs. This makes them usable in get_iterator(),
but incompatible with any Iterator based APIs.

A lot of internal classes do this, because exposing the userland
APIs is simply a lot of work. This patch alleviates this issue by
providing a generic InternalIterator class, which acts as an
adapater between get_iterator and Iterator, and can be easily
used by many internal classes. At the same time, we extend the
requirement that Traversable implies Iterator or IteratorAggregate
to internal classes as well.

Closes GH-5216.

show more ...

Fix some UNKNOWN default values

In ext/ffi, ext/intl, ext/mysqli, and ext/pcntl

Annotate internal functions with the mixed type

Closes GH-5618

Fix some final classes in stubs

Fix UNKNOWN default values in various extensions

Closes GH-5514

Remove support for libmysqlclient 5.0

Closes GH-5391.