Apply tidy formatting

Mostly reindent PHP scripts to spaces.

Fix #79008: General performance regression with PHP 7.4 on Windows

We no longer try to retrieve the filename of a given stream when
fstat'ing, because this is very slow. Since we neithe

Fix #79008: General performance regression with PHP 7.4 on Windows

We no longer try to retrieve the filename of a given stream when
fstat'ing, because this is very slow. Since we neither didn't do that
in PHP 7.3 and earlier, we regard this as sensible trade-off.

show more ...

Fix #78296: is_file fails to detect file

If we're constructing extended-length paths (i.e. paths prefixed with
`\\?\`), we have to replace all forward slashes with backward slashes,

Fix #78296: is_file fails to detect file

If we're constructing extended-length paths (i.e. paths prefixed with
`\\?\`), we have to replace all forward slashes with backward slashes,
because the former are not supported by Windows for extended-length
paths.

The more efficient and likely cleaner alternative solution would be to
cater to this in `php_win32_ioutil_normalize_path_w()` by always
replacing forward slashes, but that might break existing code. It
might be sensible to change that for `master`, though.

show more ...

Fix #78386: fstat mode has unexpected value on PHP 7.4

We must not assume that any file which is not a directory is a regular
file. Therefore we employ `GetFileType()` in this case to p

Fix #78386: fstat mode has unexpected value on PHP 7.4

We must not assume that any file which is not a directory is a regular
file. Therefore we employ `GetFileType()` in this case to properly
distinguish between character special, FIFO special and regular files.

show more ...

Fix bug #78094: File Search Problem Excessive Time

Instead of checking GetBinaryType() for each file, we do a much cheaper
pre-check whether the filename extension matches .exe or .com,

Fix bug #78094: File Search Problem Excessive Time

Instead of checking GetBinaryType() for each file, we do a much cheaper
pre-check whether the filename extension matches .exe or .com, and call
GetBinaryType() only in this case. For BC we also report .bat and .cmd
files as executables again.

The patch has been provided by @weltling.

show more ...

Fix parameter order

The parameter order of `php_sys_link()` should be identical on Windows
and POSIX, bug commit c9861bd[1] got that wrong.

[1] <http://git.php.net/?p=php-src.gi

Fix parameter order

The parameter order of `php_sys_link()` should be identical on Windows
and POSIX, bug commit c9861bd[1] got that wrong.

[1] <http://git.php.net/?p=php-src.git;a=commit;h=c9861bd7a974ef1555395b879c1035a0bbc12ef1>

show more ...

Fix potential OPcache file cache related issues

To solve issues detected during testing, we backport the following
commits to PHP 7.2:

129c5c1181bf344b37e13fd6dc5dfe76c13d7208

Fix potential OPcache file cache related issues

To solve issues detected during testing, we backport the following
commits to PHP 7.2:

129c5c1181bf344b37e13fd6dc5dfe76c13d7208
9ac133a0b3863ca4d9659140154ee237e5f4669a
ce72bc6b658c335dd37393d0beb28584e6805e97

show more ...

Ensure double slashes are replaced by the path normalization

Fix bc break in Windows readlink

GetFinalPathNameByHandleW is given a file handle to a symbolic link,
rather than one to the target, and therefore returns an incorrect path.

Fix

Fix bc break in Windows readlink

GetFinalPathNameByHandleW is given a file handle to a symbolic link,
rather than one to the target, and therefore returns an incorrect path.

Fix symlink with relative path and add test

show more ...

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly used by Vim and Emacs editors
yet with recent changes the once working definitions don't work
anymore in Vim without custom plugins or additional configuration.
Neither are these settings synced across the PHP code base.

A simpler and better approach is EditorConfig and fixing code
using some code style fixing tools in the future instead.

This patch also removes the so called modelines for Vim. Modelines
allow Vim editor specifically to set some editor configuration such as
syntax highlighting, indentation style and tab width to be set in the
first line or the last 5 lines per file basis. Since the php test
files have syntax highlighting already set in most editors properly and
EditorConfig takes care of the indentation settings, this patch removes
these as well for the Vim 6.0 and newer versions.

With the removal of local variables for certain editors such as
Emacs and Vim, the footer is also probably not needed anymore when
creating extensions using ext_skel.php script.

Additionally, Vim modelines for setting php syntax and some editor
settings has been removed from some *.phpt files. All these are
mostly not relevant for phpt files neither work properly in the
middle of the file.

show more ...

Remove yearly range from copyright notice

Trim trailing whitespace in source code files

Trim trailing whitespace in source code files

Ensure target is \0 terminated

Add compatibility bit

readlink in PHP doesn't error on regular files.

Refactor php_sys_readlink

Also move the implementation into win32 where it belongs

Refactor stat implementation

- move relevant parts into win32
- general cleanup
- use Windows API and fallback to POSIX
- improve filetime to timestamp conversion
- improve s

Refactor stat implementation

- move relevant parts into win32
- general cleanup
- use Windows API and fallback to POSIX
- improve filetime to timestamp conversion
- improve stat/fsat
- handle ino by using file index
- handle st_dev by using volume serial number

The inode implementation is based on file indexes from NTFS. On 32-bit,
fake inodes are shown, that may lead to unexpeted results. 64-bit
implementation is most reliable.

show more ...

Create and expose php_sys_symlink() and php_sys_link()

These macros are supposed to behave like POSIX's symlink() and link(),
respectively, on POSIX compliant systems and on Windows.

Create and expose php_sys_symlink() and php_sys_link()

These macros are supposed to behave like POSIX's symlink() and link(),
respectively, on POSIX compliant systems and on Windows.

Future scope: merge link.c and link_win32.c

show more ...

Fix condition

It looks like the real length limit is 247 bytes, not 248 as documented.

Remove inappropriate FreeLibrary calls

Constify readonly var

Reduce var scope

Trailing whitespaces

Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>

year++

year++