fix memory leaks in ext/ldap/ldap.c

Fix some memory bugs in ldap.c

Remove nsldap support

The newest version we're checking (libssldap50) seems to be about
15 years out of date. We could add support for libssldap60 (also
unmainted, but more recent),

Remove nsldap support

The newest version we're checking (libssldap50) seems to be about
15 years out of date. We could add support for libssldap60 (also
unmainted, but more recent), but given how nobody has expressed any
interest in this, I'm going ahead and dropping this code.

show more ...

Fix potentially uninitialized use in ldap

If ctrl->ldctl_value.bv_len is zero context is uninitialized. Only
free it if the call took place and succeeded.

Don't modify arrays passed by value

Don't use C++ style comments

Cf. <https://github.com/php/php-src/blob/f45b61b8988b5b2d80dd4a1df7edd04282cf319a/CODING_STANDARDS.md#syntax-and-indentation>

cc @mcmic

Use ldap_destroy instead of ldap_unbind_ext

Fix some leaks in ldap

The result of zval_get_string() needs to be released. In some places
where it is inconvenient to manage, I went back to convert_to_string.
It is safe in those

Fix some leaks in ldap

The result of zval_get_string() needs to be released. In some places
where it is inconvenient to manage, I went back to convert_to_string.
It is safe in those places due to existing array separations.

Also fix a preexisting leak when getting controls, the previous
value was not destroyed.

show more ...

Some more string conversion handling, fixing bug #77958

Avoid converting zval when not needed

Also added exception checks so that exception from __toString are
correctly handled in the future

ext/ldap: Use PKG_CHECK_MODULES to detect the libsasl2 library

Use ZEND_TRY_ASSIGN_REF_... macros for arguments passed to internal function by reference

Fix a NULL dereferencing crash in php-ldap

This happens when parsing a control response to a VLV request which does
not contain a "context" string.

See bug #77869

Switch to use ZTS cache

Mark ldap_control_paged_result and ldap_control_paged_result_response as deprecated

These functions have serious limitations and may confuse users.
Same operations can be done using the

Mark ldap_control_paged_result and ldap_control_paged_result_response as deprecated

These functions have serious limitations and may confuse users.
Same operations can be done using the new ldap control system in search
operations.

show more ...

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly used by Vim and Emacs editors
yet with recent changes the once working definitions don't work
anymore in Vim without custom plugins or additional configuration.
Neither are these settings synced across the PHP code base.

A simpler and better approach is EditorConfig and fixing code
using some code style fixing tools in the future instead.

This patch also removes the so called modelines for Vim. Modelines
allow Vim editor specifically to set some editor configuration such as
syntax highlighting, indentation style and tab width to be set in the
first line or the last 5 lines per file basis. Since the php test
files have syntax highlighting already set in most editors properly and
EditorConfig takes care of the indentation settings, this patch removes
these as well for the Vim 6.0 and newer versions.

With the removal of local variables for certain editors such as
Emacs and Vim, the footer is also probably not needed anymore when
creating extensions using ext_skel.php script.

Additionally, Vim modelines for setting php syntax and some editor
settings has been removed from some *.phpt files. All these are
mostly not relevant for phpt files neither work properly in the
middle of the file.

show more ...

Remove yearly range from copyright notice

Implement typed properties

RFC: https://wiki.php.net/rfc/typed_properties_v2

This is a squash of PR #3734, which is a squash of PR #3313.

Co-authored-by: Bob Weinand <bobwe

Implement typed properties

RFC: https://wiki.php.net/rfc/typed_properties_v2

This is a squash of PR #3734, which is a squash of PR #3313.

Co-authored-by: Bob Weinand <bobwei9@hotmail.com>
Co-authored-by: Joe Watkins <krakjoe@php.net>
Co-authored-by: Dmitry Stogov <dmitry@zend.com>

show more ...

Future-proof email addresses

Future-proof email addresses...

Remove IS_EXT_MODULE defines

I'm not sure what this was used for, but it doesn't look to be
relevant anymore.

Use variables that already received ZEND_NUM_ARGS()

Fixed incorrrecr zval_dtor() usage to replace value of argument passed by reference, that may lead to memory leaks.

Replace legacy zval_dtor() by zval_ptr_dtor_nogc() or even more specialized destructors.
zval_dtor() doesn't make a lot of sense in PHP-7.* and it's used incorrectly in some places.
Its occur

Replace legacy zval_dtor() by zval_ptr_dtor_nogc() or even more specialized destructors.
zval_dtor() doesn't make a lot of sense in PHP-7.* and it's used incorrectly in some places.
Its occurances should be replaced by zval_ptr_dtor() or zval_ptr_dtor_nogc(), or even more specialized destructors.

show more ...

Normalize the ldap extension version in phpinfo output

This patch normalizes the phpinfo output for the ldap extension and
removes the displayed Git attribute ident blob object name.