Use ICU's CXXFLAGS when using pkg-config

This mirrors how ICU's CXXFLAGS are already used when using icu-config.

Add "-pthread" to EXTRA_LDFLAGS_PROGRAM as well

This is a backport of c518932c0326a938f0fd0254f2adb03b1cddfbca
from the PHP 7.4 branch.

Fix pkg-config version constraint for ICU

On PHP 7.2 our minimum ICU version is 4.0, not 40.

Consider phpdbg as cli

* When configuring extensions, considers the PHPDBG SAPI as CLI thus
allowing e.g. to have the pcntl extension available within PHPDBG.

Signed-off-by: S

Consider phpdbg as cli

* When configuring extensions, considers the PHPDBG SAPI as CLI thus
allowing e.g. to have the pcntl extension available within PHPDBG.

Signed-off-by: Samuele Kaplun <kaplun@protonmail.com>

show more ...

Fix shared module generation on AIX bug #77676

Makefiles for PHP extensions generated by phpize expect the PHP_MODULES
to contain a list of libtool .la files so that it can read the $dln

Fix shared module generation on AIX bug #77676

Makefiles for PHP extensions generated by phpize expect the PHP_MODULES
to contain a list of libtool .la files so that it can read the $dlname
variable from them by sourcing them in to a shell. On AIX, the code was
setting PHP_MODULES to a list of .so files, which meant the dlname was
blank, preventing the tests from being able to run.

Change the AIX code path in the PHP_SHARED_MODULE macro to match the
output on other platforms, using libtool .la files.

show more ...

Use pkg-config for ICU, as the old icu-config has been deprecated

Use pkg-config for ICU, as the old icu-config has been deprecated

Trim trailing whitespace in source code files

Trim trailing whitespace in source code files

Rename var

Fixed bug #76153 Intl compilation fails with icu4c 61.1

Additionally, ICU >= 59.1 requires C++11, so add the flags. Some
refactoring is needed to comply with the latest recommended build

Fixed bug #76153 Intl compilation fails with icu4c 61.1

Additionally, ICU >= 59.1 requires C++11, so add the flags. Some
refactoring is needed to comply with the latest recommended build
options, such as automatic icu namespace addition.

show more ...

Fixed bug #75722: Rework valgrind detection

As described in bug report #75722, the configure script (acinclude.m4)
currently searches for the valgrind header file and enables valgrind

Fixed bug #75722: Rework valgrind detection

As described in bug report #75722, the configure script (acinclude.m4)
currently searches for the valgrind header file and enables valgrind
support if found.

When cross-compiling the searched paths are invalid for the target
platform because they belong to the host system. At the moment, there is
no way to tell the build system a dedicated path where to look for the
header file.

This leads to the issue, that when cross-compiling eg. for ARMv5 platform,
that valgrind header file is detected - e.g. because host system is amd64 -
and support is enabled - but target platform will never support valgrind
(valgrind requires e.g. at least ARMv7).

This change reworks the detection so that user could manually opt-in
valgrind support and optionally specify a directory where the build system
should look for the header file using the --with-valgrind option.

show more ...

Fixes bug #75871 Use pkg-config for libxml2 if available

Fix bug #74905

Fix configure error

This patch fixes configure error on some systems such as Alpine.

```
line 3472: test: =: unary operator expected
```

One of the fixes has been

Fix configure error

This patch fixes configure error on some systems such as Alpine.

```
line 3472: test: =: unary operator expected
```

One of the fixes has been suggested also here already:
https://bugs.php.net/bug.php?id=39835

Thank you for considering merging this.

show more ...

Exclude warm-up requests from callgrind profile.

Add OpenSSL 1.1.0 support to PHP 7.0

report about OpenSSL 1.1 not supported during configure

Prevent fd leak in readdir_r that causes false negative on readdir_r implementation when compiled with AddressSanitizer

fix bad merge

fix build broken by #2124

fix acinclude, messed up by bad merge #2124

fix broken build scripts #2124

acinclude.m4: fix krb5-config detection and usage in PHP_SETUP_KERBEROS.

When building with kerberos support (--with-kerberos), a few libraries
and flags need to be added to various part

acinclude.m4: fix krb5-config detection and usage in PHP_SETUP_KERBEROS.

When building with kerberos support (--with-kerberos), a few libraries
and flags need to be added to various parts of the build system. The
most reliable way to get those flags is through the krb5-config
program that ships with both major implementations of kerberos. The
PHP_SETUP_KERBEROS macro in acinclude.m4 attempts to detect
krb5-config, and use it.

However, there's a bug in that macro. The --with-kerberos parameter
accepts a directory where the kerberos libraries can be found. When a
directory is given, it is stored in the PHP_KERBEROS variable. The
following test,

if test "$PHP_KERBEROS" = "yes" && test -x "$KRB5_CONFIG"; then

thus fails whenever a directory is passed to --with-kerberos, since it
compares a directory name against the string "yes". This causes
krb5-config to go unused, and some unreliable fallback logic is
attempted instead. One consequence of this is that the Heimdal
kerberos implementation cannot be substituted for the MIT one, at
least when a directory is passed to --with-kerberos.

This commit reverses the logic and checks for "$PHP_KERBEROS" != "no".
To confirm that this fixes the issue, one can inspect the "-l" library
flags that get appended to the command-line. On a machine with Heimdal
and the unmodified acinclude.m4, running

./configure --with-openssl --with-kerberos=/usr

will log (for example) to config.log,

configure:18082: checking for krb5-config
configure:18101: found /usr/bin/krb5-config
configure:18114: result: /usr/bin/krb5-config
configure:18450: checking for RAND_egd
configure:18450: cc ... conftest.c ... -lgssapi_krb5 -lkrb5 ...

which are the library names for the MIT implementation. After patching
acinclude.m4 to negate the logic, the same command on the same machine
outputs (to config.log):

configure:18450: cc ... conftest.c -lgssapi -lheimntlm ...

These are the correct library names for the Heimdal implementation.

PHP-Bug: 73214

show more ...

fix #72180, #73219