Fix leak of accel_shared_globals for file_cache_only (GH-16517)

If `opcache.file_cache_only` is enabled, `accel_shared_globals` is
allocated as true global, and we need to free that memo

Fix leak of accel_shared_globals for file_cache_only (GH-16517)

If `opcache.file_cache_only` is enabled, `accel_shared_globals` is
allocated as true global, and we need to free that memory when we shut
down the accelerator.

show more ...

Merge branch 'PHP-8.4'

* PHP-8.4:
Free internal_runtime_cache on shutdown for NTS

Free internal_runtime_cache on shutdown for NTS

As is, the `internal_runtime_cache` is only free for ZTS builds; we
also free it for NTS builds on shutdown.

Co-authored-by: Bob

Free internal_runtime_cache on shutdown for NTS

As is, the `internal_runtime_cache` is only free for ZTS builds; we
also free it for NTS builds on shutdown.

Co-authored-by: Bob Weinand <bobwei9@hotmail.com>

Closes GH-16402.

show more ...

Merge branch 'PHP-8.4'

* PHP-8.4:
Fix GH-16390: dba_open() can segfault for "pathless" streams

Merge branch 'PHP-8.3' into PHP-8.4

* PHP-8.3:
Fix GH-16390: dba_open() can segfault for "pathless" streams

Merge branch 'PHP-8.2' into PHP-8.3

* PHP-8.2:
Fix GH-16390: dba_open() can segfault for "pathless" streams

Fix GH-16390: dba_open() can segfault for "pathless" streams

`dba_open()` accepts arbitrary stream wrapper paths, but unless no
locking (`-`) is specified, we try to determine the underl

Fix GH-16390: dba_open() can segfault for "pathless" streams

`dba_open()` accepts arbitrary stream wrapper paths, but unless no
locking (`-`) is specified, we try to determine the underlying file
path. If that fails, we need to error out.

Closes GH-16498.

show more ...

Merge branch 'PHP-8.4'

Merge branch 'PHP-8.3' into PHP-8.4

Merge branch 'PHP-8.2' into PHP-8.3

Fix GH-16501: gmp_random_bits overflow.

we do the same calculation in advance as mpz_realloc overflow check to
avoid abort.

close GH-16503

Merge branch 'PHP-8.4'

* PHP-8.4:
Fix GH-16414: zend_test.observer.observe_function_names may segfault

Fix GH-16414: zend_test.observer.observe_function_names may segfault

Unless `zend_test.observer.enabled` is on, we must not add observer
handlers, so we let the INI modify handler fail e

Fix GH-16414: zend_test.observer.observe_function_names may segfault

Unless `zend_test.observer.enabled` is on, we must not add observer
handlers, so we let the INI modify handler fail early.

We also need to ensure that the functions to observe have already been
called, so that their begin and end handlers are properly initialized.
Otherwise we will not observe the function execution, but a segfault.

Co-authored-by: Bob Weinand <bobwei9@hotmail.com>

Closes GH-16438.

show more ...

Fix Windows x86 build for ext/ffi

PR #16351 introduced `EnumProcessModules()` calls, but this function is
undefined; thus, the compiler mangles the name according to the default
call

Fix Windows x86 build for ext/ffi

PR #16351 introduced `EnumProcessModules()` calls, but this function is
undefined; thus, the compiler mangles the name according to the default
calling convention. This lets linking succeed for x64, but fail for
x86.

To properly fix this, we include <Psapi.h> where the function is
declared.

show more ...

Drop legacy fallback for `isc_get_client_version()` (GH-16343)

The respective code had been introduced 20 years ago, and we can assume
that the function is available at least of Firebird

Drop legacy fallback for `isc_get_client_version()` (GH-16343)

The respective code had been introduced 20 years ago, and we can assume
that the function is available at least of Firebird 3.0, what we
require anyway.

show more ...

FFI: support symbol lookup without specifying lib on Windows

This works similar to `dlsym(RTLD_DEFAULT, …)` with the caveat that
symbols on Windows may not be unique, and are usually qua

FFI: support symbol lookup without specifying lib on Windows

This works similar to `dlsym(RTLD_DEFAULT, …)` with the caveat that
symbols on Windows may not be unique, and are usually qualified by the
module they are exported from. That means that wrong symbols may be
fetched, potentially causing serious issues; therefore this usage is
not recommended for production purposes, but is a nice simplification
for quick experiments and the ext/ffi test suite.

Closes GH-16351.

show more ...

Move ARG_ENABLE() "macros" out of confutils.js (GH-16398)

While these "macros" work perfectly fine in confutils, it is somewhat
strange to have these two there, while all others are in c

Move ARG_ENABLE() "macros" out of confutils.js (GH-16398)

While these "macros" work perfectly fine in confutils, it is somewhat
strange to have these two there, while all others are in config.w32
files.

In particular, there is no need for a `MODE_PHPIZE` guard, since there
are already config.w32 and config.w32.phpize.in.

However, we need to replace the semicolon in the helptext, because the
regex which parses ARG_(ENABLE|WITH) calls is restricted, and does not
accept semicolons.

show more ...

[skip ci] Fix test expectation for Windows

No clue why the line reports 0 on Windows...

GH-16315: Improve error messages when extending enums

Closes GH-16491

Merge branch 'PHP-8.4'

* PHP-8.4:
[skip ci] Mark another phar test as flaky on macOS

Merge branch 'PHP-8.3' into PHP-8.4

* PHP-8.3:
[skip ci] Mark another phar test as flaky on macOS

Merge branch 'PHP-8.2' into PHP-8.3

* PHP-8.2:
[skip ci] Mark another phar test as flaky on macOS

[skip ci] Mark another phar test as flaky on macOS

Merge branch 'PHP-8.4'

Merge branch 'PHP-8.3' into PHP-8.4