ext/standard/crypt.c: handle musl failure tokens

Musl's crypt() returns "*" to indicate failure in contrast with the
"*0" returned by PHP/libxcrypt. This causes test failures, but more

ext/standard/crypt.c: handle musl failure tokens

Musl's crypt() returns "*" to indicate failure in contrast with the
"*0" returned by PHP/libxcrypt. This causes test failures, but more
importantly, is a pretty silly thing to expect the user to know.
This commit catches the musl value and turns it into "*0".

show more ...

ext/standard/tests/crypt/des_fallback_invalid_salt.phpt: less valid salt

Musl's crypt() implementation of DES tries to handle invalid salts and
can make this test fail because it returns

ext/standard/tests/crypt/des_fallback_invalid_salt.phpt: less valid salt

Musl's crypt() implementation of DES tries to handle invalid salts and
can make this test fail because it returns an answer and not an
error. Even musl however will reject a salt with a ':' in it, so we
can make this test cross-platform by supplying an even less valid
salt.

show more ...

ext/standard/tests/strings/crypt_sha256.phpt: fix on musl

Among other things, this test tries to run too few and too many rounds
of SHA256. In both cases, it is expecting an error, but t

ext/standard/tests/strings/crypt_sha256.phpt: fix on musl

Among other things, this test tries to run too few and too many rounds
of SHA256. In both cases, it is expecting an error, but that behavior
depends on the implementation:

* PHP's own implementation raises an error in either case
* libxcrypt raises an error in either case
* Older versions of glibc would clamp the number of rounds
to a valid amount (newer versions don't have libcrypt)
* Musl libc clamps values that are too low, but raises an error
for values that are too high

If PHP is built with --with-external-libcrypt, the musl implementation
above can be used. Even if libxcrypt is installed, PHP will notice
that no additional -lfoo flags are needed to use the crypt
implementation in musl. To pass on such a system, we must not test
for the "too few rounds" behavior.

show more ...

Fix incorrect filename of dl()'d internal consts (#16721)

We should only attempt to fetch the current filename for user constants. dl()
may attempt to register internal constants after e

Fix incorrect filename of dl()'d internal consts (#16721)

We should only attempt to fetch the current filename for user constants. dl()
may attempt to register internal constants after execution has already started,
thus incorrectly linking the user file invoking dl().

See GH-16663

show more ...

Fix GH-10992: Improper long path support for relative paths

Relative paths are passed to the ioutils APIs, these are not properly
converted to long paths. If the path length already exc

Fix GH-10992: Improper long path support for relative paths

Relative paths are passed to the ioutils APIs, these are not properly
converted to long paths. If the path length already exceeds a given
threshold (usually 259 characters, but only 247 for `mkdir()`), the
long path prefix is prepended, resulting in an invalid path, since long
paths have to be absolute. If the path length does not exceed that
threshold, no conversion to a long path is done, although that may be
necessary.

Thus we take the path length of the current working directory into
account when checking the threshold, and prepend it to the filename if
necessary.

Since this is only relevant for NTS builds, and using the current
working directory of the process would be erroneous for ZTS builds, we
skip the new code for ZTS builds.

Closes GH-16687.

show more ...

Merge branch 'PHP-8.4'

* PHP-8.4:
Skip tests if ldap_set_rebind_proc() is not available

Merge branch 'PHP-8.3' into PHP-8.4

* PHP-8.3:
Skip tests if ldap_set_rebind_proc() is not available

Merge branch 'PHP-8.2' into PHP-8.3

* PHP-8.2:
Skip tests if ldap_set_rebind_proc() is not available

Skip tests if ldap_set_rebind_proc() is not available

This is already done by ldap_set_rebind_proc_error.phpt, but not by the
other two affected tests.

Closes GH-16708.

Fix GH-16665: \array and \callable should not be usable

This list was initially introduced in 53a40386, but never included array or
callable. I suppose this is because int & friends are

Fix GH-16665: \array and \callable should not be usable

This list was initially introduced in 53a40386, but never included array or
callable. I suppose this is because int & friends are not actual tokens,
while array and callable are. This means it was never possible to do class
array, which is probably the reason this was overlooked.

Closes GH-16683.

show more ...

Get rid of reserved name usage in ext/libxml (#16707)

Names starting with an _ are reserved in C.

Use unsigned int for the reference count APIs in ext/libxml (#16706)

Also removes impossible conditions.

Merge branch 'PHP-8.4'

Merge branch 'PHP-8.3' into PHP-8.4

Merge branch 'PHP-8.2' into PHP-8.3

Fix GH-16235 jdtogregorian overflow

close GH-16242

Merge branch 'PHP-8.4'

* PHP-8.4:
Fixed the test because libmysql results type is string. (#16709)

Fixed the test because libmysql results type is string. (#16709)

closes #16709

Merge branch 'PHP-8.4'

* PHP-8.4:
Added gc_handler to properly handle circular references. (#16703)

Merge branch 'PHP-8.3' into PHP-8.4

* PHP-8.3:
Added gc_handler to properly handle circular references. (#16703)

Merge branch 'PHP-8.2' into PHP-8.3

* PHP-8.2:
Added gc_handler to properly handle circular references. (#16703)

Added gc_handler to properly handle circular references. (#16703)

closes #16703

Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>

Merge branch 'PHP-8.4'

* PHP-8.4:
Fix test with shared zend_test (#16705)

Merge branch 'PHP-8.3' into PHP-8.4

* PHP-8.3:
Fix test with shared zend_test (#16705)

Merge branch 'PHP-8.2' into PHP-8.3

* PHP-8.2:
Fix test with shared zend_test (#16705)