fix new pgsql test

Merge branch 'PHP-8.4'

Merge branch 'PHP-8.3' into PHP-8.4

ext/pgsql fixing further calls with flexible arguments number.

continuation of GH-17161

close GH-17165

Merge branch 'PHP-8.4'

* PHP-8.4:
Fix GH-17137: Segmentation fault ext/phar/phar.c

Merge branch 'PHP-8.3' into PHP-8.4

* PHP-8.3:
Fix GH-17137: Segmentation fault ext/phar/phar.c

Fix GH-17137: Segmentation fault ext/phar/phar.c

Commit edae2431 attempted to fix a leak and double free, but didn't
properly understand what was going on, causing a reference count mist

Fix GH-17137: Segmentation fault ext/phar/phar.c

Commit edae2431 attempted to fix a leak and double free, but didn't
properly understand what was going on, causing a reference count mistake
and subsequent segfault in this case.

The first mistake of that commit is that the reference count should've
been increased because we're reusing a phar object. The error handling
path should've gotten changed instead to undo this refcount increase
instead of not refcounting at all (root cause of this bug).

The second mistake is that the alias isn't supposed to be transferred or
whatever, that just doesn't make sense. The reason the test
bug69958.phpt originally leaked is because in the non-reuse case we
borrowed the alias and otherwise we own the alias. If we own the alias
the alias information shouldn't get deleted anyway as that would desync
the alias map.

Fixing these will reveal a third issue in which the alias memory is not
always properly in sync with the persistence-ness of the phar, fix this
as well.

Closes GH-17150.

show more ...

Merge branch 'PHP-8.4'

* PHP-8.4:
Don't run proc_open_cmd.phpt in parallel with other tests

Merge branch 'PHP-8.3' into PHP-8.4

* PHP-8.3:
Don't run proc_open_cmd.phpt in parallel with other tests

Don't run proc_open_cmd.phpt in parallel with other tests

This test puts a fake cmd.exe in the CWD and removes it only after the
test has finished. We need to avoid that other tests are

Don't run proc_open_cmd.phpt in parallel with other tests

This test puts a fake cmd.exe in the CWD and removes it only after the
test has finished. We need to avoid that other tests are running while
that fake cmd.exe is there, because they may use it instead of the
proper cmd.exe.

We also unlink the fake cmd.exe as soon as possible, regardless of the
test result.

Fixes GH-17098.
Closes GH-17090.

show more ...

Fail phpize early if config.w32 is missing (GH-17100)

On Windows, phpize happily builds configure even if there is no
config.w32, but running configure then error with "Must be run from

Fail phpize early if config.w32 is missing (GH-17100)

On Windows, phpize happily builds configure even if there is no
config.w32, but running configure then error with "Must be run from the
root of the extension source". This is confusing.

We bring phpize's behavior on par with POSIX systems, where the missing
config.m4 is detected and reported right away.

show more ...

Merge branch 'PHP-8.4'

* PHP-8.4:
Fix GH-17153: SimpleXML crash when using autovivification on document

Merge branch 'PHP-8.3' into PHP-8.4

* PHP-8.3:
Fix GH-17153: SimpleXML crash when using autovivification on document

Fix GH-17153: SimpleXML crash when using autovivification on document

In the case of a member string, `mynode` may also be a document, which
doesn't have a namespace.

Closes GH-

Fix GH-17153: SimpleXML crash when using autovivification on document

In the case of a member string, `mynode` may also be a document, which
doesn't have a namespace.

Closes GH-17156.

show more ...

Merge branch 'PHP-8.4'

* PHP-8.4:
Fix GH-17158: pg_fetch_result Shows Incorrect ArgumentCountError Message when Called With 1 Argument

Merge branch 'PHP-8.3' into PHP-8.4

* PHP-8.3:
Fix GH-17158: pg_fetch_result Shows Incorrect ArgumentCountError Message when Called With 1 Argument

Fix GH-17158: pg_fetch_result Shows Incorrect ArgumentCountError Message when Called With 1 Argument

Closes GH-17161.

Merge branch 'PHP-8.4'

Merge branch 'PHP-8.3' into PHP-8.4

Fix GH-13437: FPM: ERROR: scoreboard: failed to lock (already locked)

This changes locking for scoreboard to reduce contention between readers
and adds retries for acquiring scoreboard f

Fix GH-13437: FPM: ERROR: scoreboard: failed to lock (already locked)

This changes locking for scoreboard to reduce contention between readers
and adds retries for acquiring scoreboard for read.

Closes GH-15805

show more ...

Merge branch 'PHP-8.4'

* PHP-8.4:
Fix GH-17145: DOM memory leak

Fix GH-17145: DOM memory leak

Because the use of RETURN instead of RETVAL, the freeing code could not
be executed. This only is triggerable if the content of the attribute is
mixed t

Fix GH-17145: DOM memory leak

Because the use of RETURN instead of RETVAL, the freeing code could not
be executed. This only is triggerable if the content of the attribute is
mixed text and entities, so it wasn't noticed earlier.

Closes GH-17147.

show more ...

Fix curl_multi_exec() overflow message (GH-17078)

As is, passing `2147484` as `$timeout`, throws a `ValueError` stating
the `$timeout` needs to be between 0 and 2147484, what is a confus

Fix curl_multi_exec() overflow message (GH-17078)

As is, passing `2147484` as `$timeout`, throws a `ValueError` stating
the `$timeout` needs to be between 0 and 2147484, what is a confusing.
Thus we report the proper threshold as float.

While we're at it we also drop the superfluous `(double)` cast, and
rely on C's usual arithmetic conversions.

show more ...

Skip sapi_windows_set_ctrl_handler.phpt under ASan

For some reason, terminating the child process by sending CTRL+C won't
work under ASan instrumentation. Since termination via CTRL+BRE

Skip sapi_windows_set_ctrl_handler.phpt under ASan

For some reason, terminating the child process by sending CTRL+C won't
work under ASan instrumentation. Since termination via CTRL+BREAK
works, there is apparently nothing fundamentally wrong, so we just
skip the test.

Closes GH-17086.

show more ...

Merge branch 'PHP-8.4'

* PHP-8.4:
Fix GH-15709: Crashing tests on Windows x64 (#17095)