Fix -Wundef/C4668 warnings (#15853)

- ZTS is either undefined or defined (to 1)
- PHP_WIN32 is either undefined or defined (to 1)
- HAVE_LIBEDIT is either undefined or defined (to 1)

gai_strerror() is not thread-safe on Windows (GH-15568)

First we refactor to have only a single usage of `PHP_GAI_STRERROR()`
left; then we drop the macro in favor of calling the differe

gai_strerror() is not thread-safe on Windows (GH-15568)

First we refactor to have only a single usage of `PHP_GAI_STRERROR()`
left; then we drop the macro in favor of calling the different
functions conditionally in an ad-hoc style.

This is necessary because the return value of `php_win32_error_to_msg`
needs to be freed by the caller.

The error messages are no more inline with other error messages, since
`gai_strerror()` apparently always appends a period and a space.

We also properly configure IPv4/v6 on Windows. Since WSPiApi.h has been
created in 2000, so we can safely assume that it is available everywhere
nowadays. Furthermore, `gai_strerror()` is available regardless of
whether there is IPv6 support.

show more ...

Fix GH-15565: --disable-ipv6 during compilation produces error EAI_SYSTEM not found

Closes GH-15567.

main/network: Use more appropriate types (#15511)

* main/network: Use more appropriate types

And check directly against 0 for success for functions not returning a zend_result

main/network: Use more appropriate types (#15511)

* main/network: Use more appropriate types

And check directly against 0 for success for functions not returning a zend_result

* Remove redundant declaration in file.h

Not sure why it even is here

show more ...

Fix uninitialized memory in network.c

See https://github.com/php/php-src/issues/14806#issuecomment-2208150509
and https://github.com/php/php-src/issues/14806#issuecomment-2208690481

Fix uninitialized memory in network.c

See https://github.com/php/php-src/issues/14806#issuecomment-2208150509
and https://github.com/php/php-src/issues/14806#issuecomment-2208690481

Closes GH-15068.

show more ...

Sync #if/ifdef/defined (#14508)

This syncs CPP macro conditions:
- _WIN32
- _WIN64
- HAVE_ALLOCA_H
- HAVE_ALPHASORT
- HAVE_ARPA_INET_H
- HAVE_CONFIG_H
- HAVE_DIRE

Sync #if/ifdef/defined (#14508)

This syncs CPP macro conditions:
- _WIN32
- _WIN64
- HAVE_ALLOCA_H
- HAVE_ALPHASORT
- HAVE_ARPA_INET_H
- HAVE_CONFIG_H
- HAVE_DIRENT_H
- HAVE_DLFCN_H
- HAVE_GETTIMEOFDAY
- HAVE_LIBDL
- HAVE_POLL_H
- HAVE_PWD_H
- HAVE_SCANDIR
- HAVE_SYS_FILE_H
- HAVE_SYS_PARAM_H
- HAVE_SYS_SOCKET_H
- HAVE_SYS_TIME_H
- HAVE_SYS_TYPES_H
- HAVE_SYS_WAIT_H
- HAVE_UNISTD_H
- PHP_WIN32
- ZEND_WIN32

These are either undefined or defined to 1 in Autotools and Windows.

Follow up of GH-5526 (-Wundef).

show more ...

Sync HAVE_IPV6 and HAVE_GETADDRINFO in #if/ifdef/defined (#14341)

Follow up of GH-5526 (-Wundef)

Mark multple functions as static (#13864)

* Mark many functions as static

Multiple functions are missing the static qualifier.

* remove unused struct sigactions

st

Mark multple functions as static (#13864)

* Mark many functions as static

Multiple functions are missing the static qualifier.

* remove unused struct sigactions

struct sigaction act, old_term, old_quit, old_int;
all unused.

* optimizer: minXOR and maxXOR are unused

show more ...

Remove inet_aton

This removes the deprecated inet_aton and its Windows implementation.
The inet_aton can be replaced with platform agnostic inet_pton.

Closes GH-13479

Remove HAVE_INET_PTON (#13410)

inet_ntop requirement check at configure time instead (#12700)

following-up on GH-12551: removing inet_ntoa usage

Close GH-12554

Fix GH-12190: stream_context_create with address and port at 0.

Prior to the 8.1 rewrite, inet_aton was used for ipv4 addresses
therefore addresses like `0` passed.
For the bindto's

Fix GH-12190: stream_context_create with address and port at 0.

Prior to the 8.1 rewrite, inet_aton was used for ipv4 addresses
therefore addresses like `0` passed.
For the bindto's case where both ip and port are set as such, we discard
the address binding.

Close GH-12195

show more ...

[skip ci] Fix various typos and grammar issues (#11143)

Return immediately when FD_SETSIZE is exceeded (#9602)

Update bug tracker links

The new php-src bugtracker is on Github.

Closes GH-8277.

Fix whitespaces

main: set IP_BIND_ADDRESS_NO_PORT if available when connecting to remote host

When you choose to bind() to a local address and connect to a remote host
the kernel does not know if socket

main: set IP_BIND_ADDRESS_NO_PORT if available when connecting to remote host

When you choose to bind() to a local address and connect to a remote host
the kernel does not know if socket is listener or whatnot and has to reserve
a port within a ~32k range on which you are also competing with other
applications bound to the same address, this is easy to exhaust and get a
EADDRINUSE.
The linux kernel implemented IP_BIND_ADDRESS_NO_PORT on
https://github.com/torvalds/linux/commit/90c337da1524863838658078ec34241f45d8394d
which delays the port allocation until the 4-tuple is known in case source port
is 0.

show more ...

Fix 'can not' in test data and in code comments

Remove unnecessary sockaddr memory allocation (#7219)

The size of sockaddr_in and sockaddr_in6 is known on compile-time and it is not that big for the stack.
Also optimized the code.

Fixed some spaces used instead of tabs

Add host for php_network_getaddresses getaddrinfo failed error message. (#7181)

get rid of inet_aton and inet_ntoa use inet_ntop iand inet_pton where available standardize buffer size

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Merge branch 'PHP-7.4' into master

* PHP-7.4:
Fix #80067: Omitting the port in bindto setting errors