Don't use UNREFs during array operations

Perform DEREFs instead. We were already doing this in some, but not
all places.

While UNREFs are supposed to be transparent, in practice

Don't use UNREFs during array operations

Perform DEREFs instead. We were already doing this in some, but not
all places.

While UNREFs are supposed to be transparent, in practice they have
rare observable side effects. Calling array_merge() on an array
should never change how that array behaves.

show more ...

Merge branch 'PHP-7.2'

* PHP-7.2:
Fixed bug #76410 (SIGV in zend_mm_alloc_small)
Fix bug #76390 - do not allow invalid strings in range()

Conflicts:
ext/stan

Merge branch 'PHP-7.2'

* PHP-7.2:
Fixed bug #76410 (SIGV in zend_mm_alloc_small)
Fix bug #76390 - do not allow invalid strings in range()

Conflicts:
ext/standard/array.c

show more ...

Fixed bug #76410 (SIGV in zend_mm_alloc_small)

Fix bug #76390 - do not allow invalid strings in range()

Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
Fix bug #76390 - do not allow invalid strings in range()

Fix bug #76390 - do not allow invalid strings in range()

Avoid rehashing of "packed" array

Merge branch 'PHP-7.2'

* PHP-7.2:
Translate correct C++ version with suitable compiler
Fixed bug #76383 (array_map on $GLOBALS returns IS_INDIRECT)

Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
Translate correct C++ version with suitable compiler
Fixed bug #76383 (array_map on $GLOBALS returns IS_INDIRECT)

Use zend_string_release_ex() instread of zend_string_release() in places, where we sure about string persistence.

Fixed bug #76383 (array_map on $GLOBALS returns IS_INDIRECT)

Bit test optimization

Bit check micro-optimization

Merge branch 'PHP-7.2'

* PHP-7.2:
Fix arginfo for array_replace(_recursive) and array_merge(_recursive)

Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
Fix arginfo for array_replace(_recursive) and array_merge(_recursive)

Fix arginfo for array_replace(_recursive) and array_merge(_recursive)

Remove redundant warning in array_push() and array_unshift()

Cf. https://github.com/php/php-src/pull/3011.

Optimize zend_hash_real_init()

Fixed expectation

Improve HashTable iterators handling:
- Avoid iterators check/update on each HashTable update opration
- Keep position equal (or above) nNumUsed instead of HT_INVALID_IDX
- Fixed iterator

Improve HashTable iterators handling:
- Avoid iterators check/update on each HashTable update opration
- Keep position equal (or above) nNumUsed instead of HT_INVALID_IDX
- Fixed iterators handling in array_unshift()

show more ...

Use const pointers

Remove unused assignment

Merge branch 'PHP-7.2'

Merge branch 'PHP-7.1' into PHP-7.2

Revert "Fixed bug #75961 (Strange references behavior)"

This reverts commit 94e9d0a2ae76bad712495d820d3962e401085fef.

This code needs to be mindful about modifications to the array

Revert "Fixed bug #75961 (Strange references behavior)"

This reverts commit 94e9d0a2ae76bad712495d820d3962e401085fef.

This code needs to be mindful about modifications to the array
happening during callback execution. It was written in a way that
only accessed the reference, which is guaranteed not to move. The
changed implementation instead accesses the array slot, leading to
use-after-free.

Run ext/standard/tests/array/bug61967.phpt under valgrind to see
the issue.

show more ...