Add ZVAL_OBJ_COPY macro

For the common ZVAL_OBJ + GC_ADDREF pattern.
This mirrors the existing ZVAL_STR_COPY API.

Add helper APIs for maybe-interned string creation

Add ZVAL_CHAR/RETVAL_CHAR/RETURN_CHAR as a shortcut for using
ZVAL_INTERNED_STRING and ZSTR_CHAR.

Add zend_string_init_fast()

Add helper APIs for maybe-interned string creation

Add ZVAL_CHAR/RETVAL_CHAR/RETURN_CHAR as a shortcut for using
ZVAL_INTERNED_STRING and ZSTR_CHAR.

Add zend_string_init_fast() as a helper for the empty string /
one char interned string / zend_string_init() pattern.

Also add corresponding ZVAL_STRINGL_FAST etc macros.

Closes GH-5684.

show more ...

Fix expression warnings and break warnings

Close GH-5675.

in_array() avoid internal property access as we have the arrlen already

Closes GH-5662

Allow null callback to array_filter()

With same behavior as not passing it.

Use standard key behavior in array_column()

array_column() reimplements array key handling in a way that does
not match standard array key behavior in PHP. Avoid this by making
use o

Use standard key behavior in array_column()

array_column() reimplements array key handling in a way that does
not match standard array key behavior in PHP. Avoid this by making
use of the standard API.

Of course, there is a minor backwards compatibilty break here,
e.g. people could be relying on objects getting cast to string
instead of throwing.

Closes GH-5487.

show more ...

Use ZPP check for string|int|null arguments in array_column()

Remove dead code

As pointed out by Girgias, index is always non-NULL here.

Improve a last couple of argument error messages

Closes GH-5404

Improve some TypeError and ValueError messages

Closes GH-5377

Improve some ValueError messages

Closes GH-5340

Improve undefined variable error messages

Closes GH-5312

Improve argument error messages in ext/standard

Closes GH-5198

Use separate typedef for bucket comparison function

Avoid performing the same casting dance inside each sort compare
function.

Add ValueError for invalid mode in count()

Closes GH-5106

Fix double free in array_reduce

return_value needs to be explicitly nulled out in the failure case.

Remove unnecessary result variable

Instead directly use return_value. Hopefully this also works
around the "may be uninitialized" warning...

Eliminate uses of ZVAL_ZVAL and friends

Instead add RETURN_COPY(_VALUE) macros will the expected behavior.

RETURN_ZVAL doesn't make any sense since PHP 7, but has stuck
around,

Eliminate uses of ZVAL_ZVAL and friends

Instead add RETURN_COPY(_VALUE) macros will the expected behavior.

RETURN_ZVAL doesn't make any sense since PHP 7, but has stuck
around, probably because the alternative was to write directly to
the return_value variable.

show more ...

Make error messages more consistent by fixing capitalization

Closes GH-5066 As a first step, let's capitalize their initial letter when it is applicable.

Use RETURN_THROWS() in various places

Use RETURN_THROWS() after zend_throw_exception() in most of the extensions

Use RETURN_THROWS() after zend_throw_error()

Use RETURN_THROWS() after zend_type_error()

Use RETURN_THROWS() after zend_value_error()

Use RETURN_THROWS() when an exception is thrown

Closes GH-5036