Simplify iconv_strpos implementation

Use a separate "reverse" flag to determine search direction,
using offset == -1 to indicate this is is confusing. I initially
thought the code wa

Simplify iconv_strpos implementation

Use a separate "reverse" flag to determine search direction,
using offset == -1 to indicate this is is confusing. I initially
thought the code was trying to handle negative offsets.

Also deduplicate the forward and reverse cases, they really only differ
in one place.

show more ...

Throw warning for invalid iconv charset

Normalize substr() behavior

Make the behavior of substr(), mb_substr(), iconv_substr() and
grapheme_substr() consistent when it comes to the handling of
out of bounds offsets. substr

Normalize substr() behavior

Make the behavior of substr(), mb_substr(), iconv_substr() and
grapheme_substr() consistent when it comes to the handling of
out of bounds offsets. substr() will now always clamp out of
bounds offsets to the string boundary. Cases that previously
returned false will now return an empty string. This means that
substr() itself *always* returns a string now (like mb_substr()
already did before.)

Closes GH-6182.

show more ...

Add "const". Move constant strings to read-only memory.

Remove PHP_ICONV_H_PATH

Directly include <iconv.h> instead, now that the giconv.h
distinction no longer exists.

Remove proto comments from C files

Closes GH-5758

Fix [-Wundef] warning in Iconv extension

Fix UNKNOWN default values in various extensions

Closes GH-5514

Generate functions entries from stubs for another set of extensions

Closes GH-5351

Merge branch 'PHP-7.4'

* PHP-7.4:
Fix #79200: Some iconv functions cut Windows-1258

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fix #79200: Some iconv functions cut Windows-1258

Fix #79200: Some iconv functions cut Windows-1258

To cater to potentially state-dependent encodings, we have to reset the
conversion descriptor into its initial shift state to properly f

Fix #79200: Some iconv functions cut Windows-1258

To cater to potentially state-dependent encodings, we have to reset the
conversion descriptor into its initial shift state to properly finish
the conversion. Furthermore, state-dependent encodings may not show
progress when comparing `in_left` before and after the conversion; we
rather have to see whether `out_left` has decreased. Also we have to
cater to the fact that the final potentially state resetting call does
not signal failure, but we still have to break respective loops
afterwards.

show more ...

Drop support for iconv without proper errno setting

It is hard to impossible to work around iconv() implementations which
do not properly set errno according to POSIX. We therefore do n

Drop support for iconv without proper errno setting

It is hard to impossible to work around iconv() implementations which
do not properly set errno according to POSIX. We therefore do no
longer allow to build against such iconv() implementations.

Co-Authored-By: Nikita Popov <nikita.ppv@googlemail.com>

show more ...

Remove unnecessary condition as always true.

ZSTR_LEN(str) is an unsigned integer therefor it is always greater
or equal than 0.

Detected by -Wtype-limits compiler warning.

Use RETURN_THROWS() in various places

Use RETURN_THROWS() during ZPP in most of the extensions

Except for some bigger ones: reflection, sodium, spl

Accept null lengths for substr functions()

If a null $length is passed to any of these functions, behave as if no
parameter was passed:

- substr()
- substr_count()
-

Accept null lengths for substr functions()

If a null $length is passed to any of these functions, behave as if no
parameter was passed:

- substr()
- substr_count()
- substr_compare()
- iconv_substr()

show more ...

Merge branch 'PHP-7.4'

* PHP-7.4:
Fix #78642: Wrong libiconv version displayed

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fix #78642: Wrong libiconv version displayed

Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
Fix #78642: Wrong libiconv version displayed

Fix #78642: Wrong libiconv version displayed

The high byte of `_libiconv_version` specifies the major version; the
low byte the minor version.

Remove mention of PHP major version in Copyright headers

Closes GH-4732.

Don't explicitly set return value on ZPP failure in ext/iconv

Failing ZPP throws as of PHP 8.0.0, so explicitly setting a return
value is useless, and also slightly confusing.

Add ext/iconv stubs

Cheaper checks for exceptions thrown from __toString()