Fix GH-13712: Segmentation fault for enabled observers when calling trait method of internal trait when opcache is loaded (#13735)

Inherited methods regardless of source must share the origi

Fix GH-13712: Segmentation fault for enabled observers when calling trait method of internal trait when opcache is loaded (#13735)

Inherited methods regardless of source must share the original runtime cache. Traits were missed.
This adds ZEND_ACC_TRAIT_CLONE to internal functions as well to allow easy distinction of these.

show more ...

Fix GH-12019: ext/gd/config.m4: don't forget GDLIB_CFLAGS in feature tests

In commit 85e5635a, a feature test for the various libgd image formats
was added. That test however erroneously

Fix GH-12019: ext/gd/config.m4: don't forget GDLIB_CFLAGS in feature tests

In commit 85e5635a, a feature test for the various libgd image formats
was added. That test however erroneously omits the GDLIB_CFLAGS (from
pkg-config) during compilation. This can lead to build failures and
therefore false negatives from the test.

Here, we add $GDLIB_CFLAGS to $CFLAGS for the duration of the test.

Closes GH-12019

show more ...

Fix GH-13727: macro generating invalid call test prototypes fixes.

autoconf/libtool generating code to test features missed `void` for
C calls prototypes w/o arguments.
Note that spe

Fix GH-13727: macro generating invalid call test prototypes fixes.

autoconf/libtool generating code to test features missed `void` for
C calls prototypes w/o arguments.
Note that specific changes related to libtool have to be upstreamed.

Co-authored-by: Peter Kokot <petk@php.net>

close GH-13732

show more ...

ext/sockets: adding few constants for NetBSD.

SOCK_CONN_DGRAM (and its alias SOCK_DCCP) for connection orientated
datagram.

Close GH-13728

Fix GH-13685: Unexpected null pointer in zend_string.h

Regressed in 6fbf81c.

There is a missing error check on spl_filesystem_file_read_line(), which
means that if the line coul

Fix GH-13685: Unexpected null pointer in zend_string.h

Regressed in 6fbf81c.

There is a missing error check on spl_filesystem_file_read_line(), which
means that if the line could not be read (e.g. because we're at the end
of the file), it will not set intern->u.file.current_line, which will
cause a NULL pointer deref later on.

Fix it by adding a check, and reintroducing the silent flag partially to
be able to throw an exception like it did in the past.

Closes GH-13692.

show more ...

Fix potential memory leak in XPath evaluation results

ext/gettext: updating apis accepting domain behavior.

to be more in line with the proper usage ; normally domain should not
be empty strings.

Close GH-13691

random: Initialize the `mode` field when seeding in `php_random_default_status()` (#13690)

This is not just an issue due to missing initialization since moving the state
struct directly

random: Initialize the `mode` field when seeding in `php_random_default_status()` (#13690)

This is not just an issue due to missing initialization since moving the state
struct directly into the module globals. In earlier versions changing the mode
to `MT_RAND_PHP` within a single request would also affect the mode for
subsequent requests.

Original commit message follows:

This is a follow-up fix for GH-13579. The issue was detected in the nightly
MSAN build.

(cherry picked from commit bf0abd1629291c193064a9cb95a2da3565decc38)

show more ...

Fix GH-13680: Segfault with session_decode and compilation error

It's illegal to return from a bailout because that doesn't restore the
original bailout data. Return outside of it.

Fix GH-13680: Segfault with session_decode and compilation error

It's illegal to return from a bailout because that doesn't restore the
original bailout data. Return outside of it.

Test by YuanchengJiang

Closes GH-13689.

show more ...

Implement fcontext handling for sparc64_sysv_elf.

This was tested on OpenBSD sparc64 and all fiber related tests pass.
On OpenBSD stackghost prevents the modification of the return addre

Implement fcontext handling for sparc64_sysv_elf.

This was tested on OpenBSD sparc64 and all fiber related tests pass.
On OpenBSD stackghost prevents the modification of the return address
and therefor an extra trampoline is needed in make_fcontext(). This
should not matter on other OS implementing sysv ABI and the trampoline
should work there as well.

Close GH-13382.

show more ...

[ci skip] NEWS

[ci skip] NEWS

Add ZPP checks in DOMNode::{__sleep,__wakeup}

Closes GH-13651.

Fix GH-13203: file_put_contents fail on strings over 4GB on Windows

Closes GH-13205

Change return type of hash_update() to true (#13652)

It was already the case that this could only return true, update the
stubs to reflect that.

Closes GH-13614.

[RFC] Add a way to opt-in ext/dom spec compliance (#13031)

RFC: https://wiki.php.net/rfc/opt_in_dom_spec_compliance

Fix GH-11086: FPM: config test runs twice in daemonised mode

The previous check for STDERR did not work so this fixes it.

Closes GH-13357

NEWS

Implement GH-13609: Dump wrapped object in WeakReference class (#13621)

I chose "object" as that's also the argument name in WeakReference::create.

[ci skip] NEWS

Fix GH-13612: Corrupted memory in destructor with weak references

Inside `zend_object_std_dtor` the weakrefs are notified after the destruction
of properties already took place. In this

Fix GH-13612: Corrupted memory in destructor with weak references

Inside `zend_object_std_dtor` the weakrefs are notified after the destruction
of properties already took place. In this test case, the destructor of an anon
class will be invoked due to the property destruction. That class has a
weak reference to its parent. This means that the destructor can access
parent properties that already have been destroyed, resulting in a UAF.
Fix this by notifying the weakrefs at the start of the object's
destruction.

Closes GH-13613.

show more ...

[ci skip] NEWS

[ci skip] NEWS and UPGRADING

Closes GH-13466.

Fix GH-13603 ext/sockets: properly initialised address info data.

Led to random characters visible on socket id on macOs.

Close GH-13606

Singular DateTime::[get|set]Microsecond & no tentative return type (#13486)

* Singular DateTime::[get|set]Microsecond & no tentative return type

* Added missing getMicrosecond to Da

Singular DateTime::[get|set]Microsecond & no tentative return type (#13486)

* Singular DateTime::[get|set]Microsecond & no tentative return type

* Added missing getMicrosecond to DateTimeInterface

show more ...