win,pipe: fix bugs with pipe resource lifetime management (#3611)

If `uv_close` was called while a connect was pending, we would fail to
release the resources for the connection, since w

win,pipe: fix bugs with pipe resource lifetime management (#3611)

If `uv_close` was called while a connect was pending, we would fail to
release the resources for the connection, since we had not yet set the
type of the struct.

Fix a thread data-race on slow connect path code: only permitted to
write to `req` on threads, as anything else causes data race
corruption.

There seemed be a small variety of other resource management bugs in
edge cases, which turned out to make this a lot larger than initially
expected.

Refs: https://github.com/libuv/libuv/pull/3598#issuecomment-1111513567

show more ...

test: remove disabled callback_order test (#3619)

This test has always been disabled for the 10 years of its existence and
there are other tests that exercise "what happens when" event o

test: remove disabled callback_order test (#3619)

This test has always been disabled for the 10 years of its existence and
there are other tests that exercise "what happens when" event ordering.

Fixes: https://github.com/libuv/libuv/issues/3618

show more ...

unix: use MSG_CMSG_CLOEXEC where supported (#3609)

Use MSG_CMSG_CLOEXEC on Unix-y platforms that support it (all except
macOS and SunOS spawn.)

Remove the feature test for Linux

unix: use MSG_CMSG_CLOEXEC where supported (#3609)

Use MSG_CMSG_CLOEXEC on Unix-y platforms that support it (all except
macOS and SunOS spawn.)

Remove the feature test for Linux. Libuv's kernel baseline is 2.6.32
and MSG_CMSG_CLOEXEC was added in 2.6.23.

show more ...

doc: fix link to uvwget example main() function (#3605)

openbsd: use utimensat instead of lutimes (#3607)

OpenBSD doesn't have lutimes so utimensat should be used instead.

test: rewrite embed test (#3608)

- fix busy loop
- fix multi-thread race conditions
- reduce amount of platform-specific code

Fixes: https://github.com/libuv/libuv/issues/36

test: rewrite embed test (#3608)

- fix busy loop
- fix multi-thread race conditions
- reduce amount of platform-specific code

Fixes: https://github.com/libuv/libuv/issues/3606

show more ...

release: check versions of autogen scripts are newer (#3554)

Use libtoolize --force to ensure it updates m4 directory with the
latest files. Add an option "release" to the autogen.sh scr

release: check versions of autogen scripts are newer (#3554)

Use libtoolize --force to ensure it updates m4 directory with the
latest files. Add an option "release" to the autogen.sh script that
checks the versions of the input tools, so that we know they are always
using the latest version for each release.

show more ...

macos: avoid posix_spawnp() cwd bug (#3597)

macOS 10.15 has a bug where configuring the working directory with
posix_spawn_file_actions_addchdir_np() makes posix_spawnp() fail with
E

macos: avoid posix_spawnp() cwd bug (#3597)

macOS 10.15 has a bug where configuring the working directory with
posix_spawn_file_actions_addchdir_np() makes posix_spawnp() fail with
ENOENT even though the executable is spawned successfully.

Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>

show more ...

doc: remove smartos from supported platforms (#3594)

Commit 3af55129 from 2017 distinguished between smartos and other sunos
spawn but [0] makes it clear ("a new chapter" - barf) that sm

doc: remove smartos from supported platforms (#3594)

Commit 3af55129 from 2017 distinguished between smartos and other sunos
spawn but [0] makes it clear ("a new chapter" - barf) that smartos is
dead.

Stop mentioning smartos and put everything under the sunos umbrella.

[0] https://www.joyent.com/blog/a-new-chapter-begins-for-triton-and-smartos

show more ...

uv: register __rfim_event 156 as UV_RENAME (#3540 3/3)

When the watched file is moved or removed, or an editor (e.g. vim)
renames then creates the file, the __rfim_event 156 occurs. This

uv: register __rfim_event 156 as UV_RENAME (#3540 3/3)

When the watched file is moved or removed, or an editor (e.g. vim)
renames then creates the file, the __rfim_event 156 occurs. This is an
undocumented event that should not happen, but register it as UV_RENAME
for now since it is functionally equivalent.

Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>

show more ...

uv: register UV_RENAME event for _RFIM_UNLINK (#3540 2/3)

`rename()` can be used to rename a file path via _RFIM_UNLINK. So
register it as a UV_RENAME event.

Co-authored-by: Igo

uv: register UV_RENAME event for _RFIM_UNLINK (#3540 2/3)

`rename()` can be used to rename a file path via _RFIM_UNLINK. So
register it as a UV_RENAME event.

Co-authored-by: Igor Todorovski <itodorov@ca.ibm.com>

show more ...

uv: re-register interest in a file after change (#3540 1/3)

The file is implicitly unregistered when the change notification is
sent, only one notification is sent per registration. So w

uv: re-register interest in a file after change (#3540 1/3)

The file is implicitly unregistered when the change notification is
sent, only one notification is sent per registration. So we need to
re-register interest in a file after each change notification we
receive.

Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>

show more ...

sunos: fs-event callback can be called after uv_close() (#3542)

On illumos and Solaris, fs events are implemented with
PORT_SOURCE_FILE type event ports. These are one-shot so
need r

sunos: fs-event callback can be called after uv_close() (#3542)

On illumos and Solaris, fs events are implemented with
PORT_SOURCE_FILE type event ports. These are one-shot so
need re-arming each time they fire. Once they are armed
and an event occurs, the kernel removes them from the current
cache list and puts them on an event queue to be read by
the application.

There's a window in closing one of these ports when it could
have triggered and be pending delivery. In that case, the
attempt to disarm (dissociate) the event will fail with ENOENT
but libuv still goes ahead and closes down the handle. In
particular, the close callback (uv_close() argument) will be
called but then the event will subsequently be delivered if
the loop is still active; this should not happen.

show more ...

test: separate some static variables by test cases (#3567)

doc: make sample cross-platform build (#3592)

Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>

win: fix unexpected ECONNRESET error on TCP socket (#3584)

unix,win: fix UV_RUN_ONCE + uv_idle_stop loop hang (#3590)

Wrong accounting of idle handles in uv_run() made it sleep when there
was nothing left to do. Do a non-blocking poll for I/O in

unix,win: fix UV_RUN_ONCE + uv_idle_stop loop hang (#3590)

Wrong accounting of idle handles in uv_run() made it sleep when there
was nothing left to do. Do a non-blocking poll for I/O instead.

show more ...

build: fix AIX xlc autotools build (#3588)

test: fix flaky file watcher test (#3591)

FSEvents on macOS sometimes sends one change event, sometimes two.
Make the test more lenient.

Fixes #3589.

win: fix incompatible-types warning (#3581)

Introduced by https://github.com/libuv/libuv/pull/3350.

core: add thread-safe strtok implementation (#3553)

This commit adds the support for a custom strtok implementation, which
is reentrant. On some systems strtok_r or strstep is available

core: add thread-safe strtok implementation (#3553)

This commit adds the support for a custom strtok implementation, which
is reentrant. On some systems strtok_r or strstep is available for that
purpose; however, since these are an extension, it is difficult to
control if it will be available on every supported system.

show more ...

test: remove unused declarations in tcp_rst test (#3574)

Refs: https://github.com/libuv/libuv/pull/3482

process,iOS: fix build breakage in process.c (#3563)

Remove the `TARGET_OS_IPHONE` ifdef to include posix spawn headers for
iOS build. Previously https://github.com/libuv/libuv/pull/3257

process,iOS: fix build breakage in process.c (#3563)

Remove the `TARGET_OS_IPHONE` ifdef to include posix spawn headers for
iOS build. Previously https://github.com/libuv/libuv/pull/3257
introduced posix spawn with \_\_APPLE\_\_ platform only, which resulted
in a number of spawn related definitions not found for iOS (such as
`uv__posix_spawn_fncs_tag`).

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

show more ...

build: re-enable CI for windows changes (#3572)

I got the conditional reversed in https://github.com/libuv/libuv/pull/3564

build: add iOS to macos CI (#3564)

Smokescreen for build errors on iOS, currently ignoring failures due to
aforementioned build errors.