test: fix C++ style comment

windows: define snprintf replacement as inline instead of static

The MSVC compiler does not accept static methods defined in headers,
when linking against a shared library. The snprintf

windows: define snprintf replacement as inline instead of static

The MSVC compiler does not accept static methods defined in headers,
when linking against a shared library. The snprintf replacement
function used for windows, is now an inline function.

PR-URL: https://github.com/libuv/libuv/pull/329
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

build: set SONAME for shared library in uv.gyp

For autoconf the libuv shared library SONAME is libuv.so.1.0
but gyp builds in UNIX were missing the proper SONAME. gyp
does not have a

build: set SONAME for shared library in uv.gyp

For autoconf the libuv shared library SONAME is libuv.so.1.0
but gyp builds in UNIX were missing the proper SONAME. gyp
does not have an explicit setting for SONAME. Changing the
output file extensions triggers the use of SONAME.

The previous gyp configuration also also caused issue
joyent/libuv#1382, that prevented building the tests against
a shared library - the issue is now fixed for UNIX.

PR-URL: https://github.com/libuv/libuv/pull/329
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

gitignore: ignore IntelliJ project files

unix: clean up uv_fs_open() O_CLOEXEC logic

Move the logic out of uv__fs_work() and into a function of its own.

PR-URL: https://github.com/libuv/libuv/pull/326
Reviewed-By: Saúl

unix: clean up uv_fs_open() O_CLOEXEC logic

Move the logic out of uv__fs_work() and into a function of its own.

PR-URL: https://github.com/libuv/libuv/pull/326
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

Revert "memory: add uv_replace_allocator"

This reverts commit c272f1f1bc0bda625e6441d798c110b4064a6ce2.

The concept will come back to libuv, but it needs some more work.

docs: add some missing words

PR-URL: https://github.com/libuv/libuv/pull/332
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

unix: open "/dev/null" instead of "/" for emfile_fd

We may not have permission to open "/". This fix allows libuv to be
used in a OS X app that has sandboxing enabled, without the need f

unix: open "/dev/null" instead of "/" for emfile_fd

We may not have permission to open "/". This fix allows libuv to be
used in a OS X app that has sandboxing enabled, without the need for
a temporary entitlement to allow reading of "/" (Which would never
pass app review).

In some rare cases "/dev" isn't mounted, so we open "/" as a
fallback.

PR-URL: https://github.com/libuv/libuv/pull/328
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

win: fix of double free in uv_uptime

PR-URL: https://github.com/libuv/libuv/pull/324
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

win: fix uv_fs_access on directories

For posterity, these are the rules for access on Windows (taken from
CPython's implementation), Access is possible if:

* Write access wasn't

win: fix uv_fs_access on directories

For posterity, these are the rules for access on Windows (taken from
CPython's implementation), Access is possible if:

* Write access wasn't requested
* The file isn't read-only
* It's a directory (directories cannot be read-only on Windows)

PR-URL: https://github.com/libuv/libuv/pull/316
Reviewed-By: Bert Belder <bertbelder@gmail.com>

show more ...

test: remove LOG and LOGF variadic macros

Initial patch by @simar7, thanks!

PR-URL: https://github.com/libuv/libuv/pull/313
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

unix: fix potential bug if dup2 fails in uv_spawn

PR-URL: https://github.com/libuv/libuv/pull/309
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

unix: fix swapping fds order in uv_spawn

Alternative implementation (and test) to
https://github.com/libuv/libuv/pull/226

Fixes: https://github.com/joyent/libuv/issues/1084

unix: fix swapping fds order in uv_spawn

Alternative implementation (and test) to
https://github.com/libuv/libuv/pull/226

Fixes: https://github.com/joyent/libuv/issues/1084
PR-URL: https://github.com/libuv/libuv/pull/309
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

show more ...

test: spawn child replacing std{out,err} to stderr

Refs: https://github.com/libuv/libuv/pull/224

PR-URL: https://github.com/libuv/libuv/pull/309
Reviewed-By: Ben Noordhuis <info

test: spawn child replacing std{out,err} to stderr

Refs: https://github.com/libuv/libuv/pull/224

PR-URL: https://github.com/libuv/libuv/pull/309
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

show more ...

unix: don't close the fds we just setup

If a descriptor was being copied to an fd that *was not its current
value*, it should get closed after being copied. But the existing code
wou

unix: don't close the fds we just setup

If a descriptor was being copied to an fd that *was not its current
value*, it should get closed after being copied. But the existing code
would close the fd, even when it no longer referred to the original
descriptor. Don't do this, only close fds that are not in the desired
range for the child process.

See https://github.com/iojs/io.js/issues/862

PR-URL: https://github.com/libuv/libuv/pull/309
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

android: fix compilation warning

PR-URL: https://github.com/libuv/libuv/pull/285
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

linux: fix epoll_pwait() fallback on arm64

arm64 doesn't have a epoll_wait() system call but a logic error stopped
libuv from falling back to epoll_pwait().

This bug was introdu

linux: fix epoll_pwait() fallback on arm64

arm64 doesn't have a epoll_wait() system call but a logic error stopped
libuv from falling back to epoll_pwait().

This bug was introduced in commit 67bb2b5 ("linux: fix epoll_pwait()
regression with < 2.6.19") which sadly exchanged one regression for
another.

PR-URL: https://github.com/libuv/libuv/pull/308
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...

doc: document uv_buf_t members

PR-URL: https://github.com/libuv/libuv/pull/307
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

Revert "test: fix tcp_oob occassionally timing out"

This reverts commit 3346082132dc2ff809dfd5d25d451c0b33905f53.

See https://github.com/libuv/libuv/issues/258

test: fix tcp_oob occassionally timing out

Patch by @indutny

Fixes: https://github.com/libuv/libuv/issues/258
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-B

test: fix tcp_oob occassionally timing out

Patch by @indutny

Fixes: https://github.com/libuv/libuv/issues/258
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

show more ...

build: add documentation for ninja support

PR-URL: https://github.com/libuv/libuv/pull/290
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

doc: clarify that we don't maintain external doc resources

PR-URL: https://github.com/libuv/libuv/pull/284
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

doc: clarify what uv_*_open accepts

Fixes: https://github.com/libuv/libuv/issues/281
PR-URL: https://github.com/libuv/libuv/pull/284
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

test: fix tty_file, close handle if initialized

If the handle is closed when it wasn't initialized, uv_close will fail.

PR-URL: https://github.com/libuv/libuv/pull/279
Reviewed-

test: fix tty_file, close handle if initialized

If the handle is closed when it wasn't initialized, uv_close will fail.

PR-URL: https://github.com/libuv/libuv/pull/279
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

show more ...

windows: fix handle leak on EMFILE

If CreateFileW succeeds, but _open_osfhandle fails, the handle must be closed.

PR-URL: https://github.com/libuv/libuv/pull/278
Reviewed-By: Sa

windows: fix handle leak on EMFILE

If CreateFileW succeeds, but _open_osfhandle fails, the handle must be closed.

PR-URL: https://github.com/libuv/libuv/pull/278
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

show more ...