d5db2773 | 14-Oct-2016 |
Ben Noordhuis |
win: silence -Wmaybe-uninitialized warning The compiler is wrong about it being used uninitialized but the warning is sufficiently annoying that I decided to squelch it. PR-URL:
win: silence -Wmaybe-uninitialized warning The compiler is wrong about it being used uninitialized but the warning is sufficiently annoying that I decided to squelch it. PR-URL: https://github.com/libuv/libuv/pull/1097 Reviewed-By: Andrius Bentkus <andrius.bentkus@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
d00de932 | 14-Oct-2016 |
Ben Noordhuis |
win: remove unused static variables default_loop_struct and default_loop_ptr seem to have been overlooked in commit 32747c7 ("win,unix: move loop functions which have identical imple
win: remove unused static variables default_loop_struct and default_loop_ptr seem to have been overlooked in commit 32747c7 ("win,unix: move loop functions which have identical implementations".) PR-URL: https://github.com/libuv/libuv/pull/1097 Reviewed-By: Andrius Bentkus <andrius.bentkus@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
f1863dae | 18-Sep-2016 |
Philippe Laferriere |
unix,win: add uv_translate_sys_error() public API uv_translate_sys_error() was a private function for Windows. This commit adds an equivalent function on other platforms, and exposes
unix,win: add uv_translate_sys_error() public API uv_translate_sys_error() was a private function for Windows. This commit adds an equivalent function on other platforms, and exposes it as public API. Exposing this is useful in scenarios where the application uses both libuv functions and platform-specific system calls and wants to report errors uniformly as libuv errors. Fixes: https://github.com/libuv/libuv/issues/79 PR-URL: https://github.com/libuv/libuv/pull/1060 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
6b35ca86 | 29-Sep-2016 |
Brad King |
unix: don't include CoreServices globally on macOS In unix/internal.h, CoreServices is included for AvailabilityMacros.h. This commit just includes AvailabilityMacros.h directly instead.
unix: don't include CoreServices globally on macOS In unix/internal.h, CoreServices is included for AvailabilityMacros.h. This commit just includes AvailabilityMacros.h directly instead. PR-URL: https://github.com/libuv/libuv/pull/1092 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
3064ae98 | 14-Oct-2016 |
Ben Noordhuis |
unix: don't malloc in uv_thread_create() Simplify and optimize uv_thread_create() by casting the function pointer to the prototype that pthread_create() wants. Avoids the indirection of
unix: don't malloc in uv_thread_create() Simplify and optimize uv_thread_create() by casting the function pointer to the prototype that pthread_create() wants. Avoids the indirection of an intermediate callback and heap-allocating custom state that is really only there to placate the compiler. PR-URL: https://github.com/libuv/libuv/pull/1094 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
538782fb | 23-Aug-2016 |
Ben Noordhuis |
test: make threadpool saturation reliable Use a deterministic approach for saturating the threadpool instead of depending on a timeout. Should help reduce the flakiness of the CI.
test: make threadpool saturation reliable Use a deterministic approach for saturating the threadpool instead of depending on a timeout. Should help reduce the flakiness of the CI. PR-URL: https://github.com/libuv/libuv/pull/1014 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
39baaa58 | 23-Aug-2016 |
Ben Noordhuis |
test: make threadpool_cancel_single deterministic Saturate the thread pool before trying to post-and-cancel the work request. Before this commit we simply posted requests in a loop,
test: make threadpool_cancel_single deterministic Saturate the thread pool before trying to post-and-cancel the work request. Before this commit we simply posted requests in a loop, in the (sometimes idle) hope that one would get queued up instead of being dispatched right away. PR-URL: https://github.com/libuv/libuv/pull/1014 Refs: https://github.com/libuv/libuv/pull/1010 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
e58f7535 | 12-Sep-2016 |
Ben Noordhuis |
test: fix tcp_close_while_connecting CI failures The expected error is UV_ECANCELED but the test tries to connect to what is basically an arbitrary address in the expectation that no net
test: fix tcp_close_while_connecting CI failures The expected error is UV_ECANCELED but the test tries to connect to what is basically an arbitrary address in the expectation that no network path exists, so UV_ENETUNREACH is an equally plausible outcome. This commit undoes the change from commit e994000 ("test: make tcp_close_while_connecting more resilient") because I don't think the connection ever actually succeeds. PR-URL: https://github.com/libuv/libuv/pull/1048 Refs: https://github.com/libuv/libuv/pull/1005 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Imran Iqbal <imran@imraniqbal.org> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
cfc19221 | 29-Sep-2016 |
Brad King |
win: fix winapi function pointer typedef syntax Move the `PASCAL` calling convention marker from: typedef void PASCAL (*f)(...); to the proper place for a calling conve
win: fix winapi function pointer typedef syntax Move the `PASCAL` calling convention marker from: typedef void PASCAL (*f)(...); to the proper place for a calling convention in a function pointer type: typedef void (PASCAL *f)(...); This is where the MS-provided winapi headers place it too. PR-URL: https://github.com/libuv/libuv/pull/1075 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
8ebecf6e | 05-Oct-2016 |
Alex Hultman |
doc: add reference to uv_update_time on uv_timer_start PR-URL: https://github.com/libuv/libuv/pull/1079 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé
doc: add reference to uv_update_time on uv_timer_start PR-URL: https://github.com/libuv/libuv/pull/1079 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
1bcdca29 | 29-Sep-2016 |
Vladimír Čunát |
doc: note buffer lifetime requirements in uv_write Fixes: https://github.com/libuv/libuv/issues/1072 PR-URL: https://github.com/libuv/libuv/pull/1074 Reviewed-By: Saúl Ibarra Corretg
doc: note buffer lifetime requirements in uv_write Fixes: https://github.com/libuv/libuv/issues/1072 PR-URL: https://github.com/libuv/libuv/pull/1074 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
show more ...
|
8221f9b3 | 23-Sep-2016 |
Jason Ginchereau |
win: fix leaky fs request buffer When a large number of buffers (>4) is passed into `uv_fs_read()` or `uv_fs_write()`, a new buffer is dynamically allocated to hold a copy of the req
win: fix leaky fs request buffer When a large number of buffers (>4) is passed into `uv_fs_read()` or `uv_fs_write()`, a new buffer is dynamically allocated to hold a copy of the request data. This change adds code in `uv_fs_req_cleanup()` to free that buffer if it was allocated. Refs: https://github.com/nodejs/node/issues/7191 Fixes: https://github.com/libuv/libuv/issues/1069 PR-URL: https://github.com/libuv/libuv/pull/1070 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
ca107b7f | 14-Sep-2016 |
Julien Gilli |
build: use -pthreads for tests with autotools This prevents tests from using non-reentrant implementations of common APIs (e.g `errno`) when using POSIX threads and building with autotoo
build: use -pthreads for tests with autotools This prevents tests from using non-reentrant implementations of common APIs (e.g `errno`) when using POSIX threads and building with autotools. This is consistent with the way tests are builds when using gyp. The problem was found when investigating tests failures on SmartOS for one test added by https://github.com/libuv/libuv/pull/640. These failures were due to that test using POSIX threads and also using a non-reentrant errno global variable, instead of the reentrant `___errno` function. PR-URL: https://github.com/libuv/libuv/pull/1052 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
20c9c010 | 17-Sep-2016 |
Vit Gottwald |
doc: add description of uv_handle_type Fixes: https://github.com/libuv/libuv/issues/1044 PR-URL: https://github.com/libuv/libuv/pull/1059 Reviewed-By: Saúl Ibarra Corretgé <saghul@gm
doc: add description of uv_handle_type Fixes: https://github.com/libuv/libuv/issues/1044 PR-URL: https://github.com/libuv/libuv/pull/1059 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
468d4462 | 31-Aug-2016 |
Bartosz Sosnowski |
win, test: fix fs_event_watch_dir_recursive Under Windows uv_fs_event_start with UV_FS_EVENT_RECURSIVE will report new file creation and file deletion twice - once with the name of the f
win, test: fix fs_event_watch_dir_recursive Under Windows uv_fs_event_start with UV_FS_EVENT_RECURSIVE will report new file creation and file deletion twice - once with the name of the file, and second time with the name of the directory itself. This will filter out callbacks with directory name, making observed callbacks count match expected values. Fixes: https://github.com/libuv/libuv/issues/1009 PR-URL: https://github.com/libuv/libuv/pull/1061 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
fa81a1b2 | 17-Sep-2016 |
Vit Gottwald |
test: fix fs_fstat on Android Fixes: https://github.com/libuv/libuv/issues/1051 PR-URL: https://github.com/libuv/libuv/pull/1056 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Revi
test: fix fs_fstat on Android Fixes: https://github.com/libuv/libuv/issues/1051 PR-URL: https://github.com/libuv/libuv/pull/1056 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
84144036 | 15-Sep-2016 |
Bartosz Sosnowski |
win,tty: fix uv_tty_set_mode race conditions Additional synchronization is needed to ensure that the program cannot modify the screen state while a line read is getting cancelled.
win,tty: fix uv_tty_set_mode race conditions Additional synchronization is needed to ensure that the program cannot modify the screen state while a line read is getting cancelled. Also, we need to stop any pending reads *before* calling SetConsoleMode, or a call to ReadConsole could start while the console is still in raw mode. Credit: @orangemocha - Alexis Campailla <orangemocha@nodejs.org> Fixes: https://github.com/nodejs/node/issues/7837 PR-URL: https://github.com/libuv/libuv/pull/1054 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
79e80e0f | 15-Sep-2016 |
Saúl Ibarra Corretgé |
doc: add ABI tracker link to README PR-URL: https://github.com/libuv/libuv/pull/1053 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> |
1a96fe33 | 13-Sep-2016 |
Santiago Gimeno |
build,osx: fix warnings on tests compilation with gyp Add `-Wno-long-long` to `WARNING_CFLAGS`. PR-URL: https://github.com/libuv/libuv/pull/1049 Reviewed-By: Saúl Ibarra Corretg
build,osx: fix warnings on tests compilation with gyp Add `-Wno-long-long` to `WARNING_CFLAGS`. PR-URL: https://github.com/libuv/libuv/pull/1049 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
d38edefc | 14-Sep-2016 |
Bart Robinson |
doc: fix confusing doc of uv_tcp_nodelay Previous description implied enabling nodelay enabled Nagle, but it is the other way around. PR-URL: https://github.com/libuv/libuv/pull
doc: fix confusing doc of uv_tcp_nodelay Previous description implied enabling nodelay enabled Nagle, but it is the other way around. PR-URL: https://github.com/libuv/libuv/pull/1050 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
e7bc260c | 12-Sep-2016 |
Ben Noordhuis |
unix: don't use alphasort in uv_fs_scandir() alphasort() uses strcoll() in some libcs (notably glibc and musl) which makes it locale-sensitive. Replace it with a simple strcmp-b
unix: don't use alphasort in uv_fs_scandir() alphasort() uses strcoll() in some libcs (notably glibc and musl) which makes it locale-sensitive. Replace it with a simple strcmp-based lexicographic comparison for consistent behavior across platforms. Remove the special-casing for OpenBSD. It has been exporting function prototypes conforming to POSIX.1-2008 since OpenBSD 5.3 and that was released more than three years ago. OS X 10.7 is now the only special case left. Fixes: https://github.com/libuv/libuv/issues/1045 PR-URL: https://github.com/libuv/libuv/pull/1046 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
29138058 | 04-Sep-2016 |
Santiago Gimeno |
test: fix fs_event_watch_dir flakiness on arm Increase the time between file creations, so all the events are emitted. PR-URL: https://github.com/libuv/libuv/pull/1038 Revie
test: fix fs_event_watch_dir flakiness on arm Increase the time between file creations, so all the events are emitted. PR-URL: https://github.com/libuv/libuv/pull/1038 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
show more ...
|
6d7d57a9 | 03-Sep-2016 |
Santiago Gimeno |
test: fix test-tcp-writealot flakiness on arm Decrease the data sent for `arm` so the test doesn't timeout in the arm CI bots. PR-URL: https://github.com/libuv/libuv/pull/1038
test: fix test-tcp-writealot flakiness on arm Decrease the data sent for `arm` so the test doesn't timeout in the arm CI bots. PR-URL: https://github.com/libuv/libuv/pull/1038 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
show more ...
|
30d852f9 | 09-Sep-2016 |
Imran Iqbal |
doc: update supported fields for uv_rusage_t Fixes: https://github.com/libuv/libuv/issues/342 PR-URL: https://github.com/libuv/libuv/pull/1041 Reviewed-By: Saúl Ibarra Corretgé <sagh
doc: update supported fields for uv_rusage_t Fixes: https://github.com/libuv/libuv/issues/342 PR-URL: https://github.com/libuv/libuv/pull/1041 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
show more ...
|
0d7f72f2 | 08-Sep-2016 |
Santiago Gimeno |
fs: fix uv_fs_fstat on platforms using musl libc In `musl` libc, defining `_GNU_SOURCE` doesn't automatically define the other feature definitions, causing that `uv_fs_fstat` would not f
fs: fix uv_fs_fstat on platforms using musl libc In `musl` libc, defining `_GNU_SOURCE` doesn't automatically define the other feature definitions, causing that `uv_fs_fstat` would not fill the `nsec` fields. For the same reason, compile the tests on linux with `-D_GNU_SOURCE` so the `fs_fstat` tests passes on `musl` platforms. PR-URL: https://github.com/libuv/libuv/pull/1039 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|