#
9dddebab |
| 12-Sep-2024 |
Ben Noordhuis |
test: delete test with invalid assumption (#4530) Delete the fs_event_error_reporting test. It fails in different ways, most frequently on the TSan sanitizer buildbot, due to running out
test: delete test with invalid assumption (#4530) Delete the fs_event_error_reporting test. It fails in different ways, most frequently on the TSan sanitizer buildbot, due to running out of file descriptors when that is not expected, or vice versa, *not* running out of file descriptors when that *is* expected. The test creates a large number of event loops and expects to, eventually, hit EMFILE but it sometimes hits it too early, and sometimes not at all. I don't think TSan is really responsible here, it just makes the invalid assumption in the test itself more visible. Fixes: https://github.com/libuv/libuv/issues/4368
show more ...
|
#
c84a2dbe |
| 07-Aug-2024 |
Richard Lau |
test: check for `UV_CHANGE` or `UV_RENAME` event All other checks for `UV_RENAME` in `test-fs-event` also allow `UV_CHANGE`.
|
#
badecdca |
| 29-Jul-2024 |
Santiago Gimeno |
fsevents: detect watched directory removal (#4376) Which was broken both in `windows` and `macos`.
|
#
287987b3 |
| 18-May-2024 |
Andy Pan |
test: remove the obsolete HAVE_KQUEUE macro --------- Signed-off-by: Andy Pan <i@andypan.me>
|
#
17219b8f |
| 31-Mar-2024 |
Ben Noordhuis |
test: use newer ASSERT_MEM_EQ macro (#4346) Should hopefully make it easier to debug CI flakiness because currently the test sometimes fails without a clear indication why. Refs
test: use newer ASSERT_MEM_EQ macro (#4346) Should hopefully make it easier to debug CI flakiness because currently the test sometimes fails without a clear indication why. Refs: https://github.com/libuv/libuv/issues/4106
show more ...
|
#
8a499e13 |
| 22-Dec-2023 |
Matheus Izvekov |
win: stop using deprecated names (#4253)
|
#
56fca44a |
| 28-Oct-2023 |
Ben Noordhuis |
build: run sanitizers on macos ci (#4189) Skip three fs_event tests that time out under Thread Sanitizer.
|
#
011a1ac1 |
| 06-Oct-2023 |
Pleuvens |
test: switch to new-style ASSERT_EQ macros (#4159) Switch from old-style ASSERT macro to new-style ASSERT_EQ,... macros. Using new-style macros makes it easier to debug test failure
test: switch to new-style ASSERT_EQ macros (#4159) Switch from old-style ASSERT macro to new-style ASSERT_EQ,... macros. Using new-style macros makes it easier to debug test failures Fixes: https://github.com/libuv/libuv/issues/2974
show more ...
|
#
3990fcad |
| 12-May-2023 |
cui fliter |
docs: fix some typos (#3984)
|
#
91a7e498 |
| 12-Mar-2023 |
Trevor Norris |
test: silence more valgrind warnings (#3917) Pass the loop to MAKE_VALGRIND_HAPPY() so it's explicit on which loop needs to be cleaned up. Since it asserts on uv_loop_close(), need to
test: silence more valgrind warnings (#3917) Pass the loop to MAKE_VALGRIND_HAPPY() so it's explicit on which loop needs to be cleaned up. Since it asserts on uv_loop_close(), need to remove a couple of those that were being done before the call. Cleanup where loop was assigned, so the entire test either uses loop or uv_default_loop(). Not both. Also take care of any reqs that may have been left uncleaned.
show more ...
|
#
d5cfb899 |
| 21-Dec-2022 |
Ben Noordhuis |
test: unflake fs_event_watch_dir test (#3863) Increase the timer interval. That hopefully ameliorates the problem of FSEvents.framework missing events on the macOS CI buildbot.
test: unflake fs_event_watch_dir test (#3863) Increase the timer interval. That hopefully ameliorates the problem of FSEvents.framework missing events on the macOS CI buildbot. Not really a fix, more a mitigation. Fixes: https://github.com/libuv/libuv/issues/3862
show more ...
|
#
5102b2c0 |
| 28-Nov-2022 |
Ben Noordhuis |
unix: drop kfreebsd support (#3835) Because kFreeBSD is dead. RIP. Fixes: https://github.com/libuv/libuv/issues/3833
|
#
612c28b8 |
| 11-Apr-2022 |
Andy Fiddaman |
sunos: fs-event callback can be called after uv_close() (#3542) On illumos and Solaris, fs events are implemented with PORT_SOURCE_FILE type event ports. These are one-shot so need r
sunos: fs-event callback can be called after uv_close() (#3542) On illumos and Solaris, fs events are implemented with PORT_SOURCE_FILE type event ports. These are one-shot so need re-arming each time they fire. Once they are armed and an event occurs, the kernel removes them from the current cache list and puts them on an event queue to be read by the application. There's a window in closing one of these ports when it could have triggered and be pending delivery. In that case, the attempt to disarm (dissociate) the event will fail with ENOENT but libuv still goes ahead and closes down the handle. In particular, the close callback (uv_close() argument) will be called but then the event will subsequently be delivered if the loop is still active; this should not happen.
show more ...
|
#
223e526f |
| 06-Apr-2022 |
Ben Noordhuis |
test: fix flaky file watcher test (#3591) FSEvents on macOS sometimes sends one change event, sometimes two. Make the test more lenient. Fixes #3589.
|
#
6564ccc9 |
| 09-Oct-2021 |
Jameson Nash |
asan: fix some tests (#3323) Previously they were just being run incorrectly, but nothing wrong with the test itself. We were also interpreting an ASAN failure as TEST_SKIP, so test
asan: fix some tests (#3323) Previously they were just being run incorrectly, but nothing wrong with the test itself. We were also interpreting an ASAN failure as TEST_SKIP, so test failures would not actually be reported as CI failures.
show more ...
|
#
a39009a5 |
| 08-Sep-2021 |
Ben Noordhuis |
win,fsevent: fix uv_fs_event_stop() assert Fix a logic error where calling uv_fs_event_stop() from the event callback tripped on a `handle->dir_handle != INVALID_HANDLE_VALUE` assert
win,fsevent: fix uv_fs_event_stop() assert Fix a logic error where calling uv_fs_event_stop() from the event callback tripped on a `handle->dir_handle != INVALID_HANDLE_VALUE` assert in uv_fs_event_queue_readdirchanges(). Fixes: https://github.com/libuv/libuv/issues/3258 PR-URL: https://github.com/libuv/libuv/pull/3259 Reviewed-By: Jameson Nash <vtjnash@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
show more ...
|
Revision tags: v1.41.0 |
|
#
270d0518 |
| 29-Dec-2020 |
tjarlama |
test: move to ASSERT_NULL and ASSERT_NOT_NULL test macros Moving to new style test macros will make debugging easier in case of test failure and improve redability. This commit will repl
test: move to ASSERT_NULL and ASSERT_NOT_NULL test macros Moving to new style test macros will make debugging easier in case of test failure and improve redability. This commit will replace all ASSERT macros matching the statement: `ASSERT(identifier (== or !=) value);` to: `ASSERT_(NOT_)NULL(identifier);` Refs: https://github.com/libuv/libuv/issues/2974 PR-URL: https://github.com/libuv/libuv/pull/3081 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
show more ...
|
Revision tags: v1.40.0 |
|
#
97a90330 |
| 20-Sep-2020 |
gengjiawen |
build: add asan checks Fixes: https://github.com/libuv/libuv/issues/2999 PR-URL: https://github.com/libuv/libuv/pull/2998 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed
build: add asan checks Fixes: https://github.com/libuv/libuv/issues/2999 PR-URL: https://github.com/libuv/libuv/pull/2998 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
show more ...
|
Revision tags: v1.39.0, v1.38.1, v1.38.0, v1.37.0, v1.36.0, v1.35.0 |
|
#
1ff84206 |
| 26-Jan-2020 |
Santiago Gimeno |
test: fix fs_event_watch_dir_recursive flakiness This test sometimes times out on `macos` because not all the expected events are received: the create and delete events may coalesce. To
test: fix fs_event_watch_dir_recursive flakiness This test sometimes times out on `macos` because not all the expected events are received: the create and delete events may coalesce. To avoid it, make sure not to start deleting the files until all the create events are received. Also, take into account in the test that a create event of the `subdir` directory can be detected even though we start watching for the events after its creation. PR-URL: https://github.com/libuv/libuv/pull/2648 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jameson Nash <vtjnash@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
Revision tags: v1.34.2, v1.34.1, v1.34.0, v1.33.1, v1.33.0 |
|
#
1df44df0 |
| 14-Oct-2019 |
Saúl Ibarra Corretgé |
darwin,test: update loop time after sleeping Otherwise we run the risk of running the timer before the fsevent callback since the timer due time is "now" because it's as long as the
darwin,test: update loop time after sleeping Otherwise we run the risk of running the timer before the fsevent callback since the timer due time is "now" because it's as long as the process already slept. Refs: https://github.com/libuv/libuv/issues/2491 PR-URL: https://github.com/libuv/libuv/pull/2516 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
show more ...
|
#
39a801d6 |
| 14-Oct-2019 |
Saúl Ibarra Corretgé |
darwin,test: include AvailabilityMacros.h It's necessary for MAC_OS_X_VERSION_10_12 to be defined. Refs: https://github.com/libuv/libuv/issues/2491 PR-URL: https://github.com/li
darwin,test: include AvailabilityMacros.h It's necessary for MAC_OS_X_VERSION_10_12 to be defined. Refs: https://github.com/libuv/libuv/issues/2491 PR-URL: https://github.com/libuv/libuv/pull/2516 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
show more ...
|
Revision tags: v1.32.0 |
|
#
ae12376d |
| 08-Sep-2019 |
Jameson Nash |
fsevents: regression in watching / This case got lost by accident in https://github.com/libuv/libuv/pull/2082, preventing the realpath `/` from ever matching. Fixes: https:/
fsevents: regression in watching / This case got lost by accident in https://github.com/libuv/libuv/pull/2082, preventing the realpath `/` from ever matching. Fixes: https://github.com/nodejs/node/issues/28917 PR-URL: https://github.com/libuv/libuv/pull/2460 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <s@saghul.net>
show more ...
|
#
97b85e8b |
| 07-Sep-2019 |
Jameson Nash |
fsevents: stop using fsevents to watch files Goes back to just using it to watch folders, but keeps the other logic changes around. Refs: https://github.com/libuv/libuv/pull/387
fsevents: stop using fsevents to watch files Goes back to just using it to watch folders, but keeps the other logic changes around. Refs: https://github.com/libuv/libuv/pull/387 Refs: https://github.com/libuv/libuv/pull/2082 Refs: https://github.com/libuv/libuv/pull/1572 Refs: https://github.com/nodejs/node/issues/29460 Fixes: https://github.com/libuv/libuv/issues/2488 Closes: https://github.com/libuv/libuv/pull/2452 PR-URL: https://github.com/libuv/libuv/pull/2459 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <s@saghul.net>
show more ...
|
Revision tags: v1.31.0, v1.30.1, v1.30.0, v1.29.1, v1.29.0, v1.28.0, v1.27.0, v1.26.0, v1.25.0, v1.24.1 |
|
#
37da57b6 |
| 30-Nov-2018 |
Refael Ackermann |
win,test: de-flake fs_event_watch_dir_short_path New versions of Windows ship with 8.3 short-names disabled. This commit adds 8.3 detection logic in the fs_event_watch_dir_short_path
win,test: de-flake fs_event_watch_dir_short_path New versions of Windows ship with 8.3 short-names disabled. This commit adds 8.3 detection logic in the fs_event_watch_dir_short_path test. PR-URL: https://github.com/libuv/libuv/pull/2103 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
show more ...
|
#
2d2af382 |
| 19-Nov-2018 |
Jameson Nash |
fsevents: really watch files with fsevents on macos 10.7+ In the original PR, the ifdef conditional was reversed, leading to the old code-path still being used. This also reduces som
fsevents: really watch files with fsevents on macos 10.7+ In the original PR, the ifdef conditional was reversed, leading to the old code-path still being used. This also reduces some of the redundancy in the conditional checks, by factoring out the common test. And fixes a divergence in functionality kFSEventsRenamed => kFSEventStreamEventFlagItemRenamed And actually includes the part of the original PR to kqueue that enabled watching files with fsevents! Fixes: https://github.com/libuv/libuv/pull/387 PR-URL: https://github.com/libuv/libuv/pull/2082 Refs: https://github.com/libuv/libuv/pull/1572 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
show more ...
|