#
e0c5fc87 |
| 20-Mar-2024 |
Ben Noordhuis |
win: remove _alloca usage (#4361) Remove it since it can cause stack overflows. Use heap allocation instead. Fixes: https://github.com/libuv/libuv/issues/4348
|
#
ff958799 |
| 05-Mar-2024 |
Santiago Gimeno |
win: almost fix race detecting ESRCH in uv_kill (#4341) It might happen that only using `WaitForSingleObject()` with timeout 0 could return WAIT_TIMEOUT as the process might not have bee
win: almost fix race detecting ESRCH in uv_kill (#4341) It might happen that only using `WaitForSingleObject()` with timeout 0 could return WAIT_TIMEOUT as the process might not have been signaled yet. To improve things, first use `GetExitCodeProcess()` and check that `status` is not `STILL_ACTIVE`. Then, to cover for the case that the exit code was actually `STILL_ACTIVE` use `WaitForSingleObject()`. This could still be prone to the race condition but only for that case.
show more ...
|
#
129362f3 |
| 05-Feb-2024 |
Jameson Nash |
win: fix ESRCH implementation (#4301) Per documentation, this was the wrong way to test for ESRCH. This hopefully fixes it. Fixes: https://github.com/libuv/libuv/issues/4300
|
#
3f7191e5 |
| 05-Feb-2024 |
Brad King |
win/spawn: optionally run executable paths with no file extension (#4292) Add a process options flag to enable the optional behavior. Most users are likely recommended to set this flag b
win/spawn: optionally run executable paths with no file extension (#4292) Add a process options flag to enable the optional behavior. Most users are likely recommended to set this flag by default, but it was deemed potentially breaking to set it by default in libuv. Co-authored-by: Kyle Edwards <kyle.edwards@kitware.com>
show more ...
|
#
8a499e13 |
| 22-Dec-2023 |
Matheus Izvekov |
win: stop using deprecated names (#4253)
|
#
34db4c21 |
| 20-Dec-2023 |
Anton Bachin |
build,win: work around missing uuid.dll on MinGW (#4261)
|
#
5e302730 |
| 30-Nov-2023 |
Ardi Nugraha <33378542+ardi-nugraha@users.noreply.github.com> |
win: honor NoDefaultCurrentDirectoryInExePath env var (#4238) Fixes: https://github.com/libuv/libuv/issues/3888 Refs: https://github.com/nodejs/node/issues/46264
|
#
f3889085 |
| 29-Oct-2023 |
Jameson Nash |
misc: export WTF8 conversion utilities (#4021) As promised in #2970, this attempts to migrate code to a common set of utilities in a common place in the code and use them everywhere. Thi
misc: export WTF8 conversion utilities (#4021) As promised in #2970, this attempts to migrate code to a common set of utilities in a common place in the code and use them everywhere. This also exports the functionality, since the Windows API with WideCharToMultiByte is fairly verbose relative to what libuv and libuv's clients typically need, so it is useful not to require clients to reimplement this conversion logic unnecessarily (and because Windows is not 64-bit ready here, but this implementation is.)
show more ...
|
#
c03569f0 |
| 02-Oct-2023 |
Jameson Nash |
win,process: avoid assert after spawning Store app (#4152) Make sure this handle is functional. The Windows kernel seems to have a bug that if the first use of AssignProcessToJobObject i
win,process: avoid assert after spawning Store app (#4152) Make sure this handle is functional. The Windows kernel seems to have a bug that if the first use of AssignProcessToJobObject is for a Windows Store program, subsequent attempts to use the handle with fail with INVALID_PARAMETER (87). This is possilby because all uses of the handle must be for the same Terminal Services session. We can ensure it is tied to our current session now by adding ourself to it. We could remove ourself afterwards, but there doesn't seem to be a reason to. Secondly, we start the process suspended so that we can make sure we added it to the job control object before it does anything itself (such as launch more jobs or exit). Fixes: https://github.com/JuliaLang/julia/issues/51461
show more ...
|
#
c97017dd |
| 14-Aug-2023 |
Kyle Edwards |
win,spawn: allow `%PATH%` to be unset (#4116) Fix: https://github.com/libuv/libuv/issues/4115
|
#
d1a2efc7 |
| 16-May-2023 |
Santiago Gimeno |
win: define MiniDumpWithAvxXStateContext always (#3998)
|
#
e7ecd116 |
| 15-May-2023 |
gengjiawen |
win: fix mingw build (#3994) Fixes: https://github.com/libuv/libuv/issues/3992
|
#
748d894e |
| 12-May-2023 |
Elliot Saba |
win,process: write minidumps when sending SIGQUIT (#3840) This commit adds the ability to dump core when sending the `SIGQUIT` signal on Windows. The change reads in the current registry
win,process: write minidumps when sending SIGQUIT (#3840) This commit adds the ability to dump core when sending the `SIGQUIT` signal on Windows. The change reads in the current registry setting for local dumps, and attempts to write out to that location before killing the process. See [collecting-user-mode-dumps] for registry and pathing details. This behavior mimics that of the dumps created by the typical Windows Error Reporting mechanism. [collecting-user-mode-dumps]: https://learn.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps
show more ...
|
#
75d9411e |
| 09-Dec-2022 |
Santiago Gimeno |
win: move child_stdio_buffer out of uv_process_t (#3850)
|
#
d54c92e3 |
| 15-Feb-2022 |
Jameson Nash |
win: fix style nits [NFC] (#3474) Internal functions usually have a uv__ prefix.
|
#
7024f8b2 |
| 08-Sep-2021 |
earnal |
win,spawn: allow UNC path with forward slash Fixes: https://github.com/libuv/libuv/issues/3159 PR-URL: https://github.com/libuv/libuv/pull/3167 Reviewed-By: Jameson Nash <vtjnash@gma
win,spawn: allow UNC path with forward slash Fixes: https://github.com/libuv/libuv/issues/3159 PR-URL: https://github.com/libuv/libuv/pull/3167 Reviewed-By: Jameson Nash <vtjnash@gmail.com>
show more ...
|
#
97709e18 |
| 03-Mar-2021 |
Yash Ladha |
chore: use for(;;) instead of while In the codebase we have used empty for loop for infinite conditions, so to bring consistency replaced other occurrences of while in the codebase w
chore: use for(;;) instead of while In the codebase we have used empty for loop for infinite conditions, so to bring consistency replaced other occurrences of while in the codebase with for loop. PR-URL: https://github.com/libuv/libuv/pull/3128 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
show more ...
|
Revision tags: v1.41.0, v1.40.0, v1.39.0, v1.38.1, v1.38.0, v1.37.0, v1.36.0 |
|
#
3e5d2614 |
| 13-Apr-2020 |
Ben Noordhuis |
win: replace alloca() with stack-based array `required_vars_value_len` has a fixed number of elements. There is no need to use alloca() to allocate it. Refs: https://github.com/
win: replace alloca() with stack-based array `required_vars_value_len` has a fixed number of elements. There is no need to use alloca() to allocate it. Refs: https://github.com/libuv/libuv/pull/2781 PR-URL: https://github.com/libuv/libuv/pull/2783 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
show more ...
|
Revision tags: v1.35.0, v1.34.2, v1.34.1, v1.34.0, v1.33.1, v1.33.0, v1.32.0, v1.31.0 |
|
#
1fc72276 |
| 09-Aug-2019 |
Ben Noordhuis |
win: fix uv_spawn() ENOMEM on empty env Commit ba780231 ("unix,win: handle zero-sized allocations uniformly") makes `uv__malloc()` return NULL when `size == 0`. That's exactly t
win: fix uv_spawn() ENOMEM on empty env Commit ba780231 ("unix,win: handle zero-sized allocations uniformly") makes `uv__malloc()` return NULL when `size == 0`. That's exactly the size that is passed to it when uv_spawn() tries to spawn a process with an empty environment so handle that edge case. Fixes: https://github.com/nodejs/node/issues/29008 PR-URL: https://github.com/libuv/libuv/pull/2408 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jameson Nash <vtjnash+github@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
show more ...
|
Revision tags: v1.30.1, v1.30.0, v1.29.1, v1.29.0, v1.28.0, v1.27.0, v1.26.0, v1.25.0, v1.24.1, v1.24.0 |
|
#
c5593b51 |
| 05-Nov-2018 |
Jameson Nash |
warnings: fix code that emits compiler warnings PR-URL: https://github.com/libuv/libuv/pull/2066 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack
warnings: fix code that emits compiler warnings PR-URL: https://github.com/libuv/libuv/pull/2066 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack@gmail.com>
show more ...
|
#
4c2dcca2 |
| 09-Nov-2018 |
Bartosz Sosnowski |
win: support more fine-grained windows hiding Added UV_PROCESS_WINDOWS_HIDE_CONSOLE and UV_PROCESS_WINDOWS_HIDE_GUI for specifying if console or GUI subprocess windows are to be hidd
win: support more fine-grained windows hiding Added UV_PROCESS_WINDOWS_HIDE_CONSOLE and UV_PROCESS_WINDOWS_HIDE_GUI for specifying if console or GUI subprocess windows are to be hidden. Refs: https://github.com/nodejs/node/pull/24034 PR-URL: https://github.com/libuv/libuv/pull/2073 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
show more ...
|
Revision tags: v1.23.2, v1.23.1, v1.23.0, v1.22.0 |
|
#
619937c7 |
| 28-Jun-2018 |
Ben Noordhuis |
unix,win: merge handle flags Some long overdue refactoring that unifies more of the UNIX and Windows backends. PR-URL: https://github.com/libuv/libuv/pull/1904 Reviewed-By:
unix,win: merge handle flags Some long overdue refactoring that unifies more of the UNIX and Windows backends. PR-URL: https://github.com/libuv/libuv/pull/1904 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
show more ...
|
Revision tags: v1.21.0 |
|
#
4e53af91 |
| 22-May-2018 |
Bert Belder |
win,pipe: fix IPC pipe deadlock This fixes a bug where IPC pipe communication would deadlock when both ends of the pipe are written to simultaneously, and the kernel pipe buffer has
win,pipe: fix IPC pipe deadlock This fixes a bug where IPC pipe communication would deadlock when both ends of the pipe are written to simultaneously, and the kernel pipe buffer has already been filled up by earlier writes. The root cause of the deadlock is that, while writes to an IPC pipe are generally asynchronous, the IPC frame header is written synchronously. So when both ends of the pipe are sending a frame header at the same time, neither will read data off the pipe, causing both header writes to block indefinitely. Additionally, this patch somewhat reduces the spaghetti level in win/pipe.c. Fixes: https://github.com/libuv/libuv/issues/1099 Refs: https://github.com/nodejs/node/issues/7657 Refs: https://github.com/electron/electron/issues/10107 Refs: https://github.com/parcel-bundler/parcel/issues/637 Refs: https://github.com/parcel-bundler/parcel/issues/900 Refs: https://github.com/parcel-bundler/parcel/issues/1137 PR-URL: https://github.com/libuv/libuv/pull/1843 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
show more ...
|
#
9584df25 |
| 29-May-2018 |
Bert Belder |
src,test: fix idiosyncratic comment style Back in the day I wrote comments in a really unusual way. Nowadays it makes my eyes bleed, and clang-format doesn't know how to deal with it.
src,test: fix idiosyncratic comment style Back in the day I wrote comments in a really unusual way. Nowadays it makes my eyes bleed, and clang-format doesn't know how to deal with it. PR-URL: https://github.com/libuv/libuv/pull/1853 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
show more ...
|
#
02e358fa |
| 14-May-2018 |
Tobias Nießen |
src,lib: fix comments PR-URL: https://github.com/libuv/libuv/pull/1840 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By:
src,lib: fix comments PR-URL: https://github.com/libuv/libuv/pull/1840 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
show more ...
|