7673c129 | 24-Aug-2024 |
Viktor Szakats |
build: check OS-native IDN first, then libidn2 If AppleIDN or WinIDN is selected, don't look for libidn2. Do this by moving libidn2 detection after AppleIDN/WinIDN and skipping it if any
build: check OS-native IDN first, then libidn2 If AppleIDN or WinIDN is selected, don't look for libidn2. Do this by moving libidn2 detection after AppleIDN/WinIDN and skipping it if any of them was selected. Also: - disable AppleIDN by default with autotools to sync behaviour with CMake. - limit WinIDN checks to native Windows with autotools, as with CMake. Before this patch libidn2 was detected by default even if AppleIDN or WinIDN was explicitly selected. libidn2 wasn't used in the build, but it was left enabled as a dependency and appeared in `libcurl.pc` and `curl-config`. Closes #14674
show more ...
|
3307b981 | 24-Aug-2024 |
Viktor Szakats |
configure: delete unused `CURL_DEFINE_UNQUOTED` function Unused since ee6992c66a3dd7a1a1e2fbf66ba8d446a28acc8c #12502 Closes #14673 |
dbf5fbd4 | 24-Aug-2024 |
Viktor Szakats |
configure: delete unused `HAVE_OPENSSL3` macro Closes #14672 |
c190338e | 24-Aug-2024 |
Viktor Szakats |
build: delete unused `REQUIRE_LIB_DEPS` Unused since 97aca0971dbe8e1aa7c9660d1e94af3b1298d9ed #5808 Closes #14671 |
573e7e82 | 23-Aug-2024 |
Viktor Szakats |
lib, src: delete stray `curl_` prefix from printf calls Also: - unit1398: delete redundant `curl/mprintf.h` include. Closes #14664 |
8b091380 | 19-Aug-2024 |
Viktor Szakats |
cmake: minor tidy-ups - show `OpenSSL v3+` when detected (as in `./configure`). (this string also makes its way to `curl-config`.) - prefer `unset(VAR)` over `set(VAR)`. Same
cmake: minor tidy-ups - show `OpenSSL v3+` when detected (as in `./configure`). (this string also makes its way to `curl-config`.) - prefer `unset(VAR)` over `set(VAR)`. Same effect, but `unset()` tells the intent unambiguously. https://cmake.org/cmake/help/latest/command/set.html - drop "implementation" from an `option()` description. - FindGSS: replace legacy keyword alias with modern alternative. https://cmake.org/cmake/help/latest/command/get_filename_component.html - move `CURL_STATIC_CRT` logic next to its `option()`. - improve order of `libcurl.pc`/`curl-config` variable init lines. - tests: drop/shorten custom target names. They inflated generated make files by 550KB. Keep target name logic for sync between code snippets. Follow-up to a2ef5d36b3cdec8120a4a9b782d18d58a70d4236 #14660 - clear a variable after use. - restore `STATUS` for `Features:`/`Protocols:` `message()`s: Without it the output goes to stderr, and appears in red in CMake GUI. It doesn't seem possible to show a line on stdout without leading underscores to match `curl -V` and `./configure` output. Partial revert of acbc6b703f6b0ee568d053f6f2565fbc107b5fd3 #14197 - WindowsCache: move `HAVE_LINUX_TCP_H` into the header group. - move strings to the same line as their `STRING` keyword. - formatting in generated code. - delete bogus comment. - unfold lines for readability. - fix a too long line. (for cmakelint) - missing quotes, whitespace, comments. Closes #14610
show more ...
|
5d4d1c71 | 24-Aug-2024 |
renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> |
GHA: update CI dependencies - update github/codeql-action digest to 2c779ab - update awslabs/aws-lc to v1.34.2 - update ngtcp2/nghttp3 to v1.5.0 - update ngtcp2/ngtcp2 to v1.7.0
GHA: update CI dependencies - update github/codeql-action digest to 2c779ab - update awslabs/aws-lc to v1.34.2 - update ngtcp2/nghttp3 to v1.5.0 - update ngtcp2/ngtcp2 to v1.7.0 Closes #14638 Closes #14639 Closes #14675 Closes #14676
show more ...
|
dacd483a | 23-Aug-2024 |
Daniel Stenberg |
README: refresh - call them "manpages", not "man pages" and drop the .1 and .3 - replace link to "manual" with a link to everything curl - remove the link to the FAQ - add a new
README: refresh - call them "manpages", not "man pages" and drop the .1 and .3 - replace link to "manual" with a link to everything curl - remove the link to the FAQ - add a new "open source "subtitle for the license link, and rephrase - mention and link GitHub services in the contact section - rename the "git" subtitle to "source code" - shorten the source code section somewhat Closes #14663
show more ...
|
6f352264 | 23-Aug-2024 |
Dan Fandrich |
tests: tweak use of impacket in smbserver The missing message only uses a single line now and has a consistent prefix making it easier for log parsers to skip. Remove a precheck test
tests: tweak use of impacket in smbserver The missing message only uses a single line now and has a consistent prefix making it easier for log parsers to skip. Remove a precheck test looking for impacket in test1451 because it's incomplete, unnecessary and in the wrong layer; the test harness will automatically discover that the smbserver won't start and the test was only checking a single dependency. Also update the tests README to no longer mention Python 2. The servers were switched to Python 3 several years ago and no attempt is being made to maintain Python 2 compatibility Closes #14669
show more ...
|
4b791dca | 23-Aug-2024 |
Viktor Szakats |
GHA/macos: ignore flaky tests 2041 and 2037 - FAIL 2037: 'simple HTTPS GET with PEM public key pinning' HTTPS, HTTP GET, PEM certificate https://github.com/curl/curl/actions/runs/10529
GHA/macos: ignore flaky tests 2041 and 2037 - FAIL 2037: 'simple HTTPS GET with PEM public key pinning' HTTPS, HTTP GET, PEM certificate https://github.com/curl/curl/actions/runs/10529314166/job/29176801513?pr=14658 - FAIL 2041: 'simple HTTPS GET with base64-sha256 public key pinning' HTTPS, HTTP GET, PEM certificate https://github.com/curl/curl/actions/runs/10529181645/job/29176408976#step:16:4363 https://github.com/curl/curl/actions/runs/10529019749/job/29175882809#step:13:5235 https://github.com/curl/curl/actions/runs/10528920874/job/29175559070#step:16:4363 https://github.com/curl/curl/actions/runs/10528759817/job/29175043048#step:16:4274 https://github.com/curl/curl/actions/runs/10525250422/job/29163662307#step:16:4366 https://github.com/curl/curl/actions/runs/10525250422/job/29163662602#step:13:3569 Happened with cmake, autotools, gcc, clang and various TLS backends. Follow-up to fa461b4eff52b413f88debf543b5350a6cef4724 #14486 Closes #14667
show more ...
|
8aadb830 | 23-Aug-2024 |
Viktor Szakats |
GHA/windows: add Linux -> mingw-w64 cross-build (cmake, autotools) Also: - add a line to CMake log output showing the host and target OS and CPU when doing cross-builds. - redu
GHA/windows: add Linux -> mingw-w64 cross-build (cmake, autotools) Also: - add a line to CMake log output showing the host and target OS and CPU when doing cross-builds. - reduce excessive timeout for `curl -V` steps. Closes #14661
show more ...
|
a2ef5d36 | 22-Aug-2024 |
Viktor Szakats |
cmake: sync code between test/example targets - reuse local variable names. - sync `PROJECT_LABEL`, add where missing. - namespace all target names. - bind header directories to
cmake: sync code between test/example targets - reuse local variable names. - sync `PROJECT_LABEL`, add where missing. - namespace all target names. - bind header directories to each target. - tests/server: limit `CURL_STATICLIB` to Windows (as in autotools.) - drop functions with a single caller. Closes #14660
show more ...
|
f73f6bf9 | 22-Aug-2024 |
Viktor Szakats |
GHA: add yamlcheck Uses `yamllint`. Also: - fix warning for existing YAML files: ``` [truthy] truthy value should be one of [false, true] ``` Closes #
GHA: add yamlcheck Uses `yamllint`. Also: - fix warning for existing YAML files: ``` [truthy] truthy value should be one of [false, true] ``` Closes #14650
show more ...
|
5629bb7c | 23-Aug-2024 |
Dan Fandrich |
CI: consolidate workflows for source and docs check A bunch of tiny jobs that run various source or documentation checks are consolidated into two workflow files: checksrc.yml and checkd
CI: consolidate workflows for source and docs check A bunch of tiny jobs that run various source or documentation checks are consolidated into two workflow files: checksrc.yml and checkdocs.yml. This reduces the proliferation of new files containing one-line checks and brings those that operate similarly together for better reasoning about them. The man-examples check is also now running again for the first time in 7 months. Various calls to find, xargs and git ls-files are changed where possible to use NUL line terminators in pipes to avoid issues with oddly-named files that might find their way into the repo. Closes #14654
show more ...
|
6429ce8e | 23-Aug-2024 |
Dan Fandrich |
docs: fix some examples in man pages The man-examples job hasn't been running for a few months to verify that these compile, so some mistakes slipped in. Ref: #14654 |
4d5d171a | 23-Aug-2024 |
Daniel Stenberg |
RELEASE-NOTES: synced |
d1394a00 | 23-Aug-2024 |
Daniel Stenberg |
urlapi: verify URL *decoded* hostname when set It was previously wrongly verifying the input in its URL encoded format when setting the hostname component with curl_url_set(), so it wron
urlapi: verify URL *decoded* hostname when set It was previously wrongly verifying the input in its URL encoded format when setting the hostname component with curl_url_set(), so it wrongly rejected '%'. Now it URL decodes the name appropriately before the check. Added tests to lib1560 to verify that a fine %-code is okay and that a bad %-code (that decodes to '%') is rejected. Regression from 0a0c9b6dfa0de4a4c, shipped in 8.0.0 Fixes #14656 Reported-by: Venkat Krishna R Closes #14657
show more ...
|
fa461b4e | 07-Aug-2024 |
Aki <75532970+AkiSakurai@users.noreply.github.com> |
GHA/macos: enable HTTPS tests with stunnel - Install stunnel. - Regenerate certificates (as SecureTransport requires a validity period less than 398 days). - Restart
GHA/macos: enable HTTPS tests with stunnel - Install stunnel. - Regenerate certificates (as SecureTransport requires a validity period less than 398 days). - Restart server if it is unresponsive. - Do not hardcode the SHA-256 base64 public pinned key. - Ignore test 313 as SecureTransport does not support crl file. - Ignore tests 1631 and 1632 as SecureTransport is not yet able to shut down FTP over HTTPS gracefully. - Add a CMake target for generating certificates. Closes #14486
show more ...
|
7c0b6eb3 | 22-Aug-2024 |
Viktor Szakats |
cmake: respect cflags/libdirs of native pkg-config detections In Find modules with native pkg-config detection (libgsasl, libidn2, libssh, libuv, nettle) use the C compiler flags returne
cmake: respect cflags/libdirs of native pkg-config detections In Find modules with native pkg-config detection (libgsasl, libidn2, libssh, libuv, nettle) use the C compiler flags returned by pkg-config. Also use the library paths, and return the pathless library names. Also: - add these library paths to `libcurl.pc`/`curl-config`. - fix libgsasl detection to use the detected header directory. FindGSS already did this before this patch. Fixes #14641 Closes #14652
show more ...
|
4f09967a | 22-Aug-2024 |
Viktor Szakats |
cmake/FindGSS: bring closer to other Find modules - add pkg-config-specific 'Found' message to the Find module. - update non-pkg-config 'Found' message to show the flavour instead o
cmake/FindGSS: bring closer to other Find modules - add pkg-config-specific 'Found' message to the Find module. - update non-pkg-config 'Found' message to show the flavour instead of the library name. (= the first value listed after `REQUIRED_VARS`) - delete extra 'Found' message from `CMakeLists.txt`. - rename internal result variables to match with default pkg-config names, in preparation of introducing them in other Find modules: - `GSS_LINK_DIRECTORIES` -> `GSS_LIBRARY_DIRS` - `GSS_LINKER_FLAGS` -> `GSS_LDFLAGS` - `GSS_COMPILER_FLAGS` -> `GSS_CFLAGS` Ref: #14652 Closes #14651
show more ...
|
df15d9ff | 23-Aug-2024 |
Jan Venekamp <1422460+jan2000@users.noreply.github.com> |
gha labeler: make labeler.yml human-readable Split the strings containing the globs over multiple lines, with each line having one glob. Closes #14649 |
dbc4b707 | 23-Aug-2024 |
Daniel Stenberg |
FEATURES.md: fix typo Fixes #14653 Reported-by: Jason Hood Closes #14655 |
3b057d4b | 21-Aug-2024 |
Daniel Stenberg |
test1521: verify setting options to NULL better Previously this test allowed several error values when setting options. This made this test miss #14629. Now, errors are generall
test1521: verify setting options to NULL better Previously this test allowed several error values when setting options. This made this test miss #14629. Now, errors are generally not accepted for setopts: - numerical setopts accept CURLE_BAD_FUNCTION_ARGUMENT for funny input - the first setopt to an option accepts CURLE_NOT_BUILT_IN or CURLE_UNKNOWN_OPTION for when they are disabled/not built-in - there is an allowlist concept for some return code for some variables, managed at the top of the mk-lib1521.pl script In curl.h: remove the OBSOLETE named values from the setopt list. Closes #14634
show more ...
|
17dde539 | 22-Aug-2024 |
Daniel Stenberg |
setopt: make CURLOPT_TFTP_BLKSIZE accept bad values ... and just move them into the accepted range. Like how buffersize and a few other options work. Closes #14634 |
05609bac | 22-Aug-2024 |
Daniel Stenberg |
setopt: let CURLOPT_ECH set to NULL reset to default Because NULL is documented as default and most options that take pointers accept NULL to reset back to internal default. Clo
setopt: let CURLOPT_ECH set to NULL reset to default Because NULL is documented as default and most options that take pointers accept NULL to reset back to internal default. Closes #14634
show more ...
|