80eb71a3 | 17-Apr-2022 |
Balakrishnan Balasubramanian <3070606-balki@users.noreply.gitlab.com> |
tests: refactor server/socksd.c to support --unix-socket Closes #8687 |
77a6bf84 | 17-Apr-2022 |
Emanuele Torre |
tool_paramhlp: use feof(3) to identify EOF correctly when using fread(3) This loop was using the number of bytes read from the file as condition to keep reading. From Linux's fr
tool_paramhlp: use feof(3) to identify EOF correctly when using fread(3) This loop was using the number of bytes read from the file as condition to keep reading. From Linux's fread(3) man page: > On success, fread() and fwrite() return the number of items read or > written. This number equals the number of bytes transferred only when > size is 1. If an error occurs, or the end of the file is reached, the > return value is a short item count (or zero). > > The file position indicator for the stream is advanced by the number > of bytes successfully read or written. > > fread() does not distinguish between end-of-file and error, and > callers must use feof(3) and ferror(3) to determine which occurred. This means that nread!=0 doesn't make much sense as an end condition for the loop: nread==0 doesn't necessarily mean that EOF has been reached or an error has occured (but that is usually the case) and nread!=0 doesn't necessarily mean that EOF has not been reached or that no read errors have occured. feof(3) and ferror(3) should be uses when using fread(3). Currently curl has to performs an extra fread(3) call to get a return value equal to 0 to stop looping. This usually "works" (even though nread==0 shouldn't be interpreted as EOF) if stdin is a pipe because EOF usually marks the "real" end of the stream, so the extra fread(3) call will return immediately and the extra read syscall won't be noticeable: bash-5.1$ strace -e read curl -s -F file=@- 0x0.st <<< a 2>&1 | > tail -n 5 read(0, "a\n", 4096) = 2 read(0, "", 4096) = 0 read(0, "", 4096) = 0 http://0x0.st/oRs.txt +++ exited with 0 +++ bash-5.1$ But this doesn't work if curl is reading from stdin, stdin is a terminal, and the EOF is being emulated using a shell with ^D. Two consecutive ^D will be required in this case to actually make curl stop reading: bash-5.1$ curl -F file=@- 0x0.st a ^D^D http://0x0.st/oRs.txt bash-5.1$ A possible workaround to this issue is to use a program that handles EOF correctly to indirectly send data to curl's stdin: bash-5.1$ cat - | curl -F file=@- 0x0.st a ^D http://0x0.st/oRs.txt bash-5.1$ This patch makes curl handle EOF properly when using fread(3) in file2memory() so that the workaround is not necessary. Since curl was previously ignoring read errors caused by this fread(3), ferror(3) is also used in the condition of the loop: read errors and EOF will have the same meaning; this is done to somewhat preserve the old behaviour instead of making the command fail when a read error occurs. Closes #8701
show more ...
|
53399c72 | 17-Apr-2022 |
Daniel Stenberg |
gen.pl: change wording for mutexed options Instead of saying "This option overrides NNN", now say "This option is mutually exclusive to NNN" in the generated man page ouput, as the o
gen.pl: change wording for mutexed options Instead of saying "This option overrides NNN", now say "This option is mutually exclusive to NNN" in the generated man page ouput, as the option does not in all cases actually override the others but they are always mutually exclusive. Ref: #8704 Closes #8716
show more ...
|
01a1697a | 17-Apr-2022 |
Daniel Stenberg |
curl: error out if -T and -d are used for the same URL As one implies PUT and the other POST, both cannot be used simultaneously. Add test 378 to verify. Reported-by: B
curl: error out if -T and -d are used for the same URL As one implies PUT and the other POST, both cannot be used simultaneously. Add test 378 to verify. Reported-by: Boris Verkhovskiy Fixes #8704 Closes #8715
show more ...
|
6968fb9d | 16-Apr-2022 |
Daniel Stenberg |
lib: remove exclamation marks ... from infof() and failf() calls. Make them less attention seeking. Closes #8713 |
36e09dc3 | 15-Apr-2022 |
Daniel Stenberg |
fail.d: tweak the description Reviewed-by: Daniel Gustafsson Suggested-by: Robert Charles Muir Ref: https://twitter.com/rcmuir/status/1514915401574010887 Closes #8714 |
fe87e10c | 15-Apr-2022 |
Daniel Gustafsson |
docs: Fix missing semicolon in example code Multiple share examples were missing a semicolon on the line defining the CURLSHcode variable. Closes: #8697 Reported-by: Michael
docs: Fix missing semicolon in example code Multiple share examples were missing a semicolon on the line defining the CURLSHcode variable. Closes: #8697 Reported-by: Michael Kaufmann <mail@michael-kaufmann.ch> Reviewed-by: Daniel Stenberg <daniel@haxx.se>
show more ...
|
34bbf964 | 14-Apr-2022 |
Daniel Gustafsson |
infof: consistent capitalization of warning messages Ensure that all infof calls with a warning message are capitalized in the same way. At some point we should probably set up a style-
infof: consistent capitalization of warning messages Ensure that all infof calls with a warning message are capitalized in the same way. At some point we should probably set up a style- guide for infof but until then let's aim for a little consistenncy where we can. Closes: #8711 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
show more ...
|
af2dac82 | 14-Apr-2022 |
Daniel Gustafsson |
RELEASE-NOTES: synced |
0a6eebfc | 14-Apr-2022 |
Matteo Baccan |
perl: removed a double semicolon at end of line Remove double semicolons at end of line in Perl code. Closes: #8709 Reviewed-by: Daniel Gustafsson <daniel@yesql.se> |
b7c0bd68 | 11-Apr-2022 |
Daniel Gustafsson |
curl_easy_header: fix typos in documentation Closes: #8694 Reviewed-by: Daniel Stenberg <daniel@haxx.se> |
a34a8480 | 09-Apr-2022 |
Marcel Raad |
appveyor: add Cygwin build Closes https://github.com/curl/curl/pull/8693 |
Revision tags: tiny-curl-7_72_0, curl-7_72_0, curl-7_71_1, curl-7_71_0, curl-7_70_0, curl-7_69_1, curl-7_69_0, curl-7_68_0, curl-7_67_0, curl-7_66_0, curl-7_65_3, curl-7_65_2, curl-7_65_1, curl-7_65_0, curl-7_64_1 |
|
84be9996 | 02-Mar-2019 |
Marcel Raad |
appveyor: only add MSYS2 to PATH where required Closes https://github.com/curl/curl/pull/8693 |
cd29c165 | 10-Apr-2022 |
Tatsuhiro Tsujikawa |
ngtcp2: fix memory leak Closes #8691 |
fa25dab7 | 10-Apr-2022 |
Tatsuhiro Tsujikawa |
ngtcp2: remove remote_addr which is not used in a meaningful way Closes #8689 |
f15beb6f | 10-Apr-2022 |
Tatsuhiro Tsujikawa |
ngtcp2: enlarge H3_SEND_SIZE Make h3_SEND_SIZE larger because current value (20KiB) is too small for the high latency environment. Closes #8690 |
990bfdd7 | 10-Apr-2022 |
Tatsuhiro Tsujikawa |
ngtcp2: fix HTTP/3 upload stall and avoid busy loop This commit fixes HTTP/3 upload stall if upload data is larger than H3_SEND_SIZE. Only check writability of socket if a stream is
ngtcp2: fix HTTP/3 upload stall and avoid busy loop This commit fixes HTTP/3 upload stall if upload data is larger than H3_SEND_SIZE. Only check writability of socket if a stream is writable to avoid busy loop when QUIC flow control window is filled up, or upload buffer is full. Closes #8688
show more ...
|
37492ebb | 10-Apr-2022 |
Nick Banks |
msh3: add support for QUIC and HTTP/3 using msh3 Considered experimental, as the other HTTP/3 backends. Closes #8517 |
7befbe9c | 10-Apr-2022 |
Daniel Stenberg |
TODO: "SFTP with SCP://" |
7e99db82 | 07-Apr-2022 |
Daniel Stenberg |
GHA: move bearssl jobs over from zuul Closes #8684 |
9e8c8b14 | 07-Apr-2022 |
Daniel Stenberg |
data/DISABLED: disable test 313 on bearssl builds Closes #8684 |
71a0e053 | 07-Apr-2022 |
Daniel Stenberg |
runtests: add 'bearssl' as testable feature Closes #8684 |
51d27121 | 07-Apr-2022 |
Daniel Stenberg |
GHA: add openssl3 jobs moved over from zuul Closes #8683 |
fbba7dd7 | 06-Apr-2022 |
Daniel Stenberg |
schannel: remove dead code that will never run As the condition can't ever evaluate true Reported-by: Andrey Alifanov Ref: #8675 Closes #8677 |
d4cf98bb | 06-Apr-2022 |
Daniel Stenberg |
connecache: remove duplicate connc->closure_handle check The superfluous extra check could cause analyzer false positives and doesn't serve any purpose. Closes #8676 |