34555724 | 15-May-2024 |
Stefan Eissing |
pytest: fixes for recent python, add FTP tests Fixes: - in uds tests, abort also silently on os errors - be conservative on the h3 goaway duration - detect curl debug build and u
pytest: fixes for recent python, add FTP tests Fixes: - in uds tests, abort also silently on os errors - be conservative on the h3 goaway duration - detect curl debug build and use in checks - fix caddy version check for slight difference under linux - set caddy default path fitting for linux - fix deprecation warnings in valid time checks FTP tests: - add '--with-test-vsftpd=path' to configure - use vsftpd default path suitable for linux - add test_30 with plain FTP tests - add test_31 with --ssl-reqd FTP tests - add vsftpd to linux GHA for pytest workflows Closes #13661
show more ...
|
afffd4c5 | 17-May-2024 |
Stefan Eissing |
rustls: fix handshake done handling - rustls report it has finished the TLS handshake *before* all relevant data has been sent off, e.g. it FINISHED message - On connections the se
rustls: fix handshake done handling - rustls report it has finished the TLS handshake *before* all relevant data has been sent off, e.g. it FINISHED message - On connections the send data immediately, this was never noticed as the FINISHED in rustls buffers was send with the app data - On passive FTP connections, curl does not send any data after the handshake, leaving FINISHED unsent and the server never responded as it was waiting on this. Closes #13686
show more ...
|
13ca4386 | 17-May-2024 |
Daniel Stenberg |
x509asn1: return error on missing OID to avoid crash when dereferencing a NULL pointer. Reported-by: Trzik on github Patch-by: Trzik on github Fixes #13684 Closes #13685 |
6d1e144f | 17-May-2024 |
Daniel Stenberg |
CURLOPT_WRITEFUNCTION.md: fix the callback proto in the example Reported-by: Michael Litwak Fixes #13681 Closes #13687 |
1a895383 | 13-May-2024 |
Viktor Szakats |
src: tidy up types, add necessary casts Cherry-picked from #13489 Closes #13614 |
d0728c91 | 11-May-2024 |
Viktor Szakats |
lib: fix compiler warnings (gcc) Seen when setting `ENABLE_DEBUG=ON` and `-DDEBUGBUILD` for mingw-w64 gcc 13.2.0 CMake unity builds in 'Release' configurations. ``` curl/lib
lib: fix compiler warnings (gcc) Seen when setting `ENABLE_DEBUG=ON` and `-DDEBUGBUILD` for mingw-w64 gcc 13.2.0 CMake unity builds in 'Release' configurations. ``` curl/lib/curl_gethostname.c:71:5: error: 'strncpy' specified bound 1025 equals destination size [-Werror=stringop-truncation] 71 | strncpy(name, force_hostname, namelen); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from curl/_bld/lib/CMakeFiles/libcurl_object.dir/Unity/unity_0_c.c:175: In function 'hostcache_timestamp_remove', inlined from 'Curl_hash_clean_with_criterium' at curl/lib/hash.c:265:19, inlined from 'Curl_hash_clean_with_criterium' at curl/lib/hash.c:247:1, inlined from 'hostcache_prune' at curl/lib/hostip.c:228:3, inlined from 'Curl_hostcache_prune' at curl/lib/hostip.c:256:21: curl/lib/hostip.c:205:12: error: 'now' may be used uninitialized [-Werror=maybe-uninitialized] 205 | time_t age = prune->now - c->timestamp; | ^~~ curl/lib/hostip.c: In function 'Curl_hostcache_prune': curl/lib/hostip.c:241:10: note: 'now' was declared here 241 | time_t now; | ^~~ In function 'hostcache_timestamp_remove', inlined from 'fetch_addr' at curl/lib/hostip.c:310:8: curl/lib/hostip.c:205:23: error: 'user.now' may be used uninitialized [-Werror=maybe-uninitialized] 205 | time_t age = prune->now - c->timestamp; | ~~~~~^~~~~ curl/lib/hostip.c: In function 'fetch_addr': curl/lib/hostip.c:304:33: note: 'user' declared here 304 | struct hostcache_prune_data user; | ^~~~ In file included from curl/_bld/lib/CMakeFiles/libcurl_object.dir/Unity/unity_0_c.c:40: curl/lib/cf-socket.c: In function 'cf_socket_send': curl/lib/cf-socket.c:1294:10: error: 'c' may be used uninitialized [-Werror=maybe-uninitialized] 1294 | if(c >= ((100-ctx->wblock_percent)*256/100)) { | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ curl/lib/cf-socket.c:1292:19: note: 'c' was declared here 1292 | unsigned char c; | ^ In file included from curl/_bld/lib/CMakeFiles/libcurl_object.dir/Unity/unity_0_c.c:364: In function 'tftp_state_timeout', inlined from 'tftp_multi_statemach' at curl/lib/tftp.c:1230:27: curl/lib/tftp.c:1208:5: error: 'current' may be used uninitialized [-Werror=maybe-uninitialized] 1208 | if(current > state->rx_time + state->retry_time) { | ^ curl/lib/tftp.c: In function 'tftp_multi_statemach': curl/lib/tftp.c:1192:10: note: 'current' was declared here 1192 | time_t current; | ^~~~~~~ ``` Ref: https://ci.appveyor.com/project/curlorg/curl/builds/49792835/job/91c8dj5qb36spfe0#L112 Ref: https://github.com/curl/curl/actions/runs/9082968838/job/24960616145#step:12:62 Ref: #13592 Closes #13643
show more ...
|
fd0d2ed7 | 13-May-2024 |
Andrew |
wakeup_create: use FD_CLOEXEC/SOCK_CLOEXEC for `pipe()`/`socketpair()` Fixes #13618 Closes #13625 |
6eee810d | 16-May-2024 |
Stefan Eissing |
rustls: fix partial send handling When TLS bytes could not completely sent off, the amount of plain bytes already added to rustls were forgotten. This lead to send those byte duplica
rustls: fix partial send handling When TLS bytes could not completely sent off, the amount of plain bytes already added to rustls were forgotten. This lead to send those byte duplicate, corrupting the request send to the server. Closes #13676
show more ...
|
dad8c1e3 | 16-May-2024 |
Stefan Eissing |
pytest: add DELETE tests, check server version - add tests for DELETE working - check apache version in keepalive test - fix some comments Closes #13679 |
4c46e277 | 16-May-2024 |
Juliusz Sosinowicz |
vquic-tls: use correct cert name check API for wolfSSL wolfSSL_X509_check_host checks the peer name against the alt names and the common name. Fixes #13487 Closes #13680 |
9e2bd56e | 16-May-2024 |
Viktor Szakats |
cmake: initialize `BUILD_TESTING` before first use Before this patch `BUILD_TESTING` was used once, then initialized, then used again. This caused the `curlu` library not being built whe
cmake: initialize `BUILD_TESTING` before first use Before this patch `BUILD_TESTING` was used once, then initialized, then used again. This caused the `curlu` library not being built when relying on an implicit `BUILD_TESTING=ON` setting, and ending up with a link error when building the `testdeps` target. It did not cause issues when `BUILD_TESTING` was explicitly set. Move the initialization before the first use to fix it. Regression from aace27b0965c10394544d1dacc9c2cb2fe0de3d3 #12287 Closes #13668
show more ...
|
9b802e2d | 16-May-2024 |
Daniel Stenberg |
libtest: 2308 verifies CURLE_WRITE_ERROR after write callback error Verifies that the issue in #13669 actually is fixed. This return code is what the CURLOPT_WRITEFUNCTION manpage docume
libtest: 2308 verifies CURLE_WRITE_ERROR after write callback error Verifies that the issue in #13669 actually is fixed. This return code is what the CURLOPT_WRITEFUNCTION manpage documents should be returned. This code is mostly from the Source-written-by: Trumeet on github Closes #13671
show more ...
|
7c5ad6d2 | 15-May-2024 |
Antoine Bollengier <44288655+b5i@users.noreply.github.com> |
socketpair: fix compilation when USE_UNIX_SOCKETS is not defined Closes #13666 |
df4a8c76 | 16-May-2024 |
Stefan Eissing |
rustsls: fix error code on receive - use CURLE_RECV_ERROR instead of CURLE_READ_ERROR when receiving data fails. Closes #13670 |
c7b0fa41 | 16-May-2024 |
Max Dymond |
ci: disable Renovate dashboard The Renovate dashboard insists on an open issue, which is a problem. Disable the dashboard. Status can still be seen at https://developer.mend.io/githu
ci: disable Renovate dashboard The Renovate dashboard insists on an open issue, which is a problem. Disable the dashboard. Status can still be seen at https://developer.mend.io/github/curl/curl. Fixes #13630 Closes #13673
show more ...
|
7dc376aa | 16-May-2024 |
Daniel Stenberg |
RELEASE-NOTES: synced |
7ec3db1d | 15-May-2024 |
renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> |
GHA: update awslabs/aws-lc to v1.27.0 Closes #13667 |
76dba790 | 15-May-2024 |
Daniel Stenberg |
curl_easy_pause.md: use correct defines in example Spotted-by: Harry Sintonen Closes #13664 |
77ac610d | 12-May-2024 |
Viktor Szakats |
appveyor: more tidy-ups - use `--disable` when calling `curl --version`. Just in case. - use single-quotes for a constant. Closes #13662 |
d927ab0a | 15-May-2024 |
Viktor Szakats |
reuse: migrate standalone license file to dep5 Follow-up to 73a36021207284ad2b4340ffde34a51b0ba4d47a Closes #13660 |
ec498695 | 15-May-2024 |
Viktor Szakats |
appveyor: guard against crash-build with VS2008 The combination of `-DDEBUGBUILD`, a shared `curl.exe`, and the VS2008 compiler creates a `curl.exe` segfaulting on startup: ```
appveyor: guard against crash-build with VS2008 The combination of `-DDEBUGBUILD`, a shared `curl.exe`, and the VS2008 compiler creates a `curl.exe` segfaulting on startup: ``` + _bld/src/curl.exe --version ./appveyor.sh: line 122: 793 Segmentation fault "${curl}" --version Command exited with code 139 ``` Ref: https://ci.appveyor.com/project/curlorg/curl/builds/49817266/job/651iy6qn1e238pqj#L191 Add job that triggers the issue and add the necessary logic to skip running the affected `curl.exe`. Ref: #13592 Closes #13654
show more ...
|
7398037a | 15-May-2024 |
renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> |
GHA: pin dependencies Closes #13628 |
17fbed20 | 15-May-2024 |
Orgad Shaneh |
socket: remove redundant call to getsockname The result "add" is unused. Closes #13655 |
6ce1d6f8 | 14-May-2024 |
renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> |
CI: renovate updates - GHA: update actions/checkout action to v4 - GHA: update wolfSSL/wolfssh to v1.4.17 - GHA: update wolfSSL/wolfssl to v5.7.0 - Update the regex config in ren
CI: renovate updates - GHA: update actions/checkout action to v4 - GHA: update wolfSSL/wolfssh to v1.4.17 - GHA: update wolfSSL/wolfssl to v5.7.0 - Update the regex config in renovate.json Closes #13632 Closes #13641 Closes #13658 Closes #13659
show more ...
|
2f50b2d9 | 14-May-2024 |
Max Dymond |
ci: fix renovate config for WolfSSL/WolfSSH tagging scheme WolfSSL/WolfSSH use a different versioning scheme; stable builds end with `-stable`. Renovate requires some extra configura
ci: fix renovate config for WolfSSL/WolfSSH tagging scheme WolfSSL/WolfSSH use a different versioning scheme; stable builds end with `-stable`. Renovate requires some extra configuration to extract the version from these types of tags. Closes #13644
show more ...
|