upload: missing rewind call could make libcurl hang

When an upload is done, there are two places where that can be detected
and only one of them would rewind the input stream - which som

upload: missing rewind call could make libcurl hang

When an upload is done, there are two places where that can be detected
and only one of them would rewind the input stream - which sometimes is
necessary for example when doing NTLM HTTP POSTs and more.

This could then end up libcurl hanging.

Figured-out-by: Isaac Boukris
Reported-by: Anatol Belski

Fixes #741

show more ...

multi: multi_reconnect_request is the former Curl_reconnect_request

now a file local function in multi.c

transfer: Removed redundant HTTP authentication include files

It would also seem that share.h is not required here either as there
are no references to the Curl_share structure or functi

transfer: Removed redundant HTTP authentication include files

It would also seem that share.h is not required here either as there
are no references to the Curl_share structure or functions.

show more ...

URLs: change all http:// URLs to https://

http2: Ensure that http2_handle_stream_close is called

Previously, when HTTP/2 is enabled and used, and stream has content
length known, Curl_read was not called when there was no bytes

http2: Ensure that http2_handle_stream_close is called

Previously, when HTTP/2 is enabled and used, and stream has content
length known, Curl_read was not called when there was no bytes left to
read. Because of this, we could not make sure that
http2_handle_stream_close was called for every stream. Since we use
http2_handle_stream_close to emit trailer fields, they were
effectively ignored. This commit changes the code so that Curl_read is
called even if no bytes left to read, to ensure that
http2_handle_stream_close is called for every stream.

Discussed in https://github.com/bagder/curl/pull/564

show more ...

http redirects: %-encode bytes outside of ascii range

Apparently there are sites out there that do redirects to URLs they
provide in plain UTF-8 or similar. Browsers and wget %-encode su

http redirects: %-encode bytes outside of ascii range

Apparently there are sites out there that do redirects to URLs they
provide in plain UTF-8 or similar. Browsers and wget %-encode such
headers when doing a subsequent request. Now libcurl does too.

Added test 1138 to verify.

Closes #473

show more ...

fread_func: move callback pointer from set to state struct

... and assign it from the set.fread_func_set pointer in the
Curl_init_CONNECT function. This A) avoids that we have code that

fread_func: move callback pointer from set to state struct

... and assign it from the set.fread_func_set pointer in the
Curl_init_CONNECT function. This A) avoids that we have code that
assigns fields in the 'set' struct (which we always knew was bad) and
more importantly B) it makes it impossibly to accidentally leave the
wrong value for when the handle is re-used etc.

Introducing a state-init functionality in multi.c, so that we can set a
specific function to get called when we enter a state. The
Curl_init_CONNECT is thus called when switching to the CONNECT state.

Bug: https://github.com/bagder/curl/issues/346

Closes #346

show more ...

readwrite_data: set a max number of loops

... as otherwise a really fast pipe can "lock" one transfer for some
protocols, like with HTTP/2.

FTP: fix uploading ASCII with unknown size

... don't try to increase the supposed file size on newlines if we don't
know what file size it is!

Patch-by: lzsiga

HTTP: ignore "Content-Encoding: compress"

Currently, libcurl rejects responses with "Content-Encoding: compress"
when CURLOPT_ACCEPT_ENCODING is set to "". I think that libcurl should

HTTP: ignore "Content-Encoding: compress"

Currently, libcurl rejects responses with "Content-Encoding: compress"
when CURLOPT_ACCEPT_ENCODING is set to "". I think that libcurl should
treat the Content-Encoding "compress" the same as other
Content-Encodings that it does not support, e.g. "bzip2". That means
just ignoring it.

show more ...

pretransfer: init state.infilesize here, not in add_handle

... to properly support that options are set to the handle after it is
added to the multi handle.

Bug: http://curl.hax

pretransfer: init state.infilesize here, not in add_handle

... to properly support that options are set to the handle after it is
added to the multi handle.

Bug: http://curl.haxx.se/mail/lib-2015-06/0122.html
Reported-by: Stefan Bühler

show more ...

debug: remove http2 debug leftovers

read_callback: move to SessionHandle from connectdata

With many easy handles using the same connection for multiplexing, it is
important we store and keep the transfer-oriented stuff in

read_callback: move to SessionHandle from connectdata

With many easy handles using the same connection for multiplexing, it is
important we store and keep the transfer-oriented stuff in the
SessionHandle so that callbacks and callback data work fine even when
many easy handles share the same physical connection.

show more ...

transfer: remove erroneous and misleading comment

transfer: Replace __func__ instances with function name

.. also make __func__ replacement in multi.

Prior to this change debug builds would fail to build if the compiler
was bui

transfer: Replace __func__ instances with function name

.. also make __func__ replacement in multi.

Prior to this change debug builds would fail to build if the compiler
was building pre-c99 and didn't support __func__.

show more ...

CURLMOPT_PIPELINE: bit 1 is for multiplexing

http2: force "drainage" of streams

... which is necessary since the socket won't be readable but there is
data waiting in the buffer.

http2: move the mem+len pair to the stream struct

http2: more stream-oriented data, stream ID 0 is for connections

lib/transfer.c: Remove factor of 8 from sleep time calculation

The factor of 8 is a bytes-to-bits conversion factor, but pkt_size and
rate_bps are both in bytes. When using the rate limi

lib/transfer.c: Remove factor of 8 from sleep time calculation

The factor of 8 is a bytes-to-bits conversion factor, but pkt_size and
rate_bps are both in bytes. When using the rate limiting option, curl
waits 8 times too long, and then transfers very quickly until the
average rate reaches the limit. The average rate follows the limit over
time, but the actual traffic is bursty.

Thanks-to: Benjamin Gilbert

show more ...

curl_memory: make curl_memory.h the second-last header file loaded

This header file must be included after all header files except
memdebug.h, as it does similar memory function redefini

curl_memory: make curl_memory.h the second-last header file loaded

This header file must be included after all header files except
memdebug.h, as it does similar memory function redefinitions and can be
similarly affected by conflicting definitions in system or dependent
library headers.

show more ...

checksrc: use space after comma

checksrc: use space before paren in "return (expr);"

mprintf.h: remove #ifdef CURLDEBUG

... and as a consequence, introduce curl_printf.h with that re-define
magic instead and make all libcurl code use that instead.

Curl_pretransfer: reset expected transfer sizes

Reported-by: Mohammad AlSaleh
Bug: http://curl.haxx.se/mail/lib-2015-01/0065.html