oauth2: Re-factored OAuth 2.0 state variable

sasl: Don't choose OAuth 2.0 if mechanism not advertised

Regression from commit 9e8ced9890 which meant if --oauth2-bearer was
specified but the SASL mechanism wasn't supported by the ser

sasl: Don't choose OAuth 2.0 if mechanism not advertised

Regression from commit 9e8ced9890 which meant if --oauth2-bearer was
specified but the SASL mechanism wasn't supported by the server then
the mechanism would be chosen.

show more ...

oauth2: Introduced support for host and port details

Added support to the OAuth 2.0 message function for host and port, in
order to accommodate the official OAUTHBEARER SASL mechanism wh

oauth2: Introduced support for host and port details

Added support to the OAuth 2.0 message function for host and port, in
order to accommodate the official OAUTHBEARER SASL mechanism which is
to be added shortly.

show more ...

oauth2: Don't use XAUTH2 in OAuth 2.0 function name

oauth2: Don't use XOAUTH2 in OAuth 2.0 variables

sasl: Updated SPN variables and comments for consistency

In places the "host name" and "realm" variable was referred to as
"instance" whilst in others it was referred to as "host".

sasl_sspi: Populate domain from the realm in the challenge

Without this, SSPI based digest auth was broken.

Bug: https://github.com/bagder/curl/pull/141.patch

curl_memory: make curl_memory.h the second-last header file loaded

This header file must be included after all header files except
memdebug.h, as it does similar memory function redefini

curl_memory: make curl_memory.h the second-last header file loaded

This header file must be included after all header files except
memdebug.h, as it does similar memory function redefinitions and can be
similarly affected by conflicting definitions in system or dependent
library headers.

show more ...

free: instead of Curl_safefree()

Since we just started make use of free(NULL) in order to simplify code,
this change takes it a step further and:

- converts lots of Curl_safefre

free: instead of Curl_safefree()

Since we just started make use of free(NULL) in order to simplify code,
this change takes it a step further and:

- converts lots of Curl_safefree() calls to good old free()
- makes Curl_safefree() not check the pointer before free()

The (new) rule of thumb is: if you really want a function call that
frees a pointer and then assigns it to NULL, then use Curl_safefree().
But we will prefer just using free() from now on.

show more ...

mprintf.h: remove #ifdef CURLDEBUG

... and as a consequence, introduce curl_printf.h with that re-define
magic instead and make all libcurl code use that instead.

curl_sasl.c: More code policing

Better use of 80 character line limit, comment corrections and line
spacing preferences.

curl_sasl.c: Fixed compilation warning when cryptography is disabled

curl_sasl.c:1506: warning: unused variable 'chlg'

curl_sasl.c: Fixed compilation warning when verbose debug output disabled

curl_sasl.c:1317: warning: unused parameter 'conn'

sasl: Minor code policing and grammar corrections

sasl: remove XOAUTH2 from default enabled authentication mechanism.

sasl: implement EXTERNAL authentication mechanism.
Its use is only enabled by explicit requirement in URL (;AUTH=EXTERNAL) and
by not setting the password.

curl_sasl: Reinstate the sasl_ prefix for locally scoped functions

Commit 7a8b2885e2 made some functions static and removed the public
Curl_ prefix. Unfortunately, it also removed the sa

curl_sasl: Reinstate the sasl_ prefix for locally scoped functions

Commit 7a8b2885e2 made some functions static and removed the public
Curl_ prefix. Unfortunately, it also removed the sasl_ prefix, which
is the naming convention we use in this source file.

show more ...

curl_sasl: Minor code policing following recent commits

curl_sasl.c: chlglen is not used when cryptography is disabled

curl_sasl.c: Fixed compilation warning when cyptography is disabled

curl_sasl.c:1453: warning C4101: 'serverdata' : unreferenced local
variable

curl_sasl.c: Fixed compilation error when USE_WINDOWS_SSPI defined

curl_sasl.c:1221: error C2065: 'mechtable' : undeclared identifier

This error could also happen for non-SSPI build

curl_sasl.c: Fixed compilation error when USE_WINDOWS_SSPI defined

curl_sasl.c:1221: error C2065: 'mechtable' : undeclared identifier

This error could also happen for non-SSPI builds when cryptography is
disabled (CURL_DISABLE_CRYPTO_AUTH is defined).

show more ...

SASL: make some procedures local-scoped

SASL: common state engine for imap/pop3/smtp

SASL: common URL option and auth capabilities decoders for all protocols

sasl: Tidied up some parameter comments