php_reflection.c: make a bunch of pointers `const` (#15927)

* php_reflection.c: make a bunch of pointers `const`

* _function_closure_string: use %u for unsigned

Co-authored

php_reflection.c: make a bunch of pointers `const` (#15927)

* php_reflection.c: make a bunch of pointers `const`

* _function_closure_string: use %u for unsigned

Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>

* _extension_class_string: make indent pointer `const`

Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>

---------

Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>

show more ...

Fix some misleading comments about `__clone()` never being executed (#15926)

For the `Exception`, `ReflectionClass`, and `ReflectionAttribute` classes, the
`__clone()` method is declared

Fix some misleading comments about `__clone()` never being executed (#15926)

For the `Exception`, `ReflectionClass`, and `ReflectionAttribute` classes, the
`__clone()` method is declared to be private, and the implementation has a
comment that it should never be executed. However, the implementation can be
executed by using a `ReflectionMethod`. Fix the comments to instead explain why
the implementation is needed.

[skip ci]

show more ...

Implement ReflectionProperty::isFinal()

Closes GH-15919

Merge branch 'PHP-8.3'

* PHP-8.3:
Fix GH-15711: SoapClient can't convert BackedEnum to scalar value
Use get_serialization_string_from_zval() in all encoding functions
Intro

Merge branch 'PHP-8.3'

* PHP-8.3:
Fix GH-15711: SoapClient can't convert BackedEnum to scalar value
Use get_serialization_string_from_zval() in all encoding functions
Introduce get_serialization_string_from_zval() and use it in to_xml_string()

show more ...

Fix GH-15711: SoapClient can't convert BackedEnum to scalar value

Allow SoapClient to use the backing value during response serialization.

Closes GH-15803.

Use get_serialization_string_from_zval() in all encoding functions

Introduce get_serialization_string_from_zval() and use it in to_xml_string()

For now this new function only returns a copy of the string, but its
functionality will be expanded by later

Introduce get_serialization_string_from_zval() and use it in to_xml_string()

For now this new function only returns a copy of the string, but its
functionality will be expanded by later commits.
to_xml_string() now uses this function and the memory management is
simplified as well.

show more ...

Fix GH-15910: Assertion failure in ext/dom/element.c

Fix zend_get_property_info_for_slot() for lazy objects (#15855)

zend_get_property_info_for_slot(obj, slot) assumes that 'slot' belongs to 'obj', but that may not be the case for lazy proxies

Fix zend_get_property_info_for_slot() for lazy objects (#15855)

zend_get_property_info_for_slot(obj, slot) assumes that 'slot' belongs to 'obj', but that may not be the case for lazy proxies.

Fortunately, the property info is often already available in path when it is needed.

For other cases, I make zend_get_property_info_for_slot() aware of lazy objects, and add zend_get_property_info_for_slot_self() for cases where the 'slot' is known to belong to the object itself.

Fixes oss-fuzz #71446

show more ...

[skip ci] Fix NEWS section

Implement ReflectionProperty::hasHook[s]

Closes GH-15844

Merge branch 'PHP-8.3'

* PHP-8.3:
Run snmp tests in Windows CI, again

Merge branch 'PHP-8.2' into PHP-8.3

* PHP-8.2:
Run snmp tests in Windows CI, again

Run snmp tests in Windows CI, again

That was broken when CI was moved to GH, since `APPVEYOR_BUILD_FOLDER`
is no longer set; instead we use `GITHUB_WORKSPACE` which has the same
mean

Run snmp tests in Windows CI, again

That was broken when CI was moved to GH, since `APPVEYOR_BUILD_FOLDER`
is no longer set; instead we use `GITHUB_WORKSPACE` which has the same
meaning.

Closes GH-15896.

show more ...

Fix XML serializer errata: xmlns="" serialization should be allowed

The spec doesn't want to serialize xmlns:foo="", but the description of
the step that checks this does not take into a

Fix XML serializer errata: xmlns="" serialization should be allowed

The spec doesn't want to serialize xmlns:foo="", but the description of
the step that checks this does not take into account that xmlns="" must
be allowed. This patch corrects this errata.

Closes GH-15894.

show more ...

Support --with-openssl-argon2 on Windows (GH-15713)

We change the error for ZTS builds to a warning, to not break snapshot
builds which automatically will try to enable OpenSSL password

Support --with-openssl-argon2 on Windows (GH-15713)

We change the error for ZTS builds to a warning, to not break snapshot
builds which automatically will try to enable OpenSSL password hashing.

We also change some messages to better fit building on Windows.

And of course, we cannot easily check whether `OSSL_set_max_threads()`
is actually available; instead we're looking up the function declaration
in its header file.

Co-authored-by: Peter Kokot <peterkokot@gmail.com>

show more ...

Autotools: Fix CS in undefined sanitizer check (#15892)

To prevent possible unused warnings turning into false errors.

ext/gd: enable avif tests on GH-Actions (#15850)

When the avif support was first added (GH-7026), php-src did not
use GitHub Actions. When we moved to GitHub Actions for CI, the
`--w

ext/gd: enable avif tests on GH-Actions (#15850)

When the avif support was first added (GH-7026), php-src did not
use GitHub Actions. When we moved to GitHub Actions for CI, the
`--with-avif` option nor the `libavif-dev` dependencies were not
added.

Cirrus CI still runs the tests, and now that we no longer use
Travis CI, this brings parity to test avif on x64 tests on
GitHub Actions as well.

`libavif-dev` package's x86 builds seem to be missing[^1][^2] on older
Ubuntu versions, so this commit only adds it for x64 builds.

[^1]: https://packages.ubuntu.com/jammy/libavif-dev
[^2]: https://packages.ubuntu.com/noble/libavif-dev

show more ...

Merge branch 'PHP-8.3'

* PHP-8.3:
Add missing returns in ext/date for PHP 8.3+ (#15735)

Add missing returns in ext/date for PHP 8.3+ (#15735)

Issues originally found in #15598

ext/phar: Voidify flush function as it always returns EOL

ext/phar: Move variable to inner scope

ext/phar: Mark constant string as static const

ext/standard: Make char* of php_stristr() const

ext/phar: Use bool instead of int