GH-15976: test current output

So that it is clearer what changes

Merge branch 'PHP-8.3'

* PHP-8.3:
Fix minimal Windows version

Fix minimal Windows version

As of PHP 8.3.0, Windows 8/Server 2012 are the minimum requirement.
However, PR #9104 only updated `_WIN32_WINNT`, but not `WINVER`[1],
`NTDDI_VERSION`[2]

Fix minimal Windows version

As of PHP 8.3.0, Windows 8/Server 2012 are the minimum requirement.
However, PR #9104 only updated `_WIN32_WINNT`, but not `WINVER`[1],
`NTDDI_VERSION`[2] nor the manifest[3].

[1] <https://learn.microsoft.com/en-us/windows/win32/winprog/using-the-windows-headers>
[2] <https://learn.microsoft.com/en-us/windows/win32/winprog/using-the-windows-headers>
[3] <https://learn.microsoft.com/en-us/windows/win32/sbscs/application-manifests>

Closes GH-15975.

show more ...

Merge branch 'PHP-8.3'

* PHP-8.3:
Prevent closing of unrelated handles

Merge branch 'PHP-8.2' into PHP-8.3

* PHP-8.2:
Prevent closing of unrelated handles

Prevent closing of unrelated handles

If our `shmget()` fails for certain reasons, the segment handle is
closed. However, the handle might be reused by Windows, and as such we
must n

Prevent closing of unrelated handles

If our `shmget()` fails for certain reasons, the segment handle is
closed. However, the handle might be reused by Windows, and as such we
must not close it again when shutting down the TSRM.

Closes GH-15984.

show more ...

Make ext/shmop/tests/gh14537.phpt more resilient (GH-15985)

The actual problem is our `shmget()` implementation which does not care
to set `errno` appropriately; that should be fixed, al

Make ext/shmop/tests/gh14537.phpt more resilient (GH-15985)

The actual problem is our `shmget()` implementation which does not care
to set `errno` appropriately; that should be fixed, although mapping
the error conditions to those specified by POSIX might be hard.

For now, we only make the test case more resilient by ignoring the
exact error; "No error" doesn't make sense anyway.

show more ...

Merge branch 'PHP-8.3'

* PHP-8.3:
Fix GH-15908 and GH-15026: leak / assertion failure in streams.c

Merge branch 'PHP-8.2' into PHP-8.3

* PHP-8.2:
Fix GH-15908 and GH-15026: leak / assertion failure in streams.c

Fix GH-15908 and GH-15026: leak / assertion failure in streams.c

This was first reported as a leak in GH-15026, but was mistakingly
believed to be a false positive. Then an assertion was

Fix GH-15908 and GH-15026: leak / assertion failure in streams.c

This was first reported as a leak in GH-15026, but was mistakingly
believed to be a false positive. Then an assertion was added and it got
triggered in GH-15908. This fixes the leak. Upon merging into master the
assertion should be removed as well.

Closes GH-15924.

show more ...

Fix GH-15982: Assertion failure with array_find when references are involved

Closes GH-15983.

ext/bcmath: Check for scale overflow (#15741)

Merge branch 'PHP-8.3'

Merge branch 'PHP-8.2' into PHP-8.3

[skip ci] Remove myself as CODEOWNER

I'm subscribed to the pulls list, so I'm just receiving each notification three
times (GitHub sends to e-mails for each PR, for some reason).

Support bug64159.phpt on Windows CI (GH-15895)

This test queries `extOutput` for the first line of output of the
command which was executed when snmpd started (`HexTest` in snmpd.conf).

Support bug64159.phpt on Windows CI (GH-15895)

This test queries `extOutput` for the first line of output of the
command which was executed when snmpd started (`HexTest` in snmpd.conf).
Since there is no `/bin/sh` on Windows, no command would be run, and as
such we received an empty string. We fix that by dynamically adjusting
snmpd.conf to run a JScript which has the same output as bigtest.

We also make the test diff more helpful in case of failures, where so
far we only would have known that the output had a different message
digest.

show more ...

Merge branch 'PHP-8.3'

* PHP-8.3:
[ci skip] Add labels to PRs with potential ABI breaks

Merge branch 'PHP-8.2' into PHP-8.3

* PHP-8.2:
[ci skip] Add labels to PRs with potential ABI breaks

[ci skip] Add labels to PRs with potential ABI breaks

ABI breaks are not supposed to happen after feature freeze, i.e. when
the PHP API numbers have been bumped. To make it easier to no

[ci skip] Add labels to PRs with potential ABI breaks

ABI breaks are not supposed to happen after feature freeze, i.e. when
the PHP API numbers have been bumped. To make it easier to notice
inadvertent ABI breaks, we automatically add an "ABI break" label to
all PRs which modify public (aka. installed) header files. Some of
these modifications do not constitute an ABI break (e.g. adding a
comment to a header file), but we rely on natural intelligence to sort
that out. That means these labels should be removed manually, if they
are not appropriate, but if they are, the PR should not be merged into
any stable branch. For the master branch, where ABI breaks are
permissible, the labels should still be removed if irrelevant, but kept
when the PR is merged.

Since tests are futile[1], we leave that to further (test) PRs.

[1] <https://github.com/php/php-src/pull/15682#issuecomment-2323060586>

Closes GH-15682.

show more ...

Fix ext/snmp for newer net-snmp versions on Windows (GH-15888)

As of net-snmp 5.8.0, the library defines their own `(v)asprintf()` if
not available on the system. However, PHP also does

Fix ext/snmp for newer net-snmp versions on Windows (GH-15888)

As of net-snmp 5.8.0, the library defines their own `(v)asprintf()` if
not available on the system. However, PHP also does this, so when
building ext/snmp there would be conflicting declarations on Windows.
To avoid this, we explictly define `HAVE_ASPRINTF`, so net-snmp does
not redeclare when its headers are included.

show more ...

Merge branch 'PHP-8.3'

* PHP-8.3:
Fix GH-15918: Assertion failure in ext/spl/spl_fixedarray.c

Fix GH-15918: Assertion failure in ext/spl/spl_fixedarray.c

SplFixedArray should've never get supported in ArrayObject because it's
overloaded, and so that breaks assumptions. This regre

Fix GH-15918: Assertion failure in ext/spl/spl_fixedarray.c

SplFixedArray should've never get supported in ArrayObject because it's
overloaded, and so that breaks assumptions. This regressed in c4ecd82f.

Closes GH-15947.

show more ...

Small optimization in dom_local_name_compare_ex() (#15950)

We can use `memcmp()` directly and skip some of the logic handling
in `zend_binary_strcmp()`. `perf record` shows a reduction f

Small optimization in dom_local_name_compare_ex() (#15950)

We can use `memcmp()` directly and skip some of the logic handling
in `zend_binary_strcmp()`. `perf record` shows a reduction for
`dom_html5_serializes_as_void()` from 3.12% to 0.77%.

show more ...

[ci skip] NEWS + UPGRADING

add ZipArchive::ER_TRUNCATED_ZIP added in libzip 1.11 (#15959)