Fix memory-leak in CLI web server

Closes GH-9680

Signed-off-by: George Peter Banyard <girgias@php.net>

Use PDEATHSIG to kill cli-server workers if parent exists

Closes GH-9476

Respond with HTTP status 405 to DELETE/PUT/PATCH request on a static resource

Co-authored-by: Marin Martuslović <marin.martuslovic@student.uniri.hr>

Respond without body to HEAD request on a static resource

Co-authored-by: Marin Martuslović <marin.martuslovic@student.uniri.hr>

Make pestr[n]dup infallible (#9295)

Fixes GH-9128
Closes GH-9295

Convert client->request.request_uri to zend_string (#9086)

Prevent potential buffer overflow for large value of php_cli_server_workers_max

Fixes #8989.
Closes #9000.

Pre-compute remote address length in CLI SAPI

Refactor registration of variables for the CLI SAPI

Refactor (again) CLI SAPI server_client struct to use zend_string* (#8605)

This time in a way which works under a RC Debug build.

Revert "Refactor CLI SAPI php_cli_server_client struct to use zend_string (#8522)"

This reverts commit 9b19d9043256427b54c65ac5a3b886d03cf06f2d.

This has broken the ZEND_RC_DEBUG bu

Revert "Refactor CLI SAPI php_cli_server_client struct to use zend_string (#8522)"

This reverts commit 9b19d9043256427b54c65ac5a3b886d03cf06f2d.

This has broken the ZEND_RC_DEBUG build.

show more ...

Refactor CLI SAPI php_cli_server_client struct to use zend_string (#8522)

This is a stepping stone in converting more pairs of ``char*`` and ``size_t`` to ``zend_string*`` across the CLI SAP

Refactor CLI SAPI php_cli_server_client struct to use zend_string (#8522)

This is a stepping stone in converting more pairs of ``char*`` and ``size_t`` to ``zend_string*`` across the CLI SAPI.

Also amend the CLI SAPI test setup to output it's content when it crashes/errors so that one can debug ASAN/UBSAN/MSAN violations.

Drive-by MSAN fix.

Co-authored-by: Arnaud Le Blanc <arnaud.lb@gmail.com>

show more ...

Fix Windows build

sapi\cli\php_cli_server.c(2637): warning C4133: 'function': incompatible types - from 'zend_result (__cdecl *)(void *,php_socket_t,int)' to 'int (__cdecl *)(void *,php_sock

Fix Windows build

sapi\cli\php_cli_server.c(2637): warning C4133: 'function': incompatible types - from 'zend_result (__cdecl *)(void *,php_socket_t,int)' to 'int (__cdecl *)(void *,php_socket_t,int)'

Probably a good idea to make GCC complain about these sort of issues too

show more ...

Fix ASAN build

Minimal refactoring of CLI SAPI (#8519)

More specific types, some cleanup and voidifying functions which always return ``SUCCESS``

Refacto php_module_startup() (#8303)

It only ever uses at most 1 additional modules

fix [-Wstrict-prototypes] buid warnings

Use more compact representation for packed arrays.

- for packed arrays we store just an array of zvals without keys.
- the elements of packed array are accessible throuf as ht->arPacked[

Use more compact representation for packed arrays.

- for packed arrays we store just an array of zvals without keys.
- the elements of packed array are accessible throuf as ht->arPacked[i]
instead of ht->arData[i]
- in addition to general ZEND_HASH_FOREACH_* macros, we introduced similar
familied for packed (ZEND_HASH_PACKED_FORECH_*) and real hashes
(ZEND_HASH_MAP_FOREACH_*)
- introduced an additional family of macros to access elements of array
(packed or real hashes) ZEND_ARRAY_ELEMET_SIZE, ZEND_ARRAY_ELEMET_EX,
ZEND_ARRAY_ELEMET, ZEND_ARRAY_NEXT_ELEMENT, ZEND_ARRAY_PREV_ELEMENT
- zend_hash_minmax() prototype was changed to compare only values

Because of smaller data set, this patch may show performance improvement
on some apps and benchmarks that use packed arrays. (~1% on PHP-Parser)

TODO:
- sapi/phpdbg needs special support for packed arrays (WATCH_ON_BUCKET).
- zend_hash_sort_ex() may require converting packed arrays to hash.

show more ...

Fix #81496: CLI server logs wrong request method

Fix null pointer ubsan warning

Don't pass null pointer to memmove, even with zero length.

Fix #78919: CLI server: insufficient cleanup if request startup fails

We need to run the full `php_cli_server_request_shutdown()` in case of
failing `php_cli_server_request_startup()`.

Fix #78919: CLI server: insufficient cleanup if request startup fails

We need to run the full `php_cli_server_request_shutdown()` in case of
failing `php_cli_server_request_startup()`.

Patch contributed by @cataphract.

Closes GH-7322.

show more ...

Return value from ZEND_ATOL

Instead of assigning it as part of the macro itself, which makes
usage quite awkward.

Fix #73630: Built-in Weberver - overwrite $_SERVER['request_uri']

The built-in Webserver's `on_path`, `on_query_string` and `on_url`
callbacks may be called multiple times from the parse

Fix #73630: Built-in Weberver - overwrite $_SERVER['request_uri']

The built-in Webserver's `on_path`, `on_query_string` and `on_url`
callbacks may be called multiple times from the parser; we must not
simply replace the old values, but need to concatenate the new values
instead.

This appears to be tricky for `on_path` due to the path normalization,
so we fail if the function is called again.

The built-in Webserver logs errors during request parsing to stderr,
but this is ignored by the php_cli_server framework, and apparently the
Webserver does not send a resonse at all in such cases (instead of an
4xx). Thus we can only check that a request with an overly long path
fails.

Closes GH-7207.

show more ...

Mark various functions with void arguments.

This fixes a bunch of [-Wstrict-prototypes] warning,
because in C func() and func(void) have different semantics.

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...