Automatically skip ext/opcache tests under --preload

Also skip observer tests, as these will observe the additional
preload file inserted by the test runner.

Skip some tests under --preload

A genuine problem here is that we sometime get different class
casing due interaction with the ZSTR CE cache. Ignore these for
now.

Don't unlink preload file if test failed

Add --bless option to run-tests.php

This runs bless_tests.php on all failed tests.

Make LDAPCONF test work on windows

Rather than using putenv(), use the ENV section. This also
required adding {PWD} support for it.

Fix EXTENSIONS for cgi tests

The extension information needs to be fetched using the cli binary,
not the cgi binary.

Fix null handling in test runner when printing env

Export ENV in .sh file generated by run-tests

Add %0 format to run-tests.php

This format matches against null bytes, and prevents the test
expectation from being interpreted as binary data.

bless_tests.php will automaticall

Add %0 format to run-tests.php

This format matches against null bytes, and prevents the test
expectation from being interpreted as binary data.

bless_tests.php will automatically replace \0 with %0 as well.

show more ...

Adjust run-tests.php to dynamic extension loading

PR #6787 changed the behavior of the `--EXTENSIONS--` section, so that
not yet loaded extensions are dynamically loaded if possible. Ho

Adjust run-tests.php to dynamic extension loading

PR #6787 changed the behavior of the `--EXTENSIONS--` section, so that
not yet loaded extensions are dynamically loaded if possible. However,
when no tests are specified for the runner, only tests for already
loaded extensions are run, what defeats the purpose of the improvement
of the `--EXTENSIONS--` behavior. We cater to that by detecting
loadable extensions, and also run their tests.

show more ...

Use shell-free proc_open() in parallel run-tests.php

Remove no longer used "log_errors_max_len" ini directive (#6838)

This is a re-application of the original match against master.
The patch was originally applied to master, then reverted

Remove no longer used "log_errors_max_len" ini directive (#6838)

This is a re-application of the original match against master.
The patch was originally applied to master, then reverted from
there, incorrectly applied to PHP-8.0, reverted from there due
to ABI break, and now lands on master again. We can only hope
that it does not get reverted again ;)

show more ...

Revert "Remove no longer used "log_errors_max_len" ini directive (#6838)"

This reverts commit d2d227e54765a5de863c6608fd64e1228ab08108.

This is an ABI break.

Revert "Remove no longer used "log_errors_max_len" ini directive (#6838)"

This reverts commit cc2c810dcf4ea25ed73d97765b5df9f270a91a4a.

Remove no longer used "log_errors_max_len" ini directive (#6838)

Remove no longer used "log_errors_max_len" ini directive (#6838)

run-tests: Fix warning when specifying xdebug as a required extension

Migrate skip checks to --EXTENSIONS--, p2

For rationale, see https://github.com/php/php-src/pull/6787

Make extension checks lowercase, add a special case for opcache
that has in

Migrate skip checks to --EXTENSIONS--, p2

For rationale, see https://github.com/php/php-src/pull/6787

Make extension checks lowercase, add a special case for opcache
that has internal name not matching .so filename.

Extensions migrated in part 2:
* dom
* exif
* fileinfo
* ffi

show more ...

Removes 'Parallel Edition' output in tests

Closes GH-6806.

run-tests: use the EXTENSIONS section for skipping

Currently, most skip checks are just for making sure an extension is
available. Even with recent addition of skip caching, this makes t

run-tests: use the EXTENSIONS section for skipping

Currently, most skip checks are just for making sure an extension is
available. Even with recent addition of skip caching, this makes tests
needlessly slow:
* Checks for the same extension in its tests can have small differences
impacting cacheability.
* Even identical skip checks in two tests can still be executed twice if
they're run by different workers.

To remedy this, I'm repurposing the existing --EXTENSIONS-- section of
.phpt files to specify wjich extensions are required for current test to
run. Current behavior:
1) If the extension is already visible to PHP, all is good
2) If it isn't, assume it's present as a shared module and attempt to add
it via a command line parameter
3) If that works, all is good
4) If it doesn't, PHP fails with a cryptic error message trying to
execute the test itself

After this commit:
1) and 2) are kept unchanged
3) Check if shared extension file from 2) is actually present
4) Skip the test if it isn't

Other benefits include clear skip reasons (vs. sometimes none in many
current skip checks) and moving test information from code to metadata,
opening more opportunities for search and analysis.

Since --EXTENSIONS-- is barely ever used, this change poses no risk of
hidden failures.

As a demonstration of the new approach, this commit migrates one
extension to it. If merged, I will migrate other extensions in
subsequent PRs.

Closes GH-6787.

show more ...

run-tests.php: class for test file loading

This moves a bunch of code outside of run_tests(), making it a bit
more manageable. Additionally, accessors provide better readability
than

run-tests.php: class for test file loading

This moves a bunch of code outside of run_tests(), making it a bit
more manageable. Additionally, accessors provide better readability
than isset() and friends.

This is a minimal patch that moves the code but does not refactor
much. For the sake of reviewing experience, it does not involve
further refactoring which could include:
* Removing setSection()
* Fixing up the mess with hasSection() vs. sectionNotEmpty(), only
one of which is really needed.
* Moving more repetitive code into the new class.
All of this will be done with later commits.

Closes GH-6678.

show more ...

Make the nocache tag actually work

If nocache is used, then we should return an empty string result,
so the test doesn't get marked as borked.

Also limit to an occurrence at the

Make the nocache tag actually work

If nocache is used, then we should return an empty string result,
so the test doesn't get marked as borked.

Also limit to an occurrence at the start, just like other skip
tags.

show more ...

Add mechanism to skip the skipif cache

If the SKIPIF section return nocache, don't cache the result. This
is used by tests that perform complex test set in conjunction with
skip chec

Add mechanism to skip the skipif cache

If the SKIPIF section return nocache, don't cache the result. This
is used by tests that perform complex test set in conjunction with
skip checks, and need to be evaluated every time.

show more ...

run-tests.php: Preserve .php on leak in one more place

run-tests: drop support for ancient Valgrind versions

Valgrind 3.3.0 was released in 2007, not even RHEL has crap older than
this. It could be argued that 3.8.0, released in 2012, could

run-tests: drop support for ancient Valgrind versions

Valgrind 3.3.0 was released in 2007, not even RHEL has crap older than
this. It could be argued that 3.8.0, released in 2012, could be a safe
cutoff too.

Closes GH-6728.

show more ...