Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool is retained as an alias.

show more ...

Don't throw from imagecreatefromstring() with too short string

If the string is too short, we should treat this the same way as
an unrecognized image type. This function should be usable

Don't throw from imagecreatefromstring() with too short string

If the string is too short, we should treat this the same way as
an unrecognized image type. This function should be usable to
determine whether something is a valid image without doing any
checks beforehand.

show more ...

Fix zpp for GdFont|int

Use Z_PARAM_OBJ_OF_TYPE_OR_LONG to get standard behavior.

Don't allow properties on former resource objects

Don't allow properties on GdImage

Just like all the other former resources... we missed this case.

Convert gdFont from resource to object

Remove IGNORE_URL_WIN macro

This macro is defined to zero as of PHP 5.0.0, and as the comment
indicates, is no longer relevant. Thus, we remove the definition and
all usages from th

Remove IGNORE_URL_WIN macro

This macro is defined to zero as of PHP 5.0.0, and as the comment
indicates, is no longer relevant. Thus, we remove the definition and
all usages from the core and bundled extensions.

Closes GH-6351.

show more ...

Fix null foreground in imagewbmp

The variable was not actually passed to zpp...

Update ext/gd parameter names

Closes GH-6308.

Add test instantiating all objects

Intended to find issues in opaque object destructors.

Closes GH-6251.

Consolidate the usage of "either" and "one of" in error messages

Closes GH-6173

Fix UNKNOWN default values in various extensions

Closes GH-6075

Promote warnings to exceptions in ext/gd

Closes GH-6023

Fix the default value handling of imagegif()

Fix UNKNOWN default values in ext/mbstring and ext/gd

Closes GH-5598

Explode _php_image_output_ctx() into multiple functions

Closes GH-5844

Export php_gd_libgdimageptr_from_zval_p()

Some extension may need to retrieve the `gdImagePtr` from an `GdImage`
object; thus, we export the respective function. To not being forced

Export php_gd_libgdimageptr_from_zval_p()

Some extension may need to retrieve the `gdImagePtr` from an `GdImage`
object; thus, we export the respective function. To not being forced
to include gd.h in php_gd.h, we use the opaque `struct gdImageStruct *`
as return type.

We also rename php_gd2.dll to php_gd.dll, since there's not really much
point in giving the DLL a version number, since there is no php_gd.dll
for years (if there ever has been). Renaming, on the other hand,
matches the name on other systems (gd.so), and allows to actually use
`ADD_EXTENSION_DEP()`.

show more ...

Review the usage of apostrophes in error messages

Closes GH-5590

Remove proto comments from C files

Closes GH-5758

Use ZEND_UNREACHABLE() instead of ZEND_ASSERT(0)

Instead of marking unreachable code with `ZEND_ASSERT(0)`, we introduce
`ZEND_UNREACHABLE()`, so that MSVC which does not consider `asser

Use ZEND_UNREACHABLE() instead of ZEND_ASSERT(0)

Instead of marking unreachable code with `ZEND_ASSERT(0)`, we introduce
`ZEND_UNREACHABLE()`, so that MSVC which does not consider `assert(0)`
to mark unreachable code does no longer trigger C4715[1] warnings in
debug builds. This may be useful for other compilers as well.

[1] <https://docs.microsoft.com/de-de/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4715?view=vs-2019>

show more ...

Fix [-Wundef] warning in GD extension

Code tweaks: Remove unneeded semicolons

workaround typo in system libgd 2.3.0

Improve some TypeError and ValueError messages

Closes GH-5377

Improve some ValueError messages

Closes GH-5340