style/readability updates

GH-7979: iterator advances when checking if valid

Fixed #7752, #8101, #81660: DateTimeZone::getTransitions() returns insufficient data

Fix #81500: Interval serialization regression since 7.3.14 / 7.4.2

While it may not be desired, `DateInterval::$f` supports negative
values, at least with regard to calculations. We sti

Fix #81500: Interval serialization regression since 7.3.14 / 7.4.2

While it may not be desired, `DateInterval::$f` supports negative
values, at least with regard to calculations. We still need to guard
from assigning double values which are out of range for signed 64bit
integers (which would be undefined behavior). zend_dval_to_lval() does
this by returning `0` instead of triggering UB. This way we can avoid
setting the invalid marker, which doesn't work as expected anyway.

We must not do that only for unserialization, but also when the property
is set in the first place.

We need to adapt some of the existing tests wrt. this behavior. In
particular, we check for an arbitrary value in bug79015.phpt, to cater
to differences between 32bit and 64bit architectures.

Closes GH-7575.

show more ...

Fixed bug #81504: Incorrect timezone transition details for POSIX data

Voidify php_date_interval_initialize_from_hash()

Use bool/zend_result instead of int in Date extension

Revert "Fix DATE_FORMAT_COOKIE definition"

This reverts commit ac34648cf6bf5493a8cd1a4c9a82406599f3f25c.

As pointed out on GH-6783, the new format doesn't match any of
the speci

Revert "Fix DATE_FORMAT_COOKIE definition"

This reverts commit ac34648cf6bf5493a8cd1a4c9a82406599f3f25c.

As pointed out on GH-6783, the new format doesn't match any of
the specified formats. Previously the constant generated

Thursday, 14-Jul-2005 22:30:41 BST

which is obsolete. Now it generates

Thu, 14-Jul-2005 22:30:41 BST

which is not specified at all. The correct version would be:

Thu, 14 Jul 2005 22:30:41 BST

Reverting the change for now.

show more ...

Fix DATE_FORMAT_COOKIE definition

In all of http://curl.haxx.se/rfc/cookie_spec.html,
https://docs.microsoft.com/de-de/windows/win32/wininet/http-cookies
and https://tools.ietf.org/h

Fix DATE_FORMAT_COOKIE definition

In all of http://curl.haxx.se/rfc/cookie_spec.html,
https://docs.microsoft.com/de-de/windows/win32/wininet/http-cookies
and https://tools.ietf.org/html/rfc7234#section-5.3 the cookie
datetime is specified as Mon, DD-Mon-YYYY HH:MM:SS GMT. However,
the current definition returns Monday, DD-Mon-YYY HH:MM:SS GMT.
Therefore, the "l" in "l, d-M-Y H:i:s T" must be changed to "D".

Closes GH-6783.

show more ...

Fixed bug #80963: DateTimeZone::getTransitions() truncated

Move date timezone cache destruction to post deactivate

Some extensions try to use the date features in their own shutdown,
most notably some logging functions. Because of that, move the

Move date timezone cache destruction to post deactivate

Some extensions try to use the date features in their own shutdown,
most notably some logging functions. Because of that, move the
cache tear down until after these resources have been cleaned up.

show more ...

Fixed some spaces used instead of tabs

Throw directly instead of replacing error handler in ext/date (#6954)

Use zend_string_concat3 in one place

A bit nicer than snprintf + passing the same length around three
times.

Refactor php_date_initialize_from_hash()

Use early returns
Formalize return type to bool

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Introduce pseudo-keyword ZEND_FALLTHROUGH

And use it instead of comments

Upgrade timelib to 2021.03 and fix many date/time issues

Use zend_string_equals() API instead of strcmp() in Date extension

Avoid useless date conversion

Generate class entries for a few extensions

Relates to GH-6644

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool is retained as an alias.

show more ...

Promote a few forgotten warnings to exceptions

Closes GH-6211

Add some ValueErrors to ext/date

Closes GH-5613

Slightly improve error handling in DatePeriod::__construct()