Autotools: Quote all PHP_ADD_BUILD_DIR arguments (#14947)

- All arguments quoted for consistency
- m4_normalize used where list of directories becomes a bit simpler to
read and see

Autotools: Quote all PHP_ADD_BUILD_DIR arguments (#14947)

- All arguments quoted for consistency
- m4_normalize used where list of directories becomes a bit simpler to
read and see the diff

show more ...

Autotools: Trim redundant newlines in PHP_ADD_BUILD_DIR (#14946)

This reduces redundant newlines in the generated configure script while
keeping possible 'dnl' usage before or after this

Autotools: Trim redundant newlines in PHP_ADD_BUILD_DIR (#14946)

This reduces redundant newlines in the generated configure script while
keeping possible 'dnl' usage before or after this macro call working as
before (backwards compatible).

show more ...

Autotools: Enhance PHP_EVAL_LIBLINE M4 macro (#14924)

PHP_EVAL_LIBALINE macro processes the given libraries flags (-l) and/or
library paths flags (-L) and appends the -l flags to either

Autotools: Enhance PHP_EVAL_LIBLINE M4 macro (#14924)

PHP_EVAL_LIBALINE macro processes the given libraries flags (-l) and/or
library paths flags (-L) and appends the -l flags to either LIBS or the
given *_SHARED_LIBADD variables. The -L flags are appended to the
LDFLAGS. The new 3rd argument enables appending libraries to the given
variable in the 2nd argument without manual setting whether the
extension is shared. For example, to simplify usage in SAPIs where
additional libraries need to be appended but they shouldn't go to the
global LIBS. This can be then used in PHP-FPM SAPI to link apparmor,
SELinux, systemd, etc.

show more ...

Autotools: Sync CS for PHP_EBCDIC and PHP_C_BIGENDIAN (#14923)

- Over-quoted arguments reduced
- CS synced a bit
- AS_VAR_IF used instead of raw shell "if test"

Autotools: Move php_shtool variable initialization to PHP_INIT_BUILD_SYSTEM (#14904)

As this script is still needed across the PHP build system its path can
be also set on once place for

Autotools: Move php_shtool variable initialization to PHP_INIT_BUILD_SYSTEM (#14904)

As this script is still needed across the PHP build system its path can
be also set on once place for both phpize usage and regular php-src's
configure.ac.

show more ...

Autotools: Refactor builtin checks (#14835)

This creates a single M4 macro PHP_CHECK_BUILTIN and removes other
PHP_CHECK_BUILTIN_* macros. Checks are wrapped in AC_CACHE_CHECK and
PH

Autotools: Refactor builtin checks (#14835)

This creates a single M4 macro PHP_CHECK_BUILTIN and removes other
PHP_CHECK_BUILTIN_* macros. Checks are wrapped in AC_CACHE_CHECK and
PHP_HAVE_BUILTIN_* CPP macro definitions are defined to 1 if builtin
is found and undefined if not.

This also changes all PHP_HAVE_BUILTIN_ symbols to be either undefined
or defined (to value 1) and syncs all #if/ifdef/defined usages of them
in the php-src code. This way it is simpler to use them because they
don't need to be defined to value 0 on Windows, for example. This is
done as previous usages in php-src were mixed and on many places they
were only checked with ifdef.

show more ...

Check Apache HTTP Server command-line utility (#14173)

The Apache HTTP server command-line tool (/usr/sbin/apache2) might be
part of a separate package, such as apache2-bin or similar. I

Check Apache HTTP Server command-line utility (#14173)

The Apache HTTP server command-line tool (/usr/sbin/apache2) might be
part of a separate package, such as apache2-bin or similar. If not
installed, the configure script can still find the apxs tool, but
previously didn't check for the HTTP server tool separately. Otherwise,
configure syntax errors (integer expression expected) are thrown when
checking for the Apache version.

show more ...

Autotools: Simplify POSIX Threads check (#14855)

The PTHREADS_CHECK is using cache variables so it is run only once early
during the configuration phase, before including SAPI and other

Autotools: Simplify POSIX Threads check (#14855)

The PTHREADS_CHECK is using cache variables so it is run only once early
during the configuration phase, before including SAPI and other M4
files. This removes the TSRM_CHECK_PTHREADS macro and moves the POSIX
Threads check after the PHP_THREAD_SAFETY variable is set in
configure.ac.

The check and error throw in PHP_BUILD_THREAD_SAFE is also joing into
this single check.

This removes the redundant tsrm.m4 file and PHP_CONFIGURE_PART call for
TSRM as it doesn't run any configuration checks anymore.

show more ...

Autotools: Refactor AVX-512 checks (#14831)

* Autotools: Refactor AVX-512 checks

- CS synced
- checks wrapped in AC_CACHE_CHECK
- CPP macros PHP_HAVE_AVX512_SUPPORTS and PHP

Autotools: Refactor AVX-512 checks (#14831)

* Autotools: Refactor AVX-512 checks

- CS synced
- checks wrapped in AC_CACHE_CHECK
- CPP macros PHP_HAVE_AVX512_SUPPORTS and PHP_HAVE_AVX512_VBMI_SUPPORTS
are now either defined to 1 or undefined to avoid manual defining on
Windows (previously they should be either 0 or 1)

* [skip ci] Add basic macros help texts

show more ...

Autotools: Refactor PHP_BROKEN_GCC_STRLEN_OPT (#14824)

- Synced CS
- Cache variable ac_cv_have_broken_gcc_strlen_opt renamed to
php_cv_have_broken_gcc_strlen_opt

Autotools: Refactor PHP_TIME_R_TYPE check (#14823)

- Synced CS
- Cache variable ac_cv_time_r_type renamed to php_cv_time_r_type

Autotools: Refactor crypt_r style check (#14820)

- Over-quoted arguments reduced
- AS_VAR_IF and CS synced
- CPP macro help texts updated

Autotools: Refactor PHP_TEST_WRITE_STDOUT check (#14819)

- AS_VAR_IF, AS_CASE used, CS synced
- Over-quoted argument reduced
- Cache variable ac_cv_write_stdout renamed to php_cv_hav

Autotools: Refactor PHP_TEST_WRITE_STDOUT check (#14819)

- AS_VAR_IF, AS_CASE used, CS synced
- Over-quoted argument reduced
- Cache variable ac_cv_write_stdout renamed to php_cv_have_write_stdout
- CPP macro help text updated

show more ...

Autotools: Sync PHP_ADD_MAKEFILE_FRAGMENT (#14766)

- Macro help text updated for extensions and general usage
- Arguments quoted
- dnl removes redundant newlines in the generated con

Autotools: Sync PHP_ADD_MAKEFILE_FRAGMENT (#14766)

- Macro help text updated for extensions and general usage
- Arguments quoted
- dnl removes redundant newlines in the generated configure script

show more ...

Autotools: Quote PHP_SUBST arguments in php.m4 (#14758)

Sync PHP_SUBST_OLD (#14746)

- All arguments quoted
- PHP_VERSION, PHP_VERSION_ID, PHP_LDFLAGS are used only in templates
with @...@ placeholders
- These are not used in generat

Sync PHP_SUBST_OLD (#14746)

- All arguments quoted
- PHP_VERSION, PHP_VERSION_ID, PHP_LDFLAGS are used only in templates
with @...@ placeholders
- These are not used in generated Makefile neither in templates:
abs_builddir, abs_srcdir, DEBUG_CFLAGS
- These are used only in generated Makefile: EXTRA_LDFLAGS,
EXTRA_LDFLAGS_PROGRAM, ZEND_EXTRA_LIBS, INCLUDES, EXTRA_INCLUDES,
INSTALL_IT, NATIVE_RPATHS

show more ...

Autotools: Sync indentation style in build system files (#14725)

Autotools: Move HAVE_DTRACE and PHP_DTRACE_OBJS to PHP_INIT_DTRACE (#14722)

The sys/sdt.h is required header when using DTrace, HAVE_DTRACE can be
defined together when initializing and

Autotools: Move HAVE_DTRACE and PHP_DTRACE_OBJS to PHP_INIT_DTRACE (#14722)

The sys/sdt.h is required header when using DTrace, HAVE_DTRACE can be
defined together when initializing and PHP_DTRACE_OBJS can be
substituted to simplify the macro usage a bit further.

show more ...

Rely on Autoconf's automatic removal of conftest* files (#14697)

When test programs are finished or when configure script is interrupted,
Autoconf cleans up all conftest* files.

Normalize AC_CHECK_FUNC* first argument (#14700)

The m4_normalize is for Autoconf < 2.70 (on 2.70 and later versions a
blank-or-newline separated items can be expanded without using

Normalize AC_CHECK_FUNC* first argument (#14700)

The m4_normalize is for Autoconf < 2.70 (on 2.70 and later versions a
blank-or-newline separated items can be expanded without using
backslash-newline).

This also syncs the 1st argument quotes.

show more ...

Bump minimum libpq version to 10.0 (#14628)

This bumps the libpq client-side PostgreSQL library minimum required
version from 9.1 to 10.0.

- Sanity check: PQlibVersion -> PQencr

Bump minimum libpq version to 10.0 (#14628)

This bumps the libpq client-side PostgreSQL library minimum required
version from 9.1 to 10.0.

- Sanity check: PQlibVersion -> PQencryptPasswordConn (available since
libpq 10.0)
- PQsetErrorContextVisibility (available since libpq 9.6)
- lo_truncate64 (available since libpq 9.3), if 32-bit system doesn't
support lo_*64 functions, error is returned and functions are always
available

Additionally, the conditional functions usages in pdo_pgsql and pgsql
extensions that got piled up are cleaned and synced:

- pg_prepare (PQprepare available since libpq 7.4)
- pg_query_params (PQexecParams available since libpq 7.4)
- pg_result_error_field (PQresultErrorField available since libpq 7.4)
- pg_send_prepare (PQsendPrepare available since libpq 7.4)
- pg_send_query_params (PQsendQueryParams available since libpq 7.4)
- pg_set_error_verbosity (PQsetErrorVerbosity available since libpq 7.4)
- pg_transaction_status (PQtransactionStatus available since libpq 7.4)

The Windows libpq version is currently at version 11.4:
https://github.com/winlibs/postgresql

Discussion: https://news-web.php.net/php.internals/123609
Follow-up of GH-14540

show more ...

Define default RE2C_FLAGS (#14615)

The --no-generation-date flag is a common re2c flag used in all re2c
invocations. This adds the 2nd optional argument to PHP_PROG_RE2C M4
macro in

Define default RE2C_FLAGS (#14615)

The --no-generation-date flag is a common re2c flag used in all re2c
invocations. This adds the 2nd optional argument to PHP_PROG_RE2C M4
macro in BC manner to set the default re2c command-line options and sets
the default RE2C_FLAGS similarly on Windows.

show more ...

Add optional pkg-config support for PostgreSQL library (libpq) (#14540)

The pkg-config (libpq.pc file) was added in PostgreSQL 9.3. This adds a
common setup M4 macro PHP_SETUP_PGSQL to f

Add optional pkg-config support for PostgreSQL library (libpq) (#14540)

The pkg-config (libpq.pc file) was added in PostgreSQL 9.3. This adds a
common setup M4 macro PHP_SETUP_PGSQL to find client PostgreSQL library
libpq on the system with pkg-config. If not found, check falls back to
pg_config to find the libpq and its headers in common locations as
before.

The PGSQL_CFLAGS and PGSQL_LIBS environment variables can override the
libpq installation paths:

./configure --with-pgsql --with-pdo-pgsql \
PGSQL_CFLAGS=-I/path/to/libpq \
PGSQL_LIBS="-L/path/to/libpq -lpq"

Passing manual, non-standard PostgreSQL installation path can be done
with configure option arguments:

./configure \
--with-pgsql=/any/path/to/postgresql \
--with-pdo-postgresql=/any/path/to/postgresql

If this DIR argument (PostgreSQL installation directory or path to the
pg_config) is passed, it takes precedence over the pkg-config, when
installed on the system.

This also removes the unused HAVE_LIBPQ symbol and passing the
PGSQL_INCLUDE and PGSQL_LIBDIR environment variable to configure in
favor of PGSQL_CFLAGS and PGSQL_LIBS.

Instead of the obsolete backticks the recommended $(...) is used when
invoking the pg_config.

Follow-up of GH-4235 (Use PKG_CHECK_MODULES to detect the pq library)

show more ...

Add PHP_SETUP_ZLIB M4 macro (#14591)

This enables the zlib library (https://zlib.net/) from a single place to
match the minimum required version across the php-src. This provides a
p

Add PHP_SETUP_ZLIB M4 macro (#14591)

This enables the zlib library (https://zlib.net/) from a single place to
match the minimum required version across the php-src. This provides a
possible simpler version bump in the future. Macro's 2nd and 3rd
arguments can pass additional actions whether zlib library is found or
not for the possible future adjustments in the ext/standard where also
zlib might be required.

Support for pkg-config was introduced in 1.2.3.1.
The minimum zlib version has been bumped to 1.2.3.1



* Bump minimum zlib version to 1.2.11

This is aligned with CentOS 8, which has 1.2.11 in the default packages.

* [skip ci] Move zlib version change to UPGRADING

This matches the OpenSSL style version change notice already done in
this file.

show more ...

Fix incompatible function pointer types

Closes #14549