Autotools: Refactor iconv implementation checks (#15357)

This uses AS_* macros and checks for an iconv implementation in a single
cache check block for easier configure log output and po

Autotools: Refactor iconv implementation checks (#15357)

This uses AS_* macros and checks for an iconv implementation in a single
cache check block for easier configure log output and possible future
adjustments when iconv is built-in the C library (like on Alpine and
some other systems where it isn't recognized as such yet exactly).

show more ...

Autotools: Quote AC_CHECK_PROG* macro arguments

[skip ci]

Autotools: Add phpized configure log and help separators (#15251)

- This quotes all PHP_CONFIGURE_PART arguments
- When configuring and building extensions with phpize, this makes the

Autotools: Add phpized configure log and help separators (#15251)

- This quotes all PHP_CONFIGURE_PART arguments
- When configuring and building extensions with phpize, this makes the
'./configure --help' and './configure' log output a bit more readable
as it separates the extension configuration, Libtool configuration and
the rest of the Autoconf and phpize configuration options.
- The ./configure output separators bold tags are moved to the
PHP_INIT_BUILD_SYSTEM macro to be available also in phpized extensions
- The obsolete ticks `...` converted to the recommended $(...); Autoconf
configure re-executes itself in shells where the $(...) still wouldn't
work ok. For example, the default, initial, non-updated shell on
Solaris 10.
- Empty new lines in help separators synced (Autoconf default separators
don't include additional empty newline after the separator title);
so the PHP_HELP_SEPARATOR additional empty line is also removed
(see './configure --help' output)

show more ...

Autotools: Replace AC_MSG_ERROR with AC_MSG_FAILURE (#15209)

This replaces the AC_MSG_ERROR with AC_MSG_FAILURE, where appropriate.

The AC_MSG_ERROR outputs given message and exits

Autotools: Replace AC_MSG_ERROR with AC_MSG_FAILURE (#15209)

This replaces the AC_MSG_ERROR with AC_MSG_FAILURE, where appropriate.

The AC_MSG_ERROR outputs given message and exits the configure step. The
AC_MSG_FAILURE does the same but also automatically outputs additional
message "See 'config.log' for more details." which might help directing
the user where to look further.

The AC_MSG_ERROR is used for errors where current test step isn't logged
in the config.log and wouldn't make sense, and AC_MSG_FAILURE is mostly
used in cases of library checks, compilation tests, headers checked with
AC_CHECK_HEADER* and similar tests that are also logged in the
config.log.

AC_MSG_ERROR([Sanity check failed.]) output:

```
configure: error: Sanity check failed.
```

AC_MSG_FAILURE([Sanity check failed.]) output:

```
configure: error: in '/path/to/php-src':
configure: error: Sanity check failed.
See 'config.log' for more details
```

show more ...

Replace PHP_OUTPUT with AC_CONFIG_FILES (#15186)

This is a follow-up of GH-15177
(c96f08aa70d75736fe227975804f998c408acaaf)
and GH-15185
(9467ffb43c0eb271f32f6e435799ccc36bc2b52b

Replace PHP_OUTPUT with AC_CONFIG_FILES (#15186)

This is a follow-up of GH-15177
(c96f08aa70d75736fe227975804f998c408acaaf)
and GH-15185
(9467ffb43c0eb271f32f6e435799ccc36bc2b52b)

The PHP_OUTPUT macro was introduced in the very early phase of the build
system due to AC_OUTPUT handling issues in the old Autoconf versions
before the AC_CONFIG_FILES, AC_CONFIG_COMMANDS etc were introduced with
the AC_OUTPUT signature without arguments. The PHP_OUTPUT was also
helping Makefile.in back then being properly generated based on whether
all files were generated or only some (when using the obsolete
CONFIG_FILES=... ./config.status invocation instead of the new
./config.status --file=...). Another issue is that PHP_OUTPUT can't be
used by extensions when using phpize.

This replaces the PHP_OUTPUT invocations with default AC_CONFIG_FILES.

The obsolete "REDO_ALL" feature at the config.status invocation is also
removed with a simpler unconditional generation.

In phar extension the "ext/phar" is replaced with $ext_dir variable to
be able to use phpize.

show more ...

Sync CPP macros in ext/iconv (#15191)

This syncs and adds help texts for CPP macros defined when iconv
extension is configured.

Autotools: Update php.m4 CPP macros help texts (#15188)

- COMPILE_DL_<extension>
- COOKIE_SEEKER_USES_OFF64_T
- HAVE_BROKEN_GETCWD
- HAVE_LIBEXPAT
- HAVE_PREAD
- HAVE_PWR

Autotools: Update php.m4 CPP macros help texts (#15188)

- COMPILE_DL_<extension>
- COOKIE_SEEKER_USES_OFF64_T
- HAVE_BROKEN_GETCWD
- HAVE_LIBEXPAT
- HAVE_PREAD
- HAVE_PWRITE
- MISSING_ASCTIME_R_DECL
- MISSING_CTIME_R_DECL
- MISSING_GMTIME_R_DECL
- MISSING_LOCALTIME_R_DECL
- MISSING_STRTOK_R_DECL
- PHP_PREAD_64
- PHP_PWRITE_64
- SIZEOF_<type>
- HAVE_<type>

show more ...

Autotools: Normalize PHP_OUTPUT arguments (#15177)

The m4_normalize([$1]) normalizes items into a single-space-separated
list of files to append them to the global PHP_OUTPUT_FILES varia

Autotools: Normalize PHP_OUTPUT arguments (#15177)

The m4_normalize([$1]) normalizes items into a single-space-separated
list of files to append them to the global PHP_OUTPUT_FILES variable
that is processed by AC_CONFIG_FILES. Redundant newlines are also
removed in the generated configure script.

PHP extensions using phpize can't use this macro so it's safe to change
this.

show more ...

Autotools: Move HAVE_DTRACE to configure.ac (#15160)

Following 32210ce967e169845c8e226286d5f736421953f0 and
9ea290b72b8ba5413c3d9737cd05dfc71ed938d2, this moves the HAVE_DTRACE
prepr

Autotools: Move HAVE_DTRACE to configure.ac (#15160)

Following 32210ce967e169845c8e226286d5f736421953f0 and
9ea290b72b8ba5413c3d9737cd05dfc71ed938d2, this moves the HAVE_DTRACE
preprocessor macro definition back to configure.ac so that
PHP_INIT_DTRACE Autoconf macro can be used in extensions without
redefinition interference.

show more ...

Sync HAVE_ICONV preprocessor macro usage (#15148)

HAVE_ICONV marks that PHP extension 'iconv' is available, and not only
that iconv library or its functions/headers are available.

Autotools: Quote PHP_CHECK_LIBRARY arguments (#15136)

This syncs the quotes across the PHP_CHECK_LIBRARY macro arguments.

Autotools: Sync PHP_EXT_* M4 macros (#15134)

PHP_EXT_DIR, PHP_EXT_BUILDDIR, and PHP_EXT_SRCDIR macros don't accept
the argument since 82b73fd1e3c53228bb31b75a446114b5fd0cd240.

Autotools: Simplify PHP_ALWAYS_SHARED macro (#15129)

Instead of defining an empty M4 macro PHP_ALWAYS_SHARED when configuring
extensions in php-src using the main configure.ac, the m4_if

Autotools: Simplify PHP_ALWAYS_SHARED macro (#15129)

Instead of defining an empty M4 macro PHP_ALWAYS_SHARED when configuring
extensions in php-src using the main configure.ac, the m4_ifdef can be
used to conditionally call the macro when it is defined (when using
phpize).

show more ...

Autotools: Sync CS in XML related extensions (#15110)

- PHP_SETUP_LIBXML arguments quoted
- Help texts updated for HAVE_LIBXML, HAVE_DOM, HAVE_XMLREADER,
HAVE_XMLWRITER, HAVE_SOAP,

Autotools: Sync CS in XML related extensions (#15110)

- PHP_SETUP_LIBXML arguments quoted
- Help texts updated for HAVE_LIBXML, HAVE_DOM, HAVE_XMLREADER,
HAVE_XMLWRITER, HAVE_SOAP, HAVE_SIMPLEXML, and HAVE_XML CPP macros
- Duplicate HAVE_LIBXML symbol definition in PHP_SETUP_LIBXML M4 macro
removed (the HAVE_LIBXML marks that PHP libxml extension is available and
not only that libxml2 library is available)

show more ...

Autotools: Quote and fix PHP_SELECT_SAPI arguments (#15118)

This macro once had also the 5th argument (the build target), which was
removed via 2a6da0f24cbd04361c044c1cdf6b6b30d08a245e.

Autotools: Quote and fix PHP_SELECT_SAPI arguments (#15118)

This macro once had also the 5th argument (the build target), which was
removed via 2a6da0f24cbd04361c044c1cdf6b6b30d08a245e. This quotes all
PHP_SELECT_SAPI arguments and removes the redundant ones. The basic
macro usage help text is moved to the macros section from the obsolete
docs file.

show more ...

Autotools: Replace PHP_DEF_HAVE with AC_DEFINE_UNQUTED (#15119)

The PHP_DEF_HAVE M4 macro is a simple wrapper around the recommended
AC_DEFINE or AC_DEFINE_UNQUOTED (when shell variables

Autotools: Replace PHP_DEF_HAVE with AC_DEFINE_UNQUTED (#15119)

The PHP_DEF_HAVE M4 macro is a simple wrapper around the recommended
AC_DEFINE or AC_DEFINE_UNQUOTED (when shell variables are used in
arguments). This also adds some basic help texts to macros.

show more ...

Autotools: Quote AC_CHECK_LIB arguments (#15116)

This syncs CS for AC_CHECK_LIB where possible, and adds minor help texts
to gettext extension AC_DEFINE symbols, including the HAVE_LIBIN

Autotools: Quote AC_CHECK_LIB arguments (#15116)

This syncs CS for AC_CHECK_LIB where possible, and adds minor help texts
to gettext extension AC_DEFINE symbols, including the HAVE_LIBINTL.

show more ...

Autotools: Normalize DTrace sources argument (#15111)

Using the m4_normalize, the source files can be added more intuitively
using blank-or-newline delimited list of files. This adds als

Autotools: Normalize DTrace sources argument (#15111)

Using the m4_normalize, the source files can be added more intuitively
using blank-or-newline delimited list of files. This adds also some
basic help text.

show more ...

Autotools: Quote PHP_ADD_LIB* arguments (#15112)

Following previous CS syncs, this quotes arguments in PHP_ADD_LIB* M4
macros:
- PHP_ADD_LIBRARY
- PHP_ADD_LIBRARY_WITH_PATH
-

Autotools: Quote PHP_ADD_LIB* arguments (#15112)

Following previous CS syncs, this quotes arguments in PHP_ADD_LIB* M4
macros:
- PHP_ADD_LIBRARY
- PHP_ADD_LIBRARY_WITH_PATH
- PHP_ADD_LIBPATH

show more ...

Autotools: Quote M4 arguments (#15033)

- PHP_ADD_INCLUDE
- PHP_EVAL_INCLINE
- PHP_EVAL_LIBLINE

Autotools: Expand m4_normalize sooner (#15018)

Quoted m4_normalize will expand and change its argument later in the
macro call when M4 is processing the *.m4 sources. Without quotes the

Autotools: Expand m4_normalize sooner (#15018)

Quoted m4_normalize will expand and change its argument later in the
macro call when M4 is processing the *.m4 sources. Without quotes the
already normalized string is passed to the macro directly. In these
specific cases generated configure script is the same. This is more for
consistency to have this synced and not repeat the pattern too much
in the future when copy/pasting. Note, that many AC_* macros require
similar behavior already (for example, AC_CHECK_FUNCS.)

show more ...

Autotools: Fix Autoconf syntax (erroneous dnl) (#14987)

M4 interprets the dnl in this combination of m4_ifnblank as part of the
preceding text so the [] can be used to avoid this issue.

Autotools: Add missing sigil in AC_CASE and fix Autoconf syntax (#14967)

Fix #78757: Enhance sendmail log notice (#14955)

The sendmail is set to default value of /usr/sbin/sendmail if not found
on the host system. This was already properly fixed via GH-5548

Fix #78757: Enhance sendmail log notice (#14955)

The sendmail is set to default value of /usr/sbin/sendmail if not found
on the host system. This was already properly fixed via GH-5548
(commit 517431892b292b039784c64decfb161f4a0664e9). This change now
also outputs "no" when searching for sendmail and a minimalistic notice
that default send_mail INI directive has been set to /usr/sbin/sendmail.

Fixes and closes: https://bugs.php.net/78757

show more ...

Autotools: Quote RE2C_FLAGS argument (#14950)

This enables and simplifies adding blank-or-newline-separated global
re2c flags to the PHP_PROG_RE2C macro possibly at some point. Fixed jus

Autotools: Quote RE2C_FLAGS argument (#14950)

This enables and simplifies adding blank-or-newline-separated global
re2c flags to the PHP_PROG_RE2C macro possibly at some point. Fixed just
in case, so this works normally:

PHP_PROG_RE2C([1.0.3], [--no-generation-date -W -foo])

show more ...