Fixed memory leak introduced by 73458e8f

Removed unused variables

Replaced zendi_convert_to_long() with _zval_get_long_func()

Moved zend_is_true() from zend_execute.h/zend_execute_API.c into zend_operators.h/zend_operators.c.
Splited the most expensive part of inline i_zend_is_true() into a separate zend_object_is_true(

Moved zend_is_true() from zend_execute.h/zend_execute_API.c into zend_operators.h/zend_operators.c.
Splited the most expensive part of inline i_zend_is_true() into a separate zend_object_is_true().
Replaced zendi_convert_to_long() with cals to zend_is_true().

show more ...

Move checks for references into slow paths of operator functions. Remove duplicate opcode handlers.

fix datatype mismatches

Useless assignment

Moved proxy object support in ASSIGN_ADD (and family) from VM to slow paths of corresponding operators

bring back all the TSRMLS_FETCH() stuff

for better comparability with the mainstream

cleanup TSRMLS_FETCH

fix C89 compat

reworked the patch, less new stuff but worky

TLS is already used in TSRM, the way exporting the tsrm cache through
a thread local variable is not portable. Additionally, the current

reworked the patch, less new stuff but worky

TLS is already used in TSRM, the way exporting the tsrm cache through
a thread local variable is not portable. Additionally, the current
patch suffers from bugs which are hard to find, but prevent it to
be worky with apache. What is done here is mainly uses the idea
from the RFC patch, but

- __thread variable is removed
- offset math and declarations are removed
- extra macros and definitions are removed

What is done merely is

- use an inline function to access the tsrm cache. The function uses
the portable tsrm_tls_get macro which is cheap
- all the TSRM_* macros are set to placebo. Thus this opens the way
remove them later

Except that, the logic is old. TSRMLS_FETCH will have to be done once
per thread, then tsrm_get_ls_cache() can be used. Things seeming to be
worky are cli, cli server and apache. I also tried to enable bz2
shared and it has worked out of the box. The change is yet minimal
diffing to the current master bus is a worky start, IMHO. Though will
have to recheck the other previously done SAPIs - embed and cgi.

The offsets can be added to the tsrm_resource_type struct, then
it'll not be needed to declare them in the userspace. Even the
"done" member type can be changed to int16 or smaller, then adding
the offset as int16 will not change the struct size. As well on the
todo might be removing the hashed storage, thread_id != thread_id and
linked list logic in favour of the explicit TLS operations.

show more ...

fix indentation

fix zts build

Optimized (PRE|POST)_(INC|DEC) handlers. Moved proxy object handling into helper function.

It is not likely a string

Make number printing functions less generic

Now that zend_ulong is 64bit on 64bit platforms, it should be
sufficient to always use it, rather than supporting multiple
types.

Make number printing functions less generic

Now that zend_ulong is 64bit on 64bit platforms, it should be
sufficient to always use it, rather than supporting multiple
types.

API changes:
* _zend_print_unsigned_to_buf and _zend_print_signed_to_buf
no longer exist.
* smart_str(ing)_print_long and smart_str(ing)_print_unsigned
no longer exist.
* Instead of all these, zend_print_ulong_to_buf and
zend_print_long_to_buf should be used.
* smart_str_append_generic_ex no longer exists.
* smart_str(ing)_append_off_t(_ex) no longer exists, use
smart_str(ing)_append_long(_ex) instead.

show more ...

Fixed useless or duplicated IS_INTERNED() checks

Split is_numeric_string_ex() into inline and non-inline parts

Use SIZEOF_ZEND_LONG instead of SIZEOF_LONG

We don't have to check for undefined CV if we fetch it for isset() operation

Fix $x .= $x

Also add a nice comment pointing out that concat runs on magic.

Fix string increment

Fix overflow check for string concatenation

Also do the overflow check for both branches, not just the realloc
one.

And clean up the code a bit - move common parts outside of th

Fix overflow check for string concatenation

Also do the overflow check for both branches, not just the realloc
one.

And clean up the code a bit - move common parts outside of the
realloc/alloc branches.

show more ...

Remove old zend_string_to_double function