Fixed bug #70681

Fixed bug #70630 (Closure::call/bind() crash with ReflectionFunction->getClosure())

Fixed infinity recurion if we create closure on top of other closure.

Fixed use after free

Fixed bug #70674 (ReflectionFunction::getClosure() leaks memory when used for internal functions)

Revert "Fixed bug #70630 (Closure::call/bind() crash with ReflectionFunction->getClosure())"

This reverts commit 517b5536259ecf7697f353f4bfbafde857fc1f81.

Revert "Improve 517b55362 (scope rebinding on method Closures)"

This reverts commit 881c50252066132f83e190325e344f532be19033.

Revert "Allow random $this on non-internal Closures again"

This reverts commit 35d0405c4790f0ce668c9e1b8b05197e55d29a05.

Allow random $this on non-internal Closures again
As it turns out, there is actually no reason to prevent this, it even was a bigger BC break than expected...

Also fixes a memory leak (t

Allow random $this on non-internal Closures again
As it turns out, there is actually no reason to prevent this, it even was a bigger BC break than expected...

Also fixes a memory leak (the Closure leaks) when calling internal functions via Closure by moving it out of leave helper onto caller side for TOP_CODE:

$z = new SplStack; $z->push(20);
$x = (new ReflectionMethod("SplStack", "pop"))->getClosure($z);
var_dump($x());

show more ...

Improve 517b55362 (scope rebinding on method Closures)
Now it is completely impossible to rebind a scoped method Closure (only the kind you get from ReflectionMethod::getClosure()) to a foreign s

Improve 517b55362 (scope rebinding on method Closures)
Now it is completely impossible to rebind a scoped method Closure (only the kind you get from ReflectionMethod::getClosure()) to a foreign scope
Adding a lot of tests to ensure this...
Also, properly return NULL in case the Closure could not be created instead of some crippled unbound Closure

show more ...

Fixed bug #70630 (Closure::call/bind() crash with ReflectionFunction->getClosure())
This additionally removes support for binding to an unknown (not in parent hierarchy) scope.
Removing suppo

Fixed bug #70630 (Closure::call/bind() crash with ReflectionFunction->getClosure())
This additionally removes support for binding to an unknown (not in parent hierarchy) scope.
Removing support for cross-scope is necessary for certain compile-time assumptions (like class constants) to prevent unexpected results

show more ...

Revert accidentally committed closures.c and execute.c

Optimize zend_mm_small_size_to_bin()
It removes a cmov operation and has a much faster branch for small allocations (especially when handling strings) (<= 64 bytes)

Fixed bug #70397 (Segmentation fault when using Closure::call and yield)

Mark error and exception functions as "cold" (Matt's idea)

Use NULL where possible for exception class

Matches usage of zend_throw_exception()/zend_throw_exception_ex().

Remove need to pass error level

Enable throwing custom exceptions from errors

Use ZSTR_ API to access zend_string elements (this is just renaming without semantick changes).

Fix more minor mistakes in the proto comments

Fix bad run_time_cache with Closure::call()
This also fixes a memory "leak" (memory is allocated on unbounded arena without limits) on each new Closure instantiation.
Closures with same scope

Fix bad run_time_cache with Closure::call()
This also fixes a memory "leak" (memory is allocated on unbounded arena without limits) on each new Closure instantiation.
Closures with same scope now all share the same run_time_cache (as long as it is arena allocated)

show more ...

Fixed bug #69802 (Reflection on Closure::__invoke borks type hint class name) (onr more problem)

Complete fix for problems related to bug #69802

Preserve VARIADIC flag for Closure::__invoke()

The 13 arguments are for the benefit of PHP 7, where the first
twelve use the bitmask.

Ban rebinding closures to different internal classes